[FFmpeg-devel] [PATCH] avutil/downmix_info: check for side data allocation success before zeroing it

[FFmpeg-devel] [PATCH] avutil/downmix_info: check for side data allocation success before zeroing it

[James Almer]

Fixes coverity #1641638.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavutil/downmix_info.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavutil/downmix_info.c b/libavutil/downmix_info.c
index feaee28493..7e6c3e854d 100644
--- a/libavutil/downmix_info.c
+++ b/libavutil/downmix_info.c
@@ -30,7 +30,8 @@ AVDownmixInfo *av_downmix_info_update_side_data(AVFrame *frame)
     if (!side_data) {
         side_data = av_frame_new_side_data(frame, AV_FRAME_DATA_DOWNMIX_INFO,
                                            sizeof(AVDownmixInfo));
-        memset(side_data->data, 0, sizeof(AVDownmixInfo));
+        if (side_data)
+            memset(side_data->data, 0, sizeof(AVDownmixInfo));
     }
 
     if (!side_data)
-- 
2.48.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avutil/downmix_info: check for side data allocation success before zeroing it

[epirat07]

On 28 Jan 2025, at 18:49, James Almer wrote:

> Fixes coverity #1641638.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavutil/downmix_info.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavutil/downmix_info.c b/libavutil/downmix_info.c
> index feaee28493..7e6c3e854d 100644
> --- a/libavutil/downmix_info.c
> +++ b/libavutil/downmix_info.c
> @@ -30,7 +30,8 @@ AVDownmixInfo *av_downmix_info_update_side_data(AVFrame *frame)
>      if (!side_data) {
>          side_data = av_frame_new_side_data(frame, AV_FRAME_DATA_DOWNMIX_INFO,
>                                             sizeof(AVDownmixInfo));
> -        memset(side_data->data, 0, sizeof(AVDownmixInfo));
> +        if (side_data)
> +            memset(side_data->data, 0, sizeof(AVDownmixInfo));
>      }
>
>      if (!side_data)
> -- 
> 2.48.1

LGTM

>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".