From: epirat07@gmail.com
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avutil/downmix_info: check for side data allocation success before zeroing it
Date: Tue, 28 Jan 2025 18:52:26 +0100
Message-ID: <7F6292FD-ED15-4A11-93B6-A6C78369E553@gmail.com> (raw)
In-Reply-To: <20250128174911.11367-1-jamrial@gmail.com>
On 28 Jan 2025, at 18:49, James Almer wrote:
> Fixes coverity #1641638.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavutil/downmix_info.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavutil/downmix_info.c b/libavutil/downmix_info.c
> index feaee28493..7e6c3e854d 100644
> --- a/libavutil/downmix_info.c
> +++ b/libavutil/downmix_info.c
> @@ -30,7 +30,8 @@ AVDownmixInfo *av_downmix_info_update_side_data(AVFrame *frame)
> if (!side_data) {
> side_data = av_frame_new_side_data(frame, AV_FRAME_DATA_DOWNMIX_INFO,
> sizeof(AVDownmixInfo));
> - memset(side_data->data, 0, sizeof(AVDownmixInfo));
> + if (side_data)
> + memset(side_data->data, 0, sizeof(AVDownmixInfo));
> }
>
> if (!side_data)
> --
> 2.48.1
LGTM
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-01-28 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 17:49 James Almer
2025-01-28 17:52 ` epirat07 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F6292FD-ED15-4A11-93B6-A6C78369E553@gmail.com \
--to=epirat07@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git