From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "anton@khirnov.net" <anton@khirnov.net>,
"ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: ignore nonexistent device in default DRM device selection
Date: Tue, 28 Nov 2023 02:45:55 +0000
Message-ID: <79e19643e36fe981f62ffe3e47b48b207893e9ee.camel@intel.com> (raw)
In-Reply-To: <170107425866.1197.13947716271182879266@lain.khirnov.net>
> Quoting Xiang, Haihao (2023-11-27 05:42:20)
> > >
> > > Also, the else is unnecessary since the if() block ends with continue.
> > >
> >
> > I wanted to print a message if all devices don't exist. I'll remove it in
> > the
> > new version if you think such info is unnecessary.
>
> I don't object to the message, I mean just that
>
> if (foo) {
> ....
> continue;
> } else
> bar;
>
> is equivalent to
>
> if (foo) {
> ....
> continue;
> }
>
> bar;
>
> The latter saves you one level of indentation and I find it more
> readable.
I got your point, many thanks for your explanations.
BRs
Haihao
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-11-28 2:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 6:17 Xiang, Haihao
2023-11-26 10:55 ` Anton Khirnov
2023-11-27 4:42 ` Xiang, Haihao
2023-11-27 8:37 ` Anton Khirnov
2023-11-28 2:45 ` Xiang, Haihao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79e19643e36fe981f62ffe3e47b48b207893e9ee.camel@intel.com \
--to=haihao.xiang-at-intel.com@ffmpeg.org \
--cc=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git