From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 58BF6488FE for ; Thu, 20 Jun 2024 15:54:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5658468D840; Thu, 20 Jun 2024 18:54:03 +0300 (EEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C021168D7FF for ; Thu, 20 Jun 2024 18:53:56 +0300 (EEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1f9cd92b146so7118775ad.3 for ; Thu, 20 Jun 2024 08:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718898834; x=1719503634; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=6S0H38dG0zXLp39GKaajlDTOYiQbUTh5aZQAHTqdaR0=; b=Y9m9Ihheee0k9DBZQXld/sca7QtHr7b0TFmU4HZweybzJnmV0wqffjFrnVZfhI1D4B RV8A9MyTirHw6SjLOgiaPL8uHUdFIGKMNUPKYjRgaAwGhBxfjm5SOoaXalpW9wt08lF+ UU6DrB87iyNpHEeDTvJZT8hkwYHz7EEi9A7MeSwmJm0mVTC5QQq/QJiK6ghGb49qJHZn qpQOW190Ab0b54eDmjhVWllbjKh9SvfOMfbgVE3T/pMdrPCpyFo2a8dYWV8FMGVx2a34 9AlEB8PUnoLyPp+4yJeCrUUow4lU+UmatGQ+WyNvaugs8+GcKefmw5Ns4fHLyGaZS3BO BZMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718898834; x=1719503634; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6S0H38dG0zXLp39GKaajlDTOYiQbUTh5aZQAHTqdaR0=; b=ufb4RQ0R7KhUatUx6Ra2tutBX70Xg5FFYUyff8WrtRRDmqwAhGvC4pI38vtoIHVPhg x82lxa2RlkKXE0hVzd+IFRw1fRZolyKZd5SW4EWHVbau8iNpblLHXTYoTgsl/svc/N/x bv9u9Yz08wFejKzz/ZeDdPDKoKTRqJ8/EZCWsXm5BsBr59IUN/NzvQ4Dj4FgE9nqR+/z KWoU5r3FIjZ/dbG91Hxjfcru0eGPw+QZ0ZQhniax5ip0/v1TNoE6D5dCqEAvOsn3iDWP PqApYqPNiMJvNkxMuSfPlFp1i/vUzIwsXqeZe4Yk/wQ4KWvCD1+Au0zD9tLOtGiyjUC0 59vg== X-Gm-Message-State: AOJu0YwaeEu2hlUWHlPj/A42ZdJzmAty4GbBK3J7KJOylmv7jh7PUK5j LfmSgvNA50BpBwjTjAUoGtlj43BAH7atwayg5mwbE4twoXAht6p7jRGMDA== X-Google-Smtp-Source: AGHT+IHjB0mtfFi0YxrYFW4vrmEXQ3FD3Pw5evy1w5uUEuGne/GJx03zRRKGhdWvexNTslpLWY9ACQ== X-Received: by 2002:a17:903:2347:b0:1f9:dc96:4017 with SMTP id d9443c01a7336-1f9dc964238mr11980395ad.26.1718898833547; Thu, 20 Jun 2024 08:53:53 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f1a1ebsm139039525ad.238.2024.06.20.08.53.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 08:53:52 -0700 (PDT) Message-ID: <79d14331-0ec3-43ed-8473-64e0f3fd3f2e@gmail.com> Date: Thu, 20 Jun 2024 12:54:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20240618190312.3848-1-jamrial@gmail.com> Content-Language: en-US In-Reply-To: <20240618190312.3848-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: always print all Stereo3D fields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/18/2024 4:03 PM, James Almer wrote: > ffprobe is meant to generate parseable output, and if a field is present, it > should be printed even if it has a default value. > > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 9 +++------ > tests/ref/fate/matroska-spherical-mono | 3 +++ > tests/ref/fate/matroska-spherical-mono-remux | 6 ++++++ > tests/ref/fate/matroska-stereo_mode | 12 ++++++++++++ > tests/ref/fate/matroska-vp8-alpha-remux | 3 +++ > 5 files changed, 27 insertions(+), 6 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index a814cb5ade..d7ba980ff9 100644 > --- a/fftools/ffprobe.c > +++ b/fftools/ffprobe.c > @@ -2546,12 +2546,9 @@ static void print_pkt_side_data(WriterContext *w, > print_int("inverted", !!(stereo->flags & AV_STEREO3D_FLAG_INVERT)); > print_str("view", av_stereo3d_view_name(stereo->view)); > print_str("primary_eye", av_stereo3d_primary_eye_name(stereo->primary_eye)); > - if (stereo->baseline) > - print_int("baseline", stereo->baseline); > - if (stereo->horizontal_disparity_adjustment.num && stereo->horizontal_disparity_adjustment.den) > - print_q("horizontal_disparity_adjustment", stereo->horizontal_disparity_adjustment, '/'); > - if (stereo->horizontal_field_of_view) > - print_int("horizontal_field_of_view", stereo->horizontal_field_of_view); > + print_int("baseline", stereo->baseline); > + print_q("horizontal_disparity_adjustment", stereo->horizontal_disparity_adjustment, '/'); > + print_int("horizontal_field_of_view", stereo->horizontal_field_of_view); > } else if (sd->type == AV_PKT_DATA_SPHERICAL) { > const AVSphericalMapping *spherical = (AVSphericalMapping *)sd->data; > print_str("projection", av_spherical_projection_name(spherical->projection)); > diff --git a/tests/ref/fate/matroska-spherical-mono b/tests/ref/fate/matroska-spherical-mono > index 08b94e455b..c52ca8e7ee 100644 > --- a/tests/ref/fate/matroska-spherical-mono > +++ b/tests/ref/fate/matroska-spherical-mono > @@ -5,6 +5,9 @@ type=2D > inverted=0 > view=packed > primary_eye=none > +baseline=0 > +horizontal_disparity_adjustment=0/0 > +horizontal_field_of_view=0 > [/SIDE_DATA] > [SIDE_DATA] > side_data_type=Spherical Mapping > diff --git a/tests/ref/fate/matroska-spherical-mono-remux b/tests/ref/fate/matroska-spherical-mono-remux > index 0ca77c8074..10b92d5f2e 100644 > --- a/tests/ref/fate/matroska-spherical-mono-remux > +++ b/tests/ref/fate/matroska-spherical-mono-remux > @@ -29,6 +29,9 @@ type=2D > inverted=0 > view=packed > primary_eye=none > +baseline=0 > +horizontal_disparity_adjustment=0/0 > +horizontal_field_of_view=0 > [/SIDE_DATA] > [SIDE_DATA] > side_data_type=Spherical Mapping > @@ -55,6 +58,9 @@ type=2D > inverted=0 > view=packed > primary_eye=none > +baseline=0 > +horizontal_disparity_adjustment=0/0 > +horizontal_field_of_view=0 > [/SIDE_DATA] > [SIDE_DATA] > side_data_type=Spherical Mapping > diff --git a/tests/ref/fate/matroska-stereo_mode b/tests/ref/fate/matroska-stereo_mode > index 13bce13cb8..a1aab1e38e 100644 > --- a/tests/ref/fate/matroska-stereo_mode > +++ b/tests/ref/fate/matroska-stereo_mode > @@ -134,6 +134,9 @@ type=side by side > inverted=0 > view=packed > primary_eye=none > +baseline=0 > +horizontal_disparity_adjustment=0/0 > +horizontal_field_of_view=0 > [/SIDE_DATA] > [/STREAM] > [STREAM] > @@ -151,6 +154,9 @@ type=top and bottom > inverted=1 > view=packed > primary_eye=none > +baseline=0 > +horizontal_disparity_adjustment=0/0 > +horizontal_field_of_view=0 > [/SIDE_DATA] > [/STREAM] > [STREAM] > @@ -166,6 +172,9 @@ type=interleaved lines > inverted=1 > view=packed > primary_eye=none > +baseline=0 > +horizontal_disparity_adjustment=0/0 > +horizontal_field_of_view=0 > [/SIDE_DATA] > [/STREAM] > [STREAM] > @@ -182,6 +191,9 @@ type=interleaved columns > inverted=1 > view=packed > primary_eye=none > +baseline=0 > +horizontal_disparity_adjustment=0/0 > +horizontal_field_of_view=0 > [/SIDE_DATA] > [/STREAM] > [STREAM] > diff --git a/tests/ref/fate/matroska-vp8-alpha-remux b/tests/ref/fate/matroska-vp8-alpha-remux > index e54304cafd..ea8a089cec 100644 > --- a/tests/ref/fate/matroska-vp8-alpha-remux > +++ b/tests/ref/fate/matroska-vp8-alpha-remux > @@ -37,5 +37,8 @@ type=2D > inverted=0 > view=packed > primary_eye=none > +baseline=0 > +horizontal_disparity_adjustment=0/0 > +horizontal_field_of_view=0 > [/SIDE_DATA] > [/STREAM] Will apply soon if nobody objects. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".