From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Aman Karmani <aman@tmm1.net>
Subject: Re: [FFmpeg-devel] [PATCH] avutil: use getauxval on linux/android for CPU capabilities
Date: Sat, 5 Feb 2022 00:20:44 +0200 (EET)
Message-ID: <799ffb65-5fea-ee22-5e5-7a71623d9e7@martin.st> (raw)
In-Reply-To: <20220204201621.20125-1-ffmpeg@tmm1.net>
On Fri, 4 Feb 2022, Aman Karmani wrote:
> From: Aman Karmani <aman@tmm1.net>
>
> fixes #6578
>
> Signed-off-by: Aman Karmani <aman@tmm1.net>
> ---
> libavutil/arm/cpu.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
It would be good if the commit message actually explained the upsides to
doing this.
It's also important to point out that this function didn't use to exist in
all Android versions (hence the /proc/cpuinfo parsing). The point when the
function appeared (Android 4.4, API 20, according to the referenced trac
issue) is kinda far in the past today, but I'm not sure if strictly all
users of the library have stopped supporting older versions still - at
least for some use cases I've heard of recently, Android 4.1 was still
supported.
If coupled with a configure check for the function, so that users
explicitly targeting an older version that lack it wouldn't get it, I
guess this could be more easily acceptable.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-04 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 20:16 Aman Karmani
2022-02-04 22:20 ` Martin Storsjö [this message]
2022-02-05 6:25 ` Aman Karmani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=799ffb65-5fea-ee22-5e5-7a71623d9e7@martin.st \
--to=martin@martin.st \
--cc=aman@tmm1.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git