From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 59E1C41059 for ; Sun, 2 Jan 2022 23:42:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C68268B0EE; Mon, 3 Jan 2022 01:42:02 +0200 (EET) Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1D414680157 for ; Mon, 3 Jan 2022 01:41:56 +0200 (EET) Received: by mail-qk1-f169.google.com with SMTP id b85so29836099qkc.1 for ; Sun, 02 Jan 2022 15:41:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=xmRhtro1oEmW/WLwsHhjpJfn9NwZnOYhv9o6VF75wug=; b=GCUnAGRwgIKVx2GElC0mmF9gPTrH855vR+zX+duIUa2+YS+99JBkJwy5xcohmGqdcl JigpnVllLUTdgPIUmPfjFAlwzApMXObjkqtkuB33RT4Nelh/QkYc7rVVQPF36Bnk+jTZ zoxd31g0ZUjvgBLmswizku5TCXUhrkvm7Zxspzlxy88dqHwKlmosar9HbWQoqI3hge5+ 1yhXhO2tehTbKdh6um01bQ4UMEL5BWGL3uZIwsPg7d+EQEDziQLkuZ4xDWUnCCxHla/S ACZNbHUNT9XM8KKEEh3gWNdlr/nRGIaNg7lXovPjcQNIaAoqUN1cJh/dQeQ/I0BaLKFT UsaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=xmRhtro1oEmW/WLwsHhjpJfn9NwZnOYhv9o6VF75wug=; b=zkQarJuFF+yq4evyz47RrwCoQW+CK1lO+UaMTVbsl/ZX/Zn5UYImN4u4w5Fy3BmsnJ TiMyf4e5MaFE0TfEq+ctkr6mErofEriAqU5tXKyTwWhQAu84t8sT1qjNg56Bqx56oPjG 4wTYJUsRSMbFohNlmp0suDaOuwUm2xZS9w47J4I5LwWRIc+z85gm6Q9UizODGTgL1lV0 vzQxVEitDocvEw1IrAPO7VpNCAUbKsc4VdMLp2jRYqvc4sfjH+dCVuxEUOjQStXjKygS 71YFex9chhmGhuPNw3eRkawVNyT1VIOrzubDqQKdix35+GKW525u1N0R/4H3yx10Z9wU d77A== X-Gm-Message-State: AOAM533nRIGK84quBwwhJdnQeuusm94RvQCatWM80mfToFI5OeGavfV6 1/PfM6KYPmpAgWQhPQdP1NAEDnJ29nk= X-Google-Smtp-Source: ABdhPJzzMJhlu2HmnbenFI4DlJb3wf4VXcmCR5T5Spp5adYXZo86U1WU4w+y2m5Bs+ZnNHNL4Iq5Bw== X-Received: by 2002:a05:620a:4450:: with SMTP id w16mr30804860qkp.26.1641166914523; Sun, 02 Jan 2022 15:41:54 -0800 (PST) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id g21sm29664447qtb.62.2022.01.02.15.41.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Jan 2022 15:41:54 -0800 (PST) Message-ID: <78e03ee7-afb9-d599-f2eb-c0b0ab627859@gmail.com> Date: Sun, 2 Jan 2022 20:41:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220102231628.5306-1-pal@sandflow.com> <67fe5a3e-1764-a6b0-8e31-26affa5ae5e9@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/imf: add IMF CPL with repeated resources to FATE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/2/2022 8:38 PM, Pierre-Anthony Lemieux wrote: > On Sun, Jan 2, 2022 at 3:28 PM James Almer wrote: >> >> >> >> On 1/2/2022 8:16 PM, pal@sandflow.com wrote: >>> From: Pierre-Anthony Lemieux >>> >>> Signed-off-by: Pierre-Anthony Lemieux >>> --- >>> >>> Notes: >>> The `fate-imf-cpl-with-repeat` target requires following files (<256 kB) >>> to placed under $(TARGET_SAMPLES)/imf/countdown/: >>> http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/ASSETMAP.xml >>> http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml >>> http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/PKL_4671220f-c87a-4660-bf2a-6ef848791a2c.xml >>> http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/frame-counter.mxf >>> >>> tests/Makefile | 1 + >>> tests/fate/imf.mak | 12 ++++++++ >>> tests/ref/fate/imf-cpl-with-repeat | 46 ++++++++++++++++++++++++++++++ >>> 3 files changed, 59 insertions(+) >>> create mode 100644 tests/fate/imf.mak >>> create mode 100644 tests/ref/fate/imf-cpl-with-repeat >>> >>> diff --git a/tests/Makefile b/tests/Makefile >>> index 87807ed31f..c4c31ae871 100644 >>> --- a/tests/Makefile >>> +++ b/tests/Makefile >>> @@ -153,6 +153,7 @@ include $(SRC_PATH)/tests/fate/hlsenc.mak >>> include $(SRC_PATH)/tests/fate/hw.mak >>> include $(SRC_PATH)/tests/fate/id3v2.mak >>> include $(SRC_PATH)/tests/fate/image.mak >>> +include $(SRC_PATH)/tests/fate/imf.mak >>> include $(SRC_PATH)/tests/fate/indeo.mak >>> include $(SRC_PATH)/tests/fate/libavcodec.mak >>> include $(SRC_PATH)/tests/fate/libavdevice.mak >>> diff --git a/tests/fate/imf.mak b/tests/fate/imf.mak >>> new file mode 100644 >>> index 0000000000..c9490d665b >>> --- /dev/null >>> +++ b/tests/fate/imf.mak >>> @@ -0,0 +1,12 @@ >>> +FATE_IMF += fate-imf-cpl-with-repeat >>> +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml >>> +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/ASSETMAP.xml >>> +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/frame-counter.mxf >>> +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/PKL_4671220f-c87a-4660-bf2a-6ef848791a2c.xml >> >> No need for these four lines. They wrongly make the build system assume >> it needs to create these files if they are not available. >> >> Simply by adding the test to the FATE_SAMPLES_AVCONV list like you're >> doing below will make sure it's not run unless a samples directory was >> provided. >> >>> +fate-imf-cpl-with-repeat: CMD = framecrc -i $(TARGET_SAMPLES)/imf/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml -c:v copy >>> + >>> +FATE_IMF-$(CONFIG_IMF_DEMUXER) += $(FATE_IMF) >> >> This test also needs the mxf demuxer, right? Should instead be >> >> $(call ALLYES, IMF_DEMUXER MXF_DEMUXER) if so. >> >>> + >>> +FATE_SAMPLES_AVCONV += $(FATE_IMF-yes) >>> + >>> +fate-imf: $(FATE_IMF-yes) >> >> You can do >> >> FATE_SAMPLES_AVCONV-$(call ALLYES, IMF_DEMUXER MXF_DEMUXER) += $(FATE_IMF) >> >> fate-imf: $(FATE_IMF) >> >> And not bother adding a FATE_IMF-yes variable. > > ... so basically: > > ``` > FATE_IMF += fate-imf-cpl-with-repeat > fate-imf-cpl-with-repeat: CMD = framecrc -i > $(TARGET_SAMPLES)/imf/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml > -c:v copy > FATE_SAMPLES_AVCONV-$(call ALLYES, IMF_DEMUXER MXF_DEMUXER) += $(FATE_IMF) > fate-imf: $(FATE_IMF) > ``` Yes. > >> >>> diff --git a/tests/ref/fate/imf-cpl-with-repeat b/tests/ref/fate/imf-cpl-with-repeat >>> new file mode 100644 >>> index 0000000000..38092d542c >>> --- /dev/null >>> +++ b/tests/ref/fate/imf-cpl-with-repeat >>> @@ -0,0 +1,46 @@ >>> +#tb 0: 1/24 >>> +#media_type 0: video >>> +#codec_id 0: jpeg2000 >>> +#dimensions 0: 1920x1080 >>> +#sar 0: 0/1 >>> +0, 0, 0, 1, 5034, 0x29a972c1 >>> +0, 1, 1, 1, 7214, 0x704fb452 >>> +0, 2, 2, 1, 8496, 0xee9d2692 >>> +0, 3, 3, 1, 4917, 0xd35c1a2f >>> +0, 4, 4, 1, 8803, 0xdc01ad91 >>> +0, 5, 5, 1, 8426, 0xacc4413a >>> +0, 6, 6, 1, 9626, 0x46865f1e >>> +0, 7, 7, 1, 7409, 0xa21efc69 >>> +0, 8, 8, 1, 7409, 0xa21efc69 >>> +0, 9, 9, 1, 7409, 0xa21efc69 >>> +0, 10, 10, 1, 7409, 0xa21efc69 >>> +0, 11, 11, 1, 7409, 0xa21efc69 >>> +0, 12, 12, 1, 7409, 0xa21efc69 >>> +0, 13, 13, 1, 7409, 0xa21efc69 >>> +0, 14, 14, 1, 7409, 0xa21efc69 >>> +0, 15, 15, 1, 7409, 0xa21efc69 >>> +0, 16, 16, 1, 7409, 0xa21efc69 >>> +0, 17, 17, 1, 7409, 0xa21efc69 >>> +0, 18, 18, 1, 7409, 0xa21efc69 >>> +0, 19, 19, 1, 7409, 0xa21efc69 >>> +0, 20, 20, 1, 7409, 0xa21efc69 >>> +0, 21, 21, 1, 7409, 0xa21efc69 >>> +0, 22, 22, 1, 7409, 0xa21efc69 >>> +0, 23, 23, 1, 7409, 0xa21efc69 >>> +0, 24, 24, 1, 7409, 0xa21efc69 >>> +0, 25, 25, 1, 7409, 0xa21efc69 >>> +0, 26, 26, 1, 7409, 0xa21efc69 >>> +0, 27, 27, 1, 7409, 0xa21efc69 >>> +0, 28, 28, 1, 7409, 0xa21efc69 >>> +0, 29, 29, 1, 7409, 0xa21efc69 >>> +0, 30, 30, 1, 7409, 0xa21efc69 >>> +0, 30, 31, 1, 8426, 0xacc4413a >>> +0, 30, 32, 1, 9626, 0x46865f1e >>> +0, 30, 33, 1, 5412, 0xf4884a91 >>> +0, 30, 34, 1, 9129, 0xbdb77fb3 >>> +0, 30, 35, 1, 10009, 0xac8a3ec5 >>> +0, 30, 36, 1, 7204, 0x4e239746 >>> +0, 30, 37, 1, 9413, 0x27620541 >>> +0, 30, 38, 1, 10725, 0x2feb9589 >>> +0, 30, 39, 1, 7101, 0x62159f85 >>> +0, 30, 40, 1, 10984, 0xa2eb2e49 >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".