From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000dec: remove ST=3 case
Date: Mon, 13 May 2024 10:35:44 +0200
Message-ID: <78cce1dcbc1f6a5f1dd0799a079c89adf8ae5944.camel@haerdin.se> (raw)
In-Reply-To: <20240510140705.443047-2-michael@niedermayer.cc>
fre 2024-05-10 klockan 16:07 +0200 skrev Michael Niedermayer:
> Fixes: CID1460979 Logically dead code
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/jpeg2000dec.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c
> index 28bf6be2fef..135537b52fb 100644
> --- a/libavcodec/jpeg2000dec.c
> +++ b/libavcodec/jpeg2000dec.c
> @@ -835,9 +835,6 @@ static int get_tlm(Jpeg2000DecoderContext *s, int
> n)
> case 2:
> bytestream2_get_be16(&s->g);
> break;
> - case 3:
> - bytestream2_get_be32(&s->g);
> - break;
Double-checked T.800 table A.34 and indeed ST == 3 is invalid (which is
also checked just above). So looks OK.
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-13 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 14:07 [FFmpeg-devel] [PATCH 1/3] avcodec/ilbcdec: Remove dead code Michael Niedermayer
2024-05-10 14:07 ` [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000dec: remove ST=3 case Michael Niedermayer
2024-05-13 8:35 ` Tomas Härdin [this message]
2024-05-13 21:48 ` Michael Niedermayer
2024-05-13 8:51 ` Tomas Härdin
2024-05-13 8:59 ` Tomas Härdin
2024-05-10 14:07 ` [FFmpeg-devel] [PATCH 3/3] avcodec/libx264: Check init_get_bits8() return code Michael Niedermayer
2024-06-07 18:53 ` [FFmpeg-devel] [PATCH 1/3] avcodec/ilbcdec: Remove dead code Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78cce1dcbc1f6a5f1dd0799a079c89adf8ae5944.camel@haerdin.se \
--to=git@haerdin.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git