Re: [FFmpeg-devel] [PATCH v3] libavcodec/dvbsubenc.c: add a disable_2bpp option to work around some decoders.

[Ronan Waide <waider@waider.ie>]

> On 1 Mar 2025, at 15:00, Soft Works <softworkz-at-hotmail.com@ffmpeg.org> wrote:
> 
> 
> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ronan
>> Waide
>> Sent: Samstag, 1. März 2025 15:30
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH v3] libavcodec/dvbsubenc.c: add a
>> disable_2bpp option to work around some decoders.
>> 
>>> On 1 Mar 2025, at 14:10, Ronan Waide <waider@waider.ie> wrote:
>>> 
>>> (changes from previous attempt: fixed an error in the docfile and made
>> sure I'm diffing against origin/master)
>>> 
>>> As noted in the code in several places, some DVB subtitle decoders
>>> don't handle 2bpp color. This patch adds a disable_2bpp option which
>>> disables the 2bpp format; subtitles which would use 2bpp will be
>> bumped
>>> up to 4bpp.
>>> 
>>> Signed-off-by: Ronan Waide <waider@waider.ie>
>>> ---
>>> doc/encoders.texi      | 27 ++++++++++++++
>>> libavcodec/dvbsubenc.c | 85 +++++++++++++++++++++++++++++++++---------
>>> 2 files changed, 95 insertions(+), 17 deletions(-)
>>> 
> 
> 
>> 
>> This failed again, and I see the problem - I'm diffing against
>> https://github.com/FFmpeg/FFmpeg.git rather than
>> https://git.ffmpeg.org/ffmpeg.git. Apologies for the confusion on my
>> part. Fixed fix of a fix incoming...
> 
> Both repos are in sync. Git says your patch is corrupted at line 11, but no matter from where I start counting, it doesn't lead to anything that looks suspicious.
> 
> You can also make a PR to this GitHub repo: https://github.com/ffstaging/FFmpeg and let it send the patch to the ML automatically.

I think I've identified the problem - I'm trying to use the `git format-patch` trick to generate a .eml file and then use Apple Mail's "Send Again" feature to send it, but it looks like some part of that process is corrupting the patch by removing at least some leading whitespace. I'll see if I can fix this without sending more emails to the list, and if I can't fix it (locally) I'll use the GitHub approach.

Thanks for your feedback!

Cheers,
Waider.
-- 
Ronan Waide
waider@waider.ie




_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".