* [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning
@ 2023-02-25 15:26 Jun Zhao
2023-02-25 15:26 ` [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: initialize the 'o' to silence the warning Jun Zhao
2023-02-25 17:48 ` [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning Thilo Borgmann
0 siblings, 2 replies; 6+ messages in thread
From: Jun Zhao @ 2023-02-25 15:26 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Jun Zhao
From: Jun Zhao <barryjzhao@tencent.com>
suppress OpenGL deprecation warning.
Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
libavfilter/vf_coreimage.m | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m
index b1959861de..17b2cde6fe 100644
--- a/libavfilter/vf_coreimage.m
+++ b/libavfilter/vf_coreimage.m
@@ -22,7 +22,8 @@
* @file
* Video processing based on Apple's CoreImage API
*/
-
+#define GL_SILENCE_DEPRECATION
+#define CI_SILENCE_GL_DEPRECATION
#import <CoreImage/CoreImage.h>
#import <AppKit/AppKit.h>
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: initialize the 'o' to silence the warning
2023-02-25 15:26 [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning Jun Zhao
@ 2023-02-25 15:26 ` Jun Zhao
2023-02-25 17:49 ` Thilo Borgmann
2023-02-25 17:48 ` [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning Thilo Borgmann
1 sibling, 1 reply; 6+ messages in thread
From: Jun Zhao @ 2023-02-25 15:26 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Jun Zhao
From: Jun Zhao <barryjzhao@tencent.com>
silence the warning: variable 'o' is used uninitialized whenever
'&&' condition is false
Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
fftools/ffmpeg_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index 1f5bbf6c4d..3504a3cc0a 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -362,7 +362,7 @@ fail:
static int filter_opt_apply(AVFilterContext *f, const char *key, const char *val)
{
- const AVOption *o;
+ const AVOption *o = NULL;
int ret;
ret = av_opt_set(f, key, val, AV_OPT_SEARCH_CHILDREN);
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning
2023-02-25 15:26 [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning Jun Zhao
2023-02-25 15:26 ` [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: initialize the 'o' to silence the warning Jun Zhao
@ 2023-02-25 17:48 ` Thilo Borgmann
2023-02-26 1:42 ` mypopy
1 sibling, 1 reply; 6+ messages in thread
From: Thilo Borgmann @ 2023-02-25 17:48 UTC (permalink / raw)
To: ffmpeg-devel
Am 25.02.23 um 16:26 schrieb Jun Zhao:
> From: Jun Zhao <barryjzhao@tencent.com>
>
> suppress OpenGL deprecation warning.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
> libavfilter/vf_coreimage.m | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m
> index b1959861de..17b2cde6fe 100644
> --- a/libavfilter/vf_coreimage.m
> +++ b/libavfilter/vf_coreimage.m
> @@ -22,7 +22,8 @@
> * @file
> * Video processing based on Apple's CoreImage API
> */
> -
> +#define GL_SILENCE_DEPRECATION
> +#define CI_SILENCE_GL_DEPRECATION
> #import <CoreImage/CoreImage.h>
> #import <AppKit/AppKit.h>
Why do you want to silence a framework warning?
-Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: initialize the 'o' to silence the warning
2023-02-25 15:26 ` [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: initialize the 'o' to silence the warning Jun Zhao
@ 2023-02-25 17:49 ` Thilo Borgmann
2023-10-09 21:01 ` [FFmpeg-devel] [6.0] Segmentation fault in graph_parse() (was: [PATCH 2/2] fftools/ffmpeg_filter: initialize the) " Dominik 'Rathann' Mierzejewski
0 siblings, 1 reply; 6+ messages in thread
From: Thilo Borgmann @ 2023-02-25 17:49 UTC (permalink / raw)
To: ffmpeg-devel
Am 25.02.23 um 16:26 schrieb Jun Zhao:
> From: Jun Zhao <barryjzhao@tencent.com>
>
> silence the warning: variable 'o' is used uninitialized whenever
> '&&' condition is false
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
> fftools/ffmpeg_filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM.
-Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning
2023-02-25 17:48 ` [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning Thilo Borgmann
@ 2023-02-26 1:42 ` mypopy
0 siblings, 0 replies; 6+ messages in thread
From: mypopy @ 2023-02-26 1:42 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Sun, Feb 26, 2023 at 1:48 AM Thilo Borgmann <thilo.borgmann@mail.de> wrote:
>
> Am 25.02.23 um 16:26 schrieb Jun Zhao:
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > suppress OpenGL deprecation warning.
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> > libavfilter/vf_coreimage.m | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m
> > index b1959861de..17b2cde6fe 100644
> > --- a/libavfilter/vf_coreimage.m
> > +++ b/libavfilter/vf_coreimage.m
> > @@ -22,7 +22,8 @@
> > * @file
> > * Video processing based on Apple's CoreImage API
> > */
> > -
> > +#define GL_SILENCE_DEPRECATION
> > +#define CI_SILENCE_GL_DEPRECATION
> > #import <CoreImage/CoreImage.h>
> > #import <AppKit/AppKit.h>
>
> Why do you want to silence a framework warning?
>
Ok, will drop the fix
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [6.0] Segmentation fault in graph_parse() (was: [PATCH 2/2] fftools/ffmpeg_filter: initialize the) 'o' to silence the warning
2023-02-25 17:49 ` Thilo Borgmann
@ 2023-10-09 21:01 ` Dominik 'Rathann' Mierzejewski
0 siblings, 0 replies; 6+ messages in thread
From: Dominik 'Rathann' Mierzejewski @ 2023-10-09 21:01 UTC (permalink / raw)
To: ffmpeg-devel
On Saturday, 25 February 2023 at 18:49, Thilo Borgmann wrote:
> Am 25.02.23 um 16:26 schrieb Jun Zhao:
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > silence the warning: variable 'o' is used uninitialized whenever
> > '&&' condition is false
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> > fftools/ffmpeg_filter.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> LGTM.
Sorry to dig up an old thread, but this actually fixes a segmentation
fault when passing a non-existent filter option, so please make sure
it's back-ported to the next 6.0.x release.
To reproduce:
ffmpeg -y -f rawvideo -s 1x1 -i /dev/zero -vf palettegen=doesnt_exist=64 dummy.png
This was reported in RPM Fusion bugzilla:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6773
5.1.3 is not affected, only 6.0.
Regards,
Dominik
--
Fedora https://fedoraproject.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
-- from "Collected Sayings of Muad'Dib" by the Princess Irulan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-09 21:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-25 15:26 [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning Jun Zhao
2023-02-25 15:26 ` [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: initialize the 'o' to silence the warning Jun Zhao
2023-02-25 17:49 ` Thilo Borgmann
2023-10-09 21:01 ` [FFmpeg-devel] [6.0] Segmentation fault in graph_parse() (was: [PATCH 2/2] fftools/ffmpeg_filter: initialize the) " Dominik 'Rathann' Mierzejewski
2023-02-25 17:48 ` [FFmpeg-devel] [PATCH 1/2] lavfi/coreimage: suppress OpenGL deprecation warning Thilo Borgmann
2023-02-26 1:42 ` mypopy
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git