From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E1EF943BC6 for ; Fri, 22 Jul 2022 03:10:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EA9FA68B69E; Fri, 22 Jul 2022 06:10:30 +0300 (EEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EBCE068B2C8 for ; Fri, 22 Jul 2022 06:10:22 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658459428; x=1689995428; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=w/yoHKDVuIhY138VeIPIR2MsLu98XUKLlVY4V/zm70M=; b=C9Qt8tT+F97IvnOrihrwXjz+20/ALnz8+6PKDRJT7/wIe1D9DgcvGkL2 G1tXyrEFjQ5xbsTlwUr/b4W3Q+n42Ewt+48hcpu4slvyPQxNC5H5BsArP YuP4eTNBUns8t9MDaZz3W0saUUwII3ArIwOv4xfNJytZPg2rdnv6EJCle 5FgnS4abtmDKg513hqw7GmSskW9Qver5HQRcaab9XT1uXAcMGBdVM00kq rT5crFz++dQ+wPltbUJdP3stoKeOWiYGkaahQE8/6Gcn4dryzC/RbWOLp dL99KouljYrIX6N/Jtw1JB6HDjg0F69tmvYnqqYojWX5K8EPQXksfqHfH w==; X-IronPort-AV: E=McAfee;i="6400,9594,10415"; a="270260776" X-IronPort-AV: E=Sophos;i="5.93,184,1654585200"; d="scan'208";a="270260776" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2022 20:10:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,184,1654585200"; d="scan'208";a="595832997" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 21 Jul 2022 20:10:20 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 21 Jul 2022 20:10:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 21 Jul 2022 20:10:19 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 21 Jul 2022 20:10:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S1YbQaO/ztZQvYaOwZbq+aRpnHEfHx4jmS02xVOcecDCFBQEaYmSZQ+tSNTJ+VSV3rantc1gNbAbOyk2OZNY/xytDS89HfJzqZnQ4NJM7suVix/XfbO6ohtYI7xeJcobOHldJUwDlN4ZQqAlQR09IzhcLzE4+kPhRGJRqE8hGUEYOhNiBDK+vKfUnRDnaJ0m9jXy5LRhu/2fc9/eoXm1nS0znuxDRC3iMC1pWO7E/Ycp2zWCzfHYujLSMby3acLtlJxtoehN1lhQiPf1R1kJN8I06+z8nh45ctMetOZeBtLCJGVTnvsaB/4LdnC6eEsN1oy8JpPlMXxsNX8QMAKBbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w/yoHKDVuIhY138VeIPIR2MsLu98XUKLlVY4V/zm70M=; b=LXitltIAEU635fUBWnCamUbQ+Y8bRrPfp7K8Kv30DfS4Vk1UHDl0wH5WfHtSgrBwT/i10FXyjAoYCon+4rNQoWGh6UkwObqsga7CP4ddV+fxkBAEzAmq1wOOJ2faOWsd46sSHYuEuHPM30sDUbmBv5xFVamfbGX2fy8swD0o2uVjsZNZpPyQnvvzexnc257edhJVKwxoyuEZM9I4igrQY7xfvPjdiiC2HQBD5PlR2xYSppp+GbWF7Wm4kkp9loLvmy5sR72qgOmggHXCAedClosP8zXUzHiYLEEiEaPB2TJyFtwNCY7w79yva1/8QZvPKmcV/8R8DZuRKNx5STK4iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SA2PR11MB4810.namprd11.prod.outlook.com (2603:10b6:806:116::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Fri, 22 Jul 2022 03:10:17 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b%2]) with mapi id 15.20.5458.018; Fri, 22 Jul 2022 03:10:17 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v11 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL Thread-Index: AQHYnBRyK9TTXcoSUE+AIf2mjojMv62JZ8aAgABRMgA= Date: Fri, 22 Jul 2022 03:10:17 +0000 Message-ID: <77ace46df7f42250f61820ca9ddb7194a6178bc2.camel@intel.com> References: <20220720084006.5033-1-haihao.xiang@intel.com> <20220720084006.5033-11-haihao.xiang@intel.com> <8280f7b7-cf39-722a-c189-79af71c22c7c@jkqxz.net> In-Reply-To: <8280f7b7-cf39-722a-c189-79af71c22c7c@jkqxz.net> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 84ef95c3-b104-4b7b-3767-08da6b8fb44a x-ms-traffictypediagnostic: SA2PR11MB4810:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dYiPDWkvgh8rimopAGcTTJ72LT9au51Vy5jF5rwJn488Mn70ciblrB11o+Lp4Q+4H/M0qui1OxiizhOsFoMaDfS/pZK0qVDoiLKpuqHvgw2bb59h0L93sN0ImmdqspPskwl/AN4OmLqDpWiQrMVcs8IwdUaMrQc6N6k03dlK6IxQaUlqIlpvmXdVD2UFdurfcLEMitooaPg15IE477UcVNt70DqRoGLb7keaFuQN4SZ2R7OYYA7QaJeUnii4IMiHbx+TL7xmlStyWN5S1tUdkgfpTJPr93UNj6RMILJH6uYw5dHAE6KegSgnWYnDXi+xqeEk33wR8jq9yLspfn9MTTgZwAZIz977ol39LlcrIDOCdsZlMcXLSjK5HwZir6WMwC1Epb+YysTuafljU3+e726IuOofVuD0atZwd9MsznrV1IaDxyqKoXRi3MapIohYK59gmHJ1/DYCi1xly+jHSG4zq/GjWLWjbCEbvBGDrmxfuY+q93SH8CCILbtM1W0xY8taBgSfQ3s7fal3LY0rakb3DZxWPOyx6J/WT9+t1RPkGEZ5TJBiZ/G/rx8PsJDTosns8lI9PanYTnS1zMIPOcHw/4mkEZBAKDwWw/jvlAKsQ+MQHm1/6YVp2zVxMwMcacAoHJt/wGjBSHwV4nVtFzWqHuwORGRdqzvaLJYzuqGBjB3x3gx1aWZVpa8BkX6PuAInurdoqKFAJyDZGHozMXL3SMG0+pAOLLBBfGNDTCoJLn71+8cM5jMG4PaOwdNs5LcKPkfzz12s7jrEYaJH87SAZLtBFnkhQ7a70+TOlipRsNFHTtCzAncFX0MmIfRnZPhQnq5Wc4sIxXl8HVkNpdorAcnlEyyZ220KcZsXD+o= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(136003)(396003)(376002)(39860400002)(6506007)(41300700001)(186003)(53546011)(6486002)(71200400001)(478600001)(26005)(83380400001)(45080400002)(2616005)(966005)(6512007)(66446008)(76116006)(8676002)(38070700005)(8936002)(66946007)(36756003)(122000001)(64756008)(91956017)(66556008)(66476007)(5660300002)(316002)(6916009)(2906002)(82960400001)(19627235002)(38100700002)(86362001)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VG9XZktwSkZaVmk5R3lVSXBId3hIVjhFZFFDakhjZE11WC9NUmR4S2FSTnRB?= =?utf-8?B?R2Y2ZXN0OFF0TXdaKy8wWnZQdlBiOG5SMVRjcWJTb0Fod092RVN6MGdVTG45?= =?utf-8?B?eVpiNm84TmRLZzJsbWFlaTRBWHVsQ3RTV0Z1UUcwQTZ0dTA4aXdPeHo2VTI1?= =?utf-8?B?K2pLK0UwTVo3N01GSDMxZ3M5ZmlrZ1lpMG9oSXAxU2h1Zk5ueWpMdHQ4TVZI?= =?utf-8?B?aVJzdVBJd1BrL2tFdWtTTEpEclNiNDgvMkhvWVYxV1NaSm1kakJWQ3NPWHVh?= =?utf-8?B?RUFrdXNUcUZQZ0dYWXJ3MVZONm1RUExqLzlvK0J6dms3a0hrSUpzb0xlbUpJ?= =?utf-8?B?bjVpUUgraTlibVhOUm5DZ3hYK0FXM002OG5RSm5wdDJUMndSa001end6UjVp?= =?utf-8?B?VURjZjRoVmpDSVRMRzU2QTJ2TFh1R2doM3ZyQWwxSXp5SmxBcW5rMkJXYnBG?= =?utf-8?B?M1Ayd084WVM0OXNqWEtqUlFWdjFVeTFYRncvbHN1Nzg5b3ppbm5hZVExT25i?= =?utf-8?B?eVRZVDZUTlgzMEc3RXBtNnJ0T3dMZm5SN0tYQWJLYXFzOGpSczRKeWFKMmhW?= =?utf-8?B?RkFDUHJvWWNRK2Yvd3NmOHdkMUN6aENGQnExNjNCWHdoSW1GMHV4N252YXVM?= =?utf-8?B?T2U2b0V0QklWdUtodktMdGhRNnZCQmN3aWpTN3BkbzlXdmpvSElTSzFDUEI5?= =?utf-8?B?Zm9mdmxIdkN2VHU2NVhnazM4MzQ3SGZ6bkFodXF4SWRlVUM4aEdRRlRiKy9W?= =?utf-8?B?V204VWJnTVMvaHFvelNUZW5EUUxUSmF2WktkWTVybXNLZE1aTExBQVJSUW1Z?= =?utf-8?B?MWduM2UxMVNJaDZyRUN0MVRMM1pxMEZGUWpOZ01LZ3daM1UvNDl1akc3STFV?= =?utf-8?B?aE53ZWVVamhucWlBTFlQUW52SllwYURldmdWWTdoaWhtWmRDZ0NkOGQ0RHdT?= =?utf-8?B?YzhIaFcyaFFwZ04rdFdWdXZqbWo3T2ZKaUtqSUdIWFZEMXUxYUZ5Qkp6dlBp?= =?utf-8?B?WjZyRC9oRHhsMTA2dG56NEJnbS9idDNtTThJcTFWMGh3QkpUZWp3NjdieW5l?= =?utf-8?B?QWZQTkxjWkVqR2V1eUp6eVoveTNFZ1J0VmVBdk53Qk9XRzREYzNRRGJyekpr?= =?utf-8?B?VjF2eUNqMS95Q3pXUUsrVk1zZFJXS2Q4NEJ1MkIzNU5jZFFUSkEvRmllU0w3?= =?utf-8?B?SHBuS1VZR1huU3EzVWlqYlQ1TFNDVDRhS2VIWDh1MU8vWEUvdUtxRE43bGpJ?= =?utf-8?B?aHltV3pUTkhSS2xJblc3MzVKcXRreWxIL2gzUlJKZURPNVAxbTZCc1E4MTNY?= =?utf-8?B?VUdjK2JHc2V3MkN6K3gwMFhYd1pLQktQMTF6WTNod0RldEhzZmk1dWNVSXZv?= =?utf-8?B?dHM4TnNTSUZCbUo3TVZTZG93N2hWTCtqcGRwYWNJRm5kYWJySWlHMm1FSk01?= =?utf-8?B?U21JZEEvWCtvbjdXZGRYeVlkVlBhUS9pOVgrSGtOWnBNV3gxODZiVVpjZ1RK?= =?utf-8?B?WC9KMS9tZmY3dExFVGYrZ0N3MW1nU0poNnp3QldXRm1xbHNpb1pNMGlVOVdF?= =?utf-8?B?azFoQ25pbXVMMmoxSzE3WjFWaEZGSkcrK1JIMDFJQUVkQkV3Q3pqSGY4UC9r?= =?utf-8?B?UkdTU1hmZ3lNZTZKcExJQzFsTUQwWXpRVjNKc1ZOVWNJMXBCWEd4bU1ycEZB?= =?utf-8?B?OEVlVE1ZT2kzVEI5NlJma1BRNmpRdjhsNk1STFMzQUJObVhHRzB5YmxDa01y?= =?utf-8?B?Q2V1aWRuK2N1N25Na01KUkFsM1VDZ3hOWCthOHQwNzF4NmNUbEpuNUtYMDFW?= =?utf-8?B?VkdjUnFTSlRZejNRemZuQyt6WnZaQmZhdXVBbHNrRUlOM05DbzhZaDNYUlZt?= =?utf-8?B?QVpEVmFSWisrbEpZcFN4ZGx4akdVSkJSZExFU2g3VC9aa0EzN0NSZ20yVmRt?= =?utf-8?B?U0VLUzNYODBWanhOWGZ2UHc0ZERKb296SVdJTUVRZ3dvT0ZXVmxUTkhRZTNs?= =?utf-8?B?ZVBxdW02Zkdvako5a3lzZUxhMVNSMWYwb1VSdFlHSW96bVRGbjE1SE9OSlRL?= =?utf-8?B?eVJtekpVVDBING90U2QvbXFIRDZOS2Rlc0owSmwrd2U1OUdHR0JHcXBmN0lk?= =?utf-8?B?UW13ekZuQmlrZHpLZko0YldJRThPMnhrWUE5bmJUM1hIeUxaRnkvQnp6OEp1?= =?utf-8?B?TFE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84ef95c3-b104-4b7b-3767-08da6b8fb44a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2022 03:10:17.5136 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WyUS0E3sZmCgIDegNsLLpR127m83IFfaI8RLrf6qdhQfRSma6z0w/TWmZf63e7Cwvxyws+WQZwpO3XXCtfeN8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4810 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v11 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-07-21 at 23:19 +0100, Mark Thompson wrote: > On 20/07/2022 09:40, Xiang, Haihao wrote: > > From: Haihao Xiang > > > > In oneVPL, MFXLoad() and MFXCreateSession() are required to create a > > workable mfx session[1] > > > > Add config filters for D3D9/D3D11 session (galinart) > > > > The default device is changed to d3d11va for oneVPL when both d3d11va > > and dxva2 are enabled on Microsoft Windows > > > > This is in preparation for oneVPL support > > > > [1] > > https://spec.oneapi.io/versions/latest/elements/oneVPL/source/programming_guide/VPL_prg_session.html#onevpl-dispatcher > > > > Co-authored-by: galinart > > Signed-off-by: galinart > > Signed-off-by: Haihao Xiang > > --- > > libavutil/hwcontext_qsv.c | 531 +++++++++++++++++++++++++++++++++++--- > > 1 file changed, 493 insertions(+), 38 deletions(-) > > > > diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c > > index 21a2a805f8..90b7988dec 100644 > > --- a/libavutil/hwcontext_qsv.c > > +++ b/libavutil/hwcontext_qsv.c > > ... > > + > > +static int qsv_va_update_config(void *ctx, mfxHDL handle, mfxConfig cfg) > > +{ > > +#if CONFIG_VAAPI > > +#if VA_CHECK_VERSION(1, 5, 0) > > +#define LOCAL_VADISPLAYPCIID VADisplayPCIID > > +#else > > +#define LOCAL_VADISPLAYPCIID 21 > > +#endif > > This seems to be handling the case where you built the driver against a newer > version of libva containing the field but then downgraded it before building > ffmpeg? Who are you expecting to do that? This should be removed. I was considering the driver and ffmpeg were built in different environments. BTW the new va-api version should be 1.15, I will fix it in the next version. > > > + mfxStatus sts; > > + VADisplay dpy = handle; > > + VAStatus vas; > > + VADisplayAttribute attr = { > > + .type = LOCAL_VADISPLAYPCIID > > + }; > > + mfxVariant impl_value; > > + > > + vas = vaGetDisplayAttributes(dpy, &attr, 1); > > + if (vas == VA_STATUS_SUCCESS && attr.flags != > > VA_DISPLAY_ATTRIB_NOT_SUPPORTED) { > > + impl_value.Type = MFX_VARIANT_TYPE_U16; > > + impl_value.Data.U16 = (attr.value & 0xFFFF); > > + sts = MFXSetConfigFilterProperty(cfg, > > + (const mfxU8 > > *)"mfxExtendedDeviceId.DeviceID", impl_value); > > + if (sts != MFX_ERR_NONE) { > > + av_log(ctx, AV_LOG_ERROR, "Error adding a MFX configuration" > > + "DeviceID property: %d.\n", sts); > > + goto fail; > > + } > > + } else { > > + av_log(ctx, AV_LOG_ERROR, "Failed to get device id from the driver. > > Please " > > + "consider to upgrade the driver to support VA-API 1.5.0. > > \n"); > > + goto fail; > > + } > > The use of the PCI ID doesn't make sense to me here? > > A PCI ID tells you the type of the device, not which device it was - given > that the normal use-case for multiple devices in servers generally has lots of > idential ones this does not seem helpful. > MFXVideoCORE_SetHandle() is still needed after creating a session. here use the pci id to choose an implementation which can support the given device. Thanks Haihao > > + > > + return 0; > > + > > +fail: > > +#endif > > + return AVERROR_UNKNOWN; > > +} > > + > > ... > > - Mark > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".