From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 70FAB43F64 for ; Wed, 19 Oct 2022 22:59:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0353A68BDA3; Thu, 20 Oct 2022 01:59:26 +0300 (EEST) Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9383D68BB6B for ; Thu, 20 Oct 2022 01:59:19 +0300 (EEST) Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-134072c15c1so22535156fac.2 for ; Wed, 19 Oct 2022 15:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Fbl7x5XzBDCBY+rM/3sM4wli1666+Oh2+kt8v25ZG2Y=; b=b2uuIvMrQw3Vn5QEWWx0jeukpVoERc3bQ+oQFsBRmQ5XfFHwYPfFWdra6sQEbfbC77 G0FTBi1GrAGRx/jFz86z8USHLTfCt9ZAWTzLRFerfHfZ78LzvAhsc2bNjg8puf++X2im yfHtoeuj1vGuM+oSsU6jvi5hZ+BdSOiK3E0E12x9Im/+MIe726nxgXt4kN/bzjbMm3s+ OmWEprEY3TWiUDGYfBgJ1nm74MmtF6CQDnyFToLz7yh37y4cUMeZovmd0CnkX6r6ADSL EsHuglRngXd7Utiq4ZCYdwZfh/E84iHkm8D47adDfqxKzWFf4z3NMiLisMS6U+FhkPwN 8BYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fbl7x5XzBDCBY+rM/3sM4wli1666+Oh2+kt8v25ZG2Y=; b=1Qd6maTkOXWnDwMajFeJedXSmaWWxUv7nb8+QzUEKA+poDHbt2ndrw5UiORB6ppBV6 0dbrtH3UxxVHwgj3QJ/If5o+1DcSrPrcew9MRol7GTB8Id8p6z0AJZuVv6PskbsEt5uz caNac1/vger4y3MPAWR/KdLwyPdS/c66Pbx9J8Ioa2dHUMnCeP20/CHA0oWFeVEfGU1R B7duibuiQdvLDjDWSEExkkI9Da56hGdMhZopCW1v8I5AZC0MbsXt++7nYoncC22ZD9E9 g91GX/jg5dG7/CvVGWYfX73yHd4FzY6l2KAe++8UmsbBWoPi4Qe+t/R/M/gwn+/VNqdc Banw== X-Gm-Message-State: ACrzQf32srIgM2mTNBWI4/Z5Gf2LJO5dY0jLiYyuG9qSTQVomhqFsYxk GpNDOrTuq4ZWRPabJwuCZrVgnCBFgEA= X-Google-Smtp-Source: AMsMyM41JWSlBPB3d4zV9KObhiSJlzGMt4z9hPhphVtnbUduEIgMQDNFYZUs4ysk533eaZgEx8W6PQ== X-Received: by 2002:a05:6870:5596:b0:12c:b873:9c33 with SMTP id n22-20020a056870559600b0012cb8739c33mr6540702oao.23.1666220357556; Wed, 19 Oct 2022 15:59:17 -0700 (PDT) Received: from [192.168.0.13] ([191.97.187.183]) by smtp.gmail.com with ESMTPSA id u24-20020a056830119800b006619dd066fbsm7540008otq.5.2022.10.19.15.59.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 15:59:17 -0700 (PDT) Message-ID: <775de53f-d3ba-5dd0-29ee-f97ef68e1a94@gmail.com> Date: Wed, 19 Oct 2022 19:59:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 To: ffmpeg-devel@ffmpeg.org References: <20221019224712.194658-1-ccom@randomderp.com> <20221019224712.194658-2-ccom@randomderp.com> Content-Language: en-US From: James Almer In-Reply-To: <20221019224712.194658-2-ccom@randomderp.com> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libsvtav1: replace vbv_bufsize with maximum_buffer_size_ms X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10/19/2022 7:47 PM, Christopher Degawa wrote: > From: Christopher Degawa > > svt-av1 v1.2.0 has deprecated vbv_bufsize in favor of using > - maximum_buffer_size_ms (--buf-sz) > - starting_buffer_level_ms (--buf-initial-sz) > - optimal_buffer_level_ms (--buf-optimal-sz) > > and vbv_bufsize has not been in use since svt-av1 v0.8.6 > > Signed-off-by: Christopher Degawa > --- > libavcodec/libsvtav1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > index 28da206cf8..74dad9892b 100644 > --- a/libavcodec/libsvtav1.c > +++ b/libavcodec/libsvtav1.c > @@ -179,7 +179,7 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param, > param->min_qp_allowed = avctx->qmin; > } > param->max_bit_rate = avctx->rc_max_rate; > - param->vbv_bufsize = avctx->rc_buffer_size; > + param->maximum_buffer_size_ms = avctx->rc_buffer_size * 1000 / avctx->bit_rate; 1000LL. The multiplication could overflow otherwise. > > if (svt_enc->crf > 0) { > param->qp = svt_enc->crf; > @@ -296,7 +296,7 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param, > avctx->bit_rate = param->rate_control_mode > 0 ? > param->target_bit_rate : 0; > avctx->rc_max_rate = param->max_bit_rate; > - avctx->rc_buffer_size = param->vbv_bufsize; > + avctx->rc_buffer_size = param->maximum_buffer_size_ms * avctx->bit_rate / 1000; > > if (avctx->bit_rate || avctx->rc_max_rate || avctx->rc_buffer_size) { > AVCPBProperties *cpb_props = ff_add_cpb_side_data(avctx); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".