From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CD5F74B68C for ; Fri, 12 Jul 2024 20:02:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 263F568DBD9; Fri, 12 Jul 2024 23:02:34 +0300 (EEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE38568D9AA for ; Fri, 12 Jul 2024 23:02:27 +0300 (EEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1fb0d7e4ee9so16646505ad.3 for ; Fri, 12 Jul 2024 13:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720814545; x=1721419345; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=wA2+bNvQPtdt0mqtKxMTjceM7/xYCCGu5jFarxRnKrc=; b=jnE2UgQOVFcHBTSFNw35ZHn1nYvlSt3QENYDaJo6dd7oOYXCpKx/vKtnlViXySACoy R4bn1b5YYOKbu7ylqKpe0UgeyFFllHHaL2nLQpLo8G1q4JtpON5jEV5FUhNGvyJkwnsM 0gkom+KBZLL6RtGakvvdJLDCt3aZ3/KfhG6Z/N6wtvSHQk7UspCVw772BZebrfqjBqW4 akjrU9iP/NRxidY17pI7JbfvC2lrGIY6vNGFmakB0ll87bsx/qMPMeWJM8BZoKWB1UCK 0iUgOMbCVRWiBJo4Se452v0p7TMkOq+lMWhfmLA7zlxz7j8aYrhqEytO7xgYugx4XF1Z AXyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720814545; x=1721419345; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wA2+bNvQPtdt0mqtKxMTjceM7/xYCCGu5jFarxRnKrc=; b=LZtteYjdcW9625tT7AZ2pR4xKL2I34ZXIJjgkM4S3OhN0MVIDpXKF+sAzvzAC7ZuKb 6yiCg/shCRG1fTN7wRuqjhbaJJbs7hhl0DDAtKCO7Zv9n2vb+y+31/Nhi1kb0prjMaRu LTqEFhf+pSSej+GYafI44FxZDHXzo+J1IthJvPhzR9BzBdeYfL1eAknizy7qP7hSUq1x eR8s3gqsdSHYHTa0gx6x5xgVdcexMeFUzAFA01gPRy+dIU2dWVO6F4gdDqb0V+3w7iXM OU4kzRsMQaXqvEA3Mo87xl5AuDZ3xY4AoytiTW9XmXJpTNQIeWH6nsF4cA0ceFCHRUn1 0W9g== X-Gm-Message-State: AOJu0YwY3/g0iduDvSmpqustDHz57qz+ojkStC6kCwYjoWIrTaXTJt5h 5wXJDuBJ2ZQYZE9fZ1vtMrSG042RF4lO3eKCaYL6pj0QX8SGE5cEafL8mw== X-Google-Smtp-Source: AGHT+IH1l7z2VWdSMr1Z6mxb20NPMGbtviiG53y4VEUMI/UuKC02aOY5qYdmzoeRc1mjoXmqXXnt2A== X-Received: by 2002:a17:902:8305:b0:1fa:fc69:7a81 with SMTP id d9443c01a7336-1fbb6d54716mr80784775ad.29.1720814545283; Fri, 12 Jul 2024 13:02:25 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6a2bb31sm70873605ad.94.2024.07.12.13.02.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jul 2024 13:02:24 -0700 (PDT) Message-ID: <7713ff65-5195-4551-8caf-0cfc8a3c4bb5@gmail.com> Date: Fri, 12 Jul 2024 17:02:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240711133124.CB528411AF2@natalya.videolan.org> <20240712165302.GK1904408@pb2> <0d032833-ad0a-48ff-a1b8-3f74390a1d16@gmail.com> <20240712193444.GQ4991@pb2> Content-Language: en-US From: James Almer In-Reply-To: <20240712193444.GQ4991@pb2> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mov: export cropping values from clap boxes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/12/2024 4:34 PM, Michael Niedermayer wrote: > On Fri, Jul 12, 2024 at 01:57:43PM -0300, James Almer wrote: >> On 7/12/2024 1:53 PM, Michael Niedermayer wrote: >>> On Thu, Jul 11, 2024 at 01:31:23PM +0000, James Almer wrote: >>>> ffmpeg | branch: master | James Almer | Mon Jul 8 20:50:18 2024 -0300| [93be6b425ebeb6cf96faf502281a4f7a1ed5138c] | committer: James Almer >>>> >>>> avformat/mov: export cropping values from clap boxes >>>> >>>> Addresses part of ticket #7437. >>>> >>>> Signed-off-by: James Almer >>>> >>>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=93be6b425ebeb6cf96faf502281a4f7a1ed5138c >>>> --- >>>> >>>> libavformat/mov.c | 74 +++++++++++++++++++++++++++++++++ >>>> tests/ref/fate/aic | 32 +++++++------- >>>> tests/ref/fate/prores-transparency | 4 +- >>>> tests/ref/fate/prores-transparency_skip | 4 +- >>>> 4 files changed, 94 insertions(+), 20 deletions(-) >>> >>> breaks: >>> >>> ./ffmpeg_g -i ~/tickets/1439/in.mov -t 1 -timecode 09:59:30:06 -an -c:v dvvideo -pix_fmt yuv420p -an -y -bitexact /tmp/ile1439.mov >>> >>> [dvvideo @ 0x7fd2d8011980] Found no DV profile for 702x576 yuv420p video. Valid DV profiles are: >> >> The input file has a clap box that defines cropping, which began being >> applied by default after the aforementioned commit. > > I did realize that, i reported that anyway as it was a interresting failure > > >> You should add >> "-apply_cropping 0" to disable all cropping or "-apply_cropping 2" to only >> apply codec level cropping. > > thx ill use that All values for apply_cropping are documented in ffmpeg.texi. It used to be a bool but now it also accepts 2 and 3 (And const aliases for all four values). I wouldn't use 0 in general, before or after the above commit, as codec level cropping is almost always desirable (1080p h264 samples would decode as 1088 lines otherwise, for example), so IMO use 2/codec to disable container cropping and only leave codec cropping on for this kind of scenario. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".