From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8D706466AC for ; Mon, 31 Jul 2023 00:49:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A6BA168C557; Mon, 31 Jul 2023 03:49:54 +0300 (EEST) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3C79568C443 for ; Mon, 31 Jul 2023 03:49:48 +0300 (EEST) Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6bca88c3487so23013a34.2 for ; Sun, 30 Jul 2023 17:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690764586; x=1691369386; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=JcgGwzvUuNAK6/9ba3RwObK/yiF3aUfAqgEB+vrzmm0=; b=GdAgliJyuSlwT/r/SiMUO5z2MDszuhBOBgBHm6IHtPGMdofRbSnan0tuouLklyR4xr aY8lQyfnHZAykQU+PUEBYTU5SfnOzvKELfjrJM9pht1m0xyp4xgZWBahpAlGxNvqqNb3 Nd5ePKvlduxbAc2buY/fSiofAUki9cb6N48W9GwGqpX6ycEVaSM6f9YO5gews4HNw+tr Gw5HhiWv8pbG3ZAiwScJhlXGkJYiXS6o1z9mFL7feawVnRgJOf6AVBgDwi1eBqwv1w7d H9loOTAgXDLYjPd0yVqTWjejy6pGdU38soJ8WKxo0vfq+T6iDoa4XU5CMMnBiXINao8u Vi5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690764586; x=1691369386; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JcgGwzvUuNAK6/9ba3RwObK/yiF3aUfAqgEB+vrzmm0=; b=iH5VwTcfpXp/2XGf2U2XD0jFICleAsNObIoEFhbOa7hkl/9f8uKgURac1JspPbry+W m8LkberoIcyhBevrRNV3PP+rtUzT5TUxPNeCGJ1WP1dQjv1KGxVUw+I/WgDh/txNIPQo BQP8YrtmTwS20FD3SAHhZ8reC+y3WMjOYrVAo+nduVhrWFtLZKCjt3jDH6Ir/Yzp8+ba 3Xs3pJ3wd7bfGnABq48NK6msX8XlVL1EPf5SGO2TwwMg3bhPHGEofmfTSqs+nZ/4hTrA rHSGpGhL0vFnOT9ONad2xsZOlwXRWfZcz7u745bgqfjGlzD3jx9ZkqjPyVBTcTxEB6Xb TdAw== X-Gm-Message-State: ABy/qLYLzMBKVYxGRofKFCHrmR3DU1irItEnsoZ08LM8OxvbhL3I14b2 ytjdu4cNvrKCMYYYAncexaeqBJW7fMQ= X-Google-Smtp-Source: APBJJlEKfkjncmuuhNKwH9RhlfZZQIRzj+70a6ZKqMDkkKVgIjz51oGRr9gv1FYN43s+AatYylvFOg== X-Received: by 2002:a05:6870:c186:b0:1bb:c50d:7451 with SMTP id h6-20020a056870c18600b001bbc50d7451mr8522746oad.46.1690764585807; Sun, 30 Jul 2023 17:49:45 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id x6-20020a056870740600b001a695700c69sm3998251oam.37.2023.07.30.17.49.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jul 2023 17:49:44 -0700 (PDT) Message-ID: <76e91f86-4ec5-d7c3-4f6e-9f5bebd25586@gmail.com> Date: Sun, 30 Jul 2023 21:49:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/opt_common: Use %c instead of %s to write single char X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/30/2023 9:47 PM, Andreas Rheinhardt wrote: > Also combine multiple printfs. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/opt_common.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/fftools/opt_common.c b/fftools/opt_common.c > index 7c996f140d..3881d5bbef 100644 > --- a/fftools/opt_common.c > +++ b/fftools/opt_common.c > @@ -692,14 +692,13 @@ int show_codecs(void *optctx, const char *opt, const char *arg) > if (strstr(desc->name, "_deprecated")) > continue; > > - printf(" "); > - printf(avcodec_find_decoder(desc->id) ? "D" : "."); > - printf(avcodec_find_encoder(desc->id) ? "E" : "."); > - > - printf("%c", get_media_type_char(desc->type)); > - printf((desc->props & AV_CODEC_PROP_INTRA_ONLY) ? "I" : "."); > - printf((desc->props & AV_CODEC_PROP_LOSSY) ? "L" : "."); > - printf((desc->props & AV_CODEC_PROP_LOSSLESS) ? "S" : "."); > + printf(" %c%c%c%c%c%c", > + avcodec_find_decoder(desc->id) ? 'D' : '.', > + avcodec_find_encoder(desc->id) ? 'E' : '.', > + get_media_type_char(desc->type), > + (desc->props & AV_CODEC_PROP_INTRA_ONLY) ? 'I' : '.', > + (desc->props & AV_CODEC_PROP_LOSSY) ? 'L' : '.', > + (desc->props & AV_CODEC_PROP_LOSSLESS) ? 'S' : '.'); > > printf(" %-20s %s", desc->name, desc->long_name ? desc->long_name : ""); > > @@ -747,12 +746,13 @@ static void print_codecs(int encoder) > void *iter = NULL; > > while ((codec = next_codec_for_id(desc->id, &iter, encoder))) { > - printf(" %c", get_media_type_char(desc->type)); > - printf((codec->capabilities & AV_CODEC_CAP_FRAME_THREADS) ? "F" : "."); > - printf((codec->capabilities & AV_CODEC_CAP_SLICE_THREADS) ? "S" : "."); > - printf((codec->capabilities & AV_CODEC_CAP_EXPERIMENTAL) ? "X" : "."); > - printf((codec->capabilities & AV_CODEC_CAP_DRAW_HORIZ_BAND)?"B" : "."); > - printf((codec->capabilities & AV_CODEC_CAP_DR1) ? "D" : "."); > + printf(" %c%c%c%c%c%c", > + get_media_type_char(desc->type), > + (codec->capabilities & AV_CODEC_CAP_FRAME_THREADS) ? 'F' : '.', > + (codec->capabilities & AV_CODEC_CAP_SLICE_THREADS) ? 'S' : '.', > + (codec->capabilities & AV_CODEC_CAP_EXPERIMENTAL) ? 'X' : '.', > + (codec->capabilities & AV_CODEC_CAP_DRAW_HORIZ_BAND) ? 'B' : '.', > + (codec->capabilities & AV_CODEC_CAP_DR1) ? 'D' : '.'); > > printf(" %-20s %s", codec->name, codec->long_name ? codec->long_name : ""); > if (strcmp(codec->name, desc->name)) You could instead port this function to AVBPrint, to only print to stderr once. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".