* [FFmpeg-devel] [PATCH] avfilter/geq: unbreak alpha processing
@ 2022-05-07 12:04 Gyan Doshi
2022-05-07 19:10 ` Michael Niedermayer
0 siblings, 1 reply; 3+ messages in thread
From: Gyan Doshi @ 2022-05-07 12:04 UTC (permalink / raw)
To: ffmpeg-devel
d607af50fd broke alpha processing by always overwriting any supplied
alpha expression.
---
libavfilter/vf_geq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.c
index fd9e0fd80b..2b53980278 100644
--- a/libavfilter/vf_geq.c
+++ b/libavfilter/vf_geq.c
@@ -275,7 +275,7 @@ static av_cold int geq_init(AVFilterContext *ctx)
if (!geq->expr_str[A] && geq->bps != 32) {
geq->expr_str[A] = av_asprintf("%d", (1<<geq->bps) - 1);
- } else {
+ } else if (!geq->expr_str[A]) {
geq->expr_str[A] = av_asprintf("%f", 1.f);
}
if (!geq->expr_str[G])
--
2.35.3
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avfilter/geq: unbreak alpha processing
2022-05-07 12:04 [FFmpeg-devel] [PATCH] avfilter/geq: unbreak alpha processing Gyan Doshi
@ 2022-05-07 19:10 ` Michael Niedermayer
2022-05-08 4:37 ` Gyan Doshi
0 siblings, 1 reply; 3+ messages in thread
From: Michael Niedermayer @ 2022-05-07 19:10 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 412 bytes --]
On Sat, May 07, 2022 at 05:34:39PM +0530, Gyan Doshi wrote:
> d607af50fd broke alpha processing by always overwriting any supplied
> alpha expression.
> ---
> libavfilter/vf_geq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
What does censorship reveal? It reveals fear. -- Julian Assange
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avfilter/geq: unbreak alpha processing
2022-05-07 19:10 ` Michael Niedermayer
@ 2022-05-08 4:37 ` Gyan Doshi
0 siblings, 0 replies; 3+ messages in thread
From: Gyan Doshi @ 2022-05-08 4:37 UTC (permalink / raw)
To: ffmpeg-devel
On 2022-05-08 12:40 am, Michael Niedermayer wrote:
> On Sat, May 07, 2022 at 05:34:39PM +0530, Gyan Doshi wrote:
>> d607af50fd broke alpha processing by always overwriting any supplied
>> alpha expression.
>> ---
>> libavfilter/vf_geq.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> LGTM
Pushed as b980d9e8ecf5d4bc5e39a74bdad98c7cc400da84
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-08 4:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-07 12:04 [FFmpeg-devel] [PATCH] avfilter/geq: unbreak alpha processing Gyan Doshi
2022-05-07 19:10 ` Michael Niedermayer
2022-05-08 4:37 ` Gyan Doshi
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git