From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 610694A622 for ; Tue, 2 Apr 2024 00:11:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2477368CFFC; Tue, 2 Apr 2024 03:11:41 +0300 (EEST) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7508568CC3B for ; Tue, 2 Apr 2024 03:11:34 +0300 (EEST) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5d81b08d6f2so3611143a12.0 for ; Mon, 01 Apr 2024 17:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712016692; x=1712621492; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Ke342lrg4JfN2OhwfvbkAu7mE78sG76gEQNATt2OXlc=; b=h+HviH+4PvRL1f951ivly+mX9uKojT7X08Q8dUsvik8euNClCYHj95jVnN801KOkIK hIg/HJo2W5WM76pkE5RnLFxJ+AUry9sp+QdTH+TJbzEKJubDpnvd37PWzX6Vnlf2vkE5 avWkAb1lE0V92CyfUpBZZLm3DP0G6ZWC5vNym0I6ACdqOBuufSea+oU7p+zAV/uYBJ5o y6XShdWtUJQSYAARwcxnNQqYl5oKyqLrykCvfWg7MAnqszRkj+ZvDQKanmisbKf0OIEi 8cSjjS3GSy9y3XhoEzcobS64tOg076YMAgFzQiTePHLfzDOPLs6BnkxM5zB8XksevdRZ JjCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712016692; x=1712621492; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ke342lrg4JfN2OhwfvbkAu7mE78sG76gEQNATt2OXlc=; b=u4paj+f0Mky4ZIdpjszwvHXOx7RMfV6CZiMEH9EZxA8bHGJyhnfK5PvoiutmvIsWlB 5j6tccZX44NrRN8smQ5d/7CM+/VGZa+eVgGB4k5YvBFgGKywKPBjwGNtcpH8WqyjNDXg Se7URSeO3yS4BoTqq6OWg04JpK/feJ9NZ034ifLgSIe5CAbjP3FTqY+RfUd+ZBeKJs5p y8+zEqC/qQWTRrE9itHUOh6/VGw312gXZpxEmyJDbAFxUJlw5s05gfp1RycLS4UdgAp/ lH7aRZZwsMI9CFPMe6+VuG2tmlSAADbZnWLvusgqbjyJf/0sMqadXISLPXWzRCu2cO10 xaUg== X-Gm-Message-State: AOJu0YxJbMSp+P15vbCa/M8cjJFaml9llat9FO5YdDE+hjwiDd4tWE7j R3V6ZTW4iZYye6amHOk3UXpZv+cFEtycL1zSXGiZ4qc176SgBJyxcW1Sl2j/ X-Google-Smtp-Source: AGHT+IHlG8Pt2CUldUwD7+PNg5Bpzh8a2BlPLuTDI7nitJMLF+tPY9R3u/BGP2Adp9Ui+83eDiX51w== X-Received: by 2002:a17:902:f68a:b0:1df:f859:91bd with SMTP id l10-20020a170902f68a00b001dff85991bdmr13136895plg.4.1712016691485; Mon, 01 Apr 2024 17:11:31 -0700 (PDT) Received: from [192.168.0.15] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id j13-20020a170903024d00b001e23e8fd808sm6268016plh.217.2024.04.01.17.11.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Apr 2024 17:11:31 -0700 (PDT) Message-ID: <766629d0-844c-498a-8558-eaac394787de@gmail.com> Date: Mon, 1 Apr 2024 21:11:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240401205607.9093-1-michael@niedermayer.cc> <77140ca3-bf2f-42db-9a76-264529c9ee5a@gmail.com> <20240401234007.GM6420@pb2> Content-Language: en-US From: James Almer In-Reply-To: <20240401234007.GM6420@pb2> Subject: Re: [FFmpeg-devel] [PATCH 1/6] avformat/isom: Uninit layout in ff_mp4_read_dec_config_descr() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/1/2024 8:40 PM, Michael Niedermayer wrote: > On Mon, Apr 01, 2024 at 06:33:22PM -0300, James Almer wrote: >> On 4/1/2024 5:56 PM, Michael Niedermayer wrote: >>> Fixes: memleak >>> Fixes: 67442/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5068813261406208 >>> >>> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavformat/isom.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/libavformat/isom.c b/libavformat/isom.c >>> index 9fbccd4437f..c5930bd4d87 100644 >>> --- a/libavformat/isom.c >>> +++ b/libavformat/isom.c >>> @@ -359,6 +359,7 @@ int ff_mp4_read_dec_config_descr(AVFormatContext *fc, AVStream *st, AVIOContext >>> st->codecpar->extradata_size, 1, fc); >>> if (ret < 0) >>> return ret; >>> + av_channel_layout_uninit(&st->codecpar->ch_layout); >>> st->codecpar->ch_layout.order = AV_CHANNEL_ORDER_UNSPEC; >> >> Not strictly related to this fix, but should we really drop the layout here >> by forcing unspec? We're also not even bothering to check if cfg.channels >> matches st->codecpar->ch_layout.nb_channels. > > I was wondering the same. > I was hoping someone would know the specs well enouh to just say straight > "this and that isnt legal together error out if thats true" Maybe Marton knows, since he's been working on this code. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".