From: Tim Angus <tim@ngus.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/assenc: fix incorrect copy of null terminator
Date: Tue, 31 Jan 2023 13:37:02 +0000
Message-ID: <75b4adb4-fb66-b2d4-0ea5-eae22d1ae871@ngus.net> (raw)
In-Reply-To: <tencent_C3CF9CD501274EB88A16364D4EA01ACD9207@qq.com>
On 31/01/2023 12:37, "zhilizhao(赵志立)" wrote:
>> + /* extradata may or may not be null terminated; in the case where
>> + * it is, avoid copying a null into the middle of the buffer */
>> + while (header_size > 0 && par->extradata[header_size - 1] == '\0')
>> + header_size--;
>> +
> The comment is misleading. extradata is always null terminated, although
> those paddings don’t count in extradata_size.
That's a bit pedantic, but I take your point. "The contents of extradata
may or may..." would be better. Following some discussion on IRC, I've
actually submitted another patch that solves the problem in a different
way, but I don't think anyone has looked at it yet...
http://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/306017.html
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-01-31 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 14:31 [FFmpeg-devel] [PATCH 0/1] Handle ASS format subtitle encoding ambiguity Tim Angus
2023-01-18 14:31 ` [FFmpeg-devel] [PATCH] avformat/assenc: fix incorrect copy of null terminator Tim Angus
2023-01-31 12:37 ` "zhilizhao(赵志立)"
2023-01-31 13:37 ` Tim Angus [this message]
2023-01-21 19:50 ` [FFmpeg-devel] [PATCH 0/1] Handle ASS format subtitle encoding ambiguity Tim Angus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75b4adb4-fb66-b2d4-0ea5-eae22d1ae871@ngus.net \
--to=tim@ngus.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git