From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 07A17420A4 for ; Tue, 22 Feb 2022 08:49:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C918268B018; Tue, 22 Feb 2022 10:49:36 +0200 (EET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 61B74689F20 for ; Tue, 22 Feb 2022 10:49:24 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645519774; x=1677055774; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=XpXorvZESajc+eNVSm3DXBKEc4/CBXh/nSMu+XwoxiY=; b=m+lqUYEd84pm76MycW5NeM/dYrXvn5bdVTsncLk86SvFCd2YUA7X4cKd lUgI6Pfx/jymruFlodMCNzuQ5AwazPy0sO/EmUrF2oyVHMwaXxPB9kzz1 OrcY0/EBzcRB+ZA2kBcrZ7WkK4zsIsGKTXaR0nyKgN6bREVTkg6H5xVAp gRhF03C1ja2KHxMPX9To7Is03xmdF8tKcwWKHw2AcK7oPSrOS9t+sx6wE po3l/Pk4D5pkMBMXwZCCMwki0O/xpB1f5H5kaIAnsLozwG7N1Solfvn1/ /u5CS2LCf8ryGWZk/YNOSPE1CaN8DxRPv275k7IB5Q7azy/1nQg/taecG Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="251409989" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="251409989" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 00:49:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="706533892" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 22 Feb 2022 00:49:20 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 22 Feb 2022 00:49:20 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 22 Feb 2022 00:49:19 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 22 Feb 2022 00:49:19 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 22 Feb 2022 00:49:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g6MwHeLSiboR40nebYJ/xGrP/qPyHrHQNZSHfmRpxQlRgWsHlKVoZ4oGGPQnUnbFyLOtYYUGqIQPi2Fhh67iYlyGixTLLo6HQyJb7KXo9pCyYzSh3HHm/0289VDb55CdMequKVCVtHmpyi5gYkA7D9wYImHdF6TWg1fu5bWIpNmIuQ8aNYhhI429VGh+EFD4aRPsf3jHgQRsThcBgkDD+uSHvknMD/LEFkRFK9luGS2jWAeJhg0Ez5XQUmgQmE6WJNkY9ehSbRshN2v09AdLBCU0XtUkazE/mJamVkTZJkkq4ZP4rbGQf1aQwHsuvdeTjyJe3UtebTDWw7+iypD2Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XpXorvZESajc+eNVSm3DXBKEc4/CBXh/nSMu+XwoxiY=; b=NW6nsAK7S3SJT+A67K3sUQ7cEpXE7TbGs5WwDTpV/xHh+CQWTfEUgIkWcHx91JjIEv0lPZXmo3qJoptKBKAfnslz0W9VunBgJX3gqOb4kLzr6CKzh2OnCPcvvxT6W15/rA1NoyZBI+/UUR/jcjMMS5HTDn8Gd0xh0iwSJN1PFyB0wJjChtTJiHscm9s11c4SrTGanz1qSLF1LGEpY8oFsRt/zx1g9vykPvi+zOpp6pMOL/dy622y9DyDuBABiqOm6i0tI68PlzoDOSMX/T/29XZ3Je/D9KMmoRSiAGeJt3BuUGVsz2Vuzrg9g9joIheBSdp04+Q3UPC6bL1sZ+CCRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by SJ0PR11MB4894.namprd11.prod.outlook.com (2603:10b6:a03:2d4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Tue, 22 Feb 2022 08:49:17 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::600d:3095:b0:f8c1]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::600d:3095:b0:f8c1%5]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022 08:49:17 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2 1/4] lavc/vaapi_encode_h265: Add P frame to GPB frame support for hevc_vaapi Thread-Index: AQHYJsli8kR3hmzsMUyqPODCQofIfqyd6V8AgAEoL4CAADGWgA== Date: Tue, 22 Feb 2022 08:49:17 +0000 Message-ID: <757b53c74767bedb2f98a1373213feca3efd98b3.camel@intel.com> References: <20220221021337.2190359-1-fei.w.wang@intel.com> <03ec8c31-088a-95b6-a514-6fbf14518537@jkqxz.net> <3b94feeb89d9a990cc11d8b2b35a0949736e6fb6.camel@intel.com> In-Reply-To: <3b94feeb89d9a990cc11d8b2b35a0949736e6fb6.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5627fb63-bb6e-4857-d76d-08d9f5e0361c x-ms-traffictypediagnostic: SJ0PR11MB4894:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C85rnISVeNYz/ff7XwMPwIujMgZUsW/moogJqJNELIfty+hHfEqFZss+0fhgdIXFOR9dKc5klDm11vYGOAfe0pjYSZaNRLumUmG4sZ4gJ9ZFNXOCn7Ozk3lac5oR87Qh2AD0WI7gAGmm07xY3HboMJWHS20IId8mn+APv6d1CExtji4lEs30zXIlPKmwEJZ167CSMv9pcYnUsiUBpjkBnQubbuAlBL1zk+8w8OQTL8W7/eW95MygU7bD11FoCB2Awarr4/AJu5LMhEoE4Va6LTgImEqC8kyP7m55D81svPG1kYXuerECFE7yUD2DfFU2ip+gZ+j3QZf4qaKV0L3u+WO+PbSJJAyMmi5a7jHms9TohZ3UW1Z6RTWob5USeXNCEFCSil1YLcmSEUd10TaXE14cIsE5AH1RZeKNRBctcH22VBRd4i/cFX/v+nZCKsyS8vqxwv7ks8iUpl4iKnNDsl2jOIwtS6hsyyKKiRkdKnzcu0KmAtW8D8FtDdRNJMR8xun911fOFA9JVdyoJVaeOHN2Wo3e+aKp4m2xcf3bJkdn5foYzFG23CpyjZfcdAdSrCOU1ONLKCM8XdW1zktG5uDzvDC0ohEaIbyY4xlnr2LeMjLMgsjSy7PMA2gX9dTLnMuZW7WQ8uodgS4bO6PCLXWd6VGW9QpGHO/Z259Fw9761Ds5Xp166FPTaiUxegWfSxYH1U1dIbqRwZvfzBsZG2xKgzJa1sabErVrwKgpVmKoaC55MarSWfnmKp2Tv1mFp3HOZjICzMR5EIGMjJJ70YavDWoxiwc9kkTBSK9KBGQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66476007)(6506007)(36756003)(2906002)(82960400001)(6512007)(8936002)(66556008)(86362001)(26005)(53546011)(122000001)(66446008)(186003)(8676002)(2616005)(6486002)(966005)(508600001)(38100700002)(66946007)(30864003)(64756008)(5660300002)(71200400001)(316002)(83380400001)(91956017)(38070700005)(6916009)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cm42VEYvcFB3RHhJZU5UdDJ1ZU9CRGFJWFFNVGgxbFBOOXZBcFYyU0hDN2Rs?= =?utf-8?B?eUhSUU9KZFlpaFB1c040eHF2RER6bm5Gd0xDK1NUeklFM0xHeXlBNkpRcTl5?= =?utf-8?B?VGFiVzdPVjBUMHhETEozRk1qZ2RVai9uTFFYYjJtZHBqTTFycHkvSEVsb0VB?= =?utf-8?B?eE8yTi95aU1ncStPYkU1SkpkSC9rUC9uM0JnME9MS3d3cVpjeTV6OHptbkpT?= =?utf-8?B?MUo1cXhpbnYrQ1JsSnBYMjhCenJmWFBDbjQ1TlhGYUdzZ0tBMDBWa1hhMlRa?= =?utf-8?B?eFBoWlRRUnEvTVNFbnR6bDkrVVNnK29iSkRiSHNmTHNhRDh6UVlaVWU2L2ZJ?= =?utf-8?B?TGVNRTdPbElDblVkT2tVaFNvbVcxVFZvMEpMN3Y3ZUdjY0ZrL1dveE1rbGJr?= =?utf-8?B?djM5VnFpOW1nVUNwWVVKblZ5R2hGMkNPRC9UanlNWkpqWW5wb0wvcFNFRS9y?= =?utf-8?B?bVlXcGVUVHEvUytEZFRWb25IN3NNWnBYMWowZHNnc3ZnRTlib1pQSkNZYjJM?= =?utf-8?B?Z1RYTnlSaWtMUFpreFN4V2g5NW9uc2w2dmxuTWlMNk51Z3lMOFcwZDUzbkow?= =?utf-8?B?dTVxMnJjeFBrZWgvMXlqVUZiY1B5aFNpL25nNnZwQjRtVjlWSWhQZEJpd1Nz?= =?utf-8?B?dlJ2T2VwK2w3OVd2MXhXeC9HUlZSbkppUWdDTWRRNUlKdW0zTHphRytRNnRW?= =?utf-8?B?UTVoN2owMGhCamo2SFU4ZkgxK3VsbUNsM3hPVGJpVVdoRWc5SjRtS1IycllY?= =?utf-8?B?TFdGY1hVdGF2RDhsck5BNXNRMEgvME9CV21DanVwZlVnV1hMMXBHRVJTOVNL?= =?utf-8?B?Q1cvdVJnQ3pQcnZhTCsyWlN2eUtWbWU3MHhjU0R5dDh3Y242WWhNaHZRNnlE?= =?utf-8?B?Ym9KeGt5STVoemhqcG5BWkVIcXdqK3MyUzlYRm9KV3owYU16ZDN6K0VKOWl4?= =?utf-8?B?RGVlUm5KcWVKenc0UExVNWRoLzdYWElYVW5GRWp6eUxaMnE4RnhISk05NmtS?= =?utf-8?B?bzlFOGxoSFBtVTRpekRtNE4vYytHZVhNdkJvbHJmbnJMc3hRQk95WWRTUjhk?= =?utf-8?B?aTZNY1BXaFIvVHVqTGJMdWhzdTNSczNuaGgrdy9qaTNqTk52amtKUzdvOE5R?= =?utf-8?B?WUxQbHhtUWwzNVdPNkx0dXRscnVtK1R5aVdvYjhmSVNvanpEL1JtZWFqOElu?= =?utf-8?B?UnBZV2laY2lDMlAzWG5vRlhaTXl6NDZSTFVqeUJqUVZGSVZFd2ZwYmd6TmlQ?= =?utf-8?B?MFVtTTQyaWNvMmUzc2F2ZmRwL2djclRUbHFSVThDQ2RUQ0pFcmRiUnlJNnVS?= =?utf-8?B?alI1dDQvYWRjUFN1Yzg5bFZOaUQyeG9QZmY5aTA5RzhsWjltN1hMMVZQTGZF?= =?utf-8?B?SHZML2dFYUI3cVNPa3cvSkg3Wk9Fc3RoWVFYaWxSNDg2LzlKM2VWcHZKM0I3?= =?utf-8?B?RDJTMnVzSmY0bWV4RnR1ZXJnQnFNTjREbmNzNFFnQ2dXMC8xT2gzcm15dlZR?= =?utf-8?B?bG5YVUxIb0dENXNCdjNRYlVXYlJJM0Y2L2JtanVSQmx2azByZHN5OWVFTmo5?= =?utf-8?B?dExzeW5oVnlrcFFSMklmVzRnMHhyekJ6YWJuZkRlMnNQUlJuTzBFeXNYeU5R?= =?utf-8?B?Q1FPWTJXUDFHd0h4bkZ0NDBMNmtxcXNwbVlxTHZ4WkdYczNNZVN4UURHY2R3?= =?utf-8?B?aDl1UUkxUkp6VUFjaE5kREtUK1NhajJBbnl5S0gzWkFWT2pOcHFNQmlWcmtW?= =?utf-8?B?NG13QlBZNVYzZ0k1d0VkK2hEaTdxdjBiZWZsMkpUN1JKbHJPUHNNZU8yQ1Ji?= =?utf-8?B?SjZtVWJJUW9VU1hEWTZNZmd0ZVQ5MzRnNWk0MVV4YTlJUnFwYWlMRXd1aTJ6?= =?utf-8?B?NzFvTzBTZndFUTM1c0lmTURZL2tMVzE1cnhqQnRrUDVFL2lWaUVEYzVLL2Zh?= =?utf-8?B?Yk82bmFzcW1OS0ZKRXpya3hLYmNuNE9sTHdvajVoaVVTbnZ4aVNxQ2cwb3Vh?= =?utf-8?B?KzIvc0xVdVMrS2RwU25UOUNINFJSbVFmVmRCc1M3TWNYSHYvSnV6WGpvOVdV?= =?utf-8?B?blkxWFM0U0RuRGlIaVJIK21UaDRDSkoxZ0pyS1ZQY1I4V0JwaUhheUpCYU5v?= =?utf-8?B?MU9VeEVPNU50WGVMZ0RIemVnNXNRTWlIZTFOdzhxWjVzSjNURlROYkFZOWFr?= =?utf-8?Q?upNs0hLR4genpirwWdUt3k8=3D?= Content-ID: <776DAAFBCF35A44D905816310D820D47@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5627fb63-bb6e-4857-d76d-08d9f5e0361c X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 08:49:17.8038 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mTVqHIIQYHRW8uBeIKjMxSdkn3LSRDCqaRzC2MY2eO0hKi5DmHKusFyvnTxpNvyHbQiBnM6T0mNYe/cgmbXVRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4894 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] lavc/vaapi_encode_h265: Add P frame to GPB frame support for hevc_vaapi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-02-22 at 05:46 +0000, Xiang, Haihao wrote: > On Mon, 2022-02-21 at 12:06 +0000, Mark Thompson wrote: > > On 21/02/2022 02:13, Fei Wang wrote: > > > From: Linjie Fu > > > > > > Use GPB frames to replace regular P frames if backend driver does > > > not > > > support it. > > > > > > - GPB: > > > Generalized P and B picture. P frames replaced by B frames > > > with > > > forward-predict only, L0 == L1. Normal B frames still have 2 > > > different ref_lists and allow bi-prediction > > > > > > Signed-off-by: Linjie Fu > > > Signed-off-by: Fei Wang > > > --- > > > libavcodec/vaapi_encode.c | 33 > > > +++++++++++++++++++++++++++++++-- > > > libavcodec/vaapi_encode.h | 1 + > > > libavcodec/vaapi_encode_h265.c | 15 +++++++++++++++ > > > 3 files changed, 47 insertions(+), 2 deletions(-) > > > > This always fails immediately on current iHD > > (7e357b4bea76b2fe2522e6af41ae02ea69cec49e): > > > > $ ./ffmpeg_g -v 44 -y -hwaccel vaapi -hwaccel_output_format vaapi > > -i in.mp4 > > -an -c:v hevc_vaapi -low_power 1 out.mp4 > > ... > > [hevc_vaapi @ 0x560e81d45e80] Using input frames context (format > > vaapi) with > > hevc_vaapi encoder. > > [hevc_vaapi @ 0x560e81d45e80] Input surface format is nv12. > > [hevc_vaapi @ 0x560e81d45e80] Using VAAPI profile VAProfileHEVCMain > > (17). > > [hevc_vaapi @ 0x560e81d45e80] Using VAAPI entrypoint > > VAEntrypointEncSliceLP > > (8). > > [hevc_vaapi @ 0x560e81d45e80] Using VAAPI render target format > > YUV420 (0x1). > > [hevc_vaapi @ 0x560e81d45e80] Using CTU size 64x64, min CB size > > 8x8. > > [hevc_vaapi @ 0x560e81d45e80] No quality level set; using default > > (25). > > [hevc_vaapi @ 0x560e81d45e80] RC mode: CQP. > > [hevc_vaapi @ 0x560e81d45e80] RC quality: 25. > > [hevc_vaapi @ 0x560e81d45e80] RC framerate: 30000/1001 (29.97 fps). > > [hevc_vaapi @ 0x560e81d45e80] Use GPB B frames to replace regular P > > frames. > > [hevc_vaapi @ 0x560e81d45e80] Using intra, GPB-B-frames and B- > > frames > > (supported references: 3 / 3). > > [hevc_vaapi @ 0x560e81d45e80] All wanted packed headers available > > (wanted 0xd, > > found 0x1f). > > [hevc_vaapi @ 0x560e81d45e80] Using level 4. > > ... > > [hevc_vaapi @ 0x560e81d45e80] Failed to end picture encode issue: > > 24 (internal > > encoding error). > > [hevc_vaapi @ 0x560e81d45e80] Encode failed: -5. > > Video encoding failed > > ... > > $ cat /proc/cpuinfo | grep 'model name' | head -1 > > model name : Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz > > $ uname -v > > #1 SMP PREEMPT Debian 5.16.7-2 (2022-02-09) > > > > Do you get this too, or is your setup different somehow? > > Hi Mark, > > I tested this patchset with iHD > (7e357b4bea76b2fe2522e6af41ae02ea69cec49e) on > CFL (low_power=0), RKL and DG1, i965 on SKL, and didn't see this > issue before. > This day I reproduced this issue on ICL. It seems iHD driver doesn't > return > right values for ICL. Thanks Mark to report this issue on ICL. I tested on TGL and CFL before submitted this patch set, all looks good. I will check why this fail on ICL. And will fix your other comments together in next version. Fei Thanks > > > > diff --git a/libavcodec/vaapi_encode.c > > > b/libavcodec/vaapi_encode.c > > > index 3bf379b1a0..95eca7c288 100644 > > > --- a/libavcodec/vaapi_encode.c > > > +++ b/libavcodec/vaapi_encode.c > > > @@ -1845,6 +1845,30 @@ static av_cold int > > > vaapi_encode_init_gop_structure(AVCodecContext *avctx) > > > ref_l1 = attr.value >> 16 & 0xffff; > > > } > > > > > > + ctx->p_to_gpb = 0; > > > + > > > +#if VA_CHECK_VERSION(1, 9, 0) > > > + attr = (VAConfigAttrib) { VAConfigAttribPredictionDirection > > > }; > > > + vas = vaGetConfigAttributes(ctx->hwctx->display, > > > + ctx->va_profile, > > > + ctx->va_entrypoint, > > > + &attr, 1); > > > > This probably shouldn't be done at all if the user has selected a > > codec > > without B-frames or a configuration which is intra-only, because > > the log > > message is confusing: > > > > [mjpeg_vaapi @ 0x55b90d72ee00] Driver does not report whether > > support GPB, use > > regular P frames. > > [mjpeg_vaapi @ 0x55b90d72ee00] Using intra frames only. > > > > > + if (vas != VA_STATUS_SUCCESS) { > > > + av_log(avctx, AV_LOG_WARNING, "Failed to query > > > prediction direction > > > " > > > + "attribute: %d (%s).\n", vas, vaErrorStr(vas)); > > > > And fail? > > 4/4 also ignores the error. It would be better to handle the error in > the same > way and update 4/4 too. > > > > + } else if (attr.value == VA_ATTRIB_NOT_SUPPORTED) { > > > + av_log(avctx, AV_LOG_VERBOSE, "Driver does not report > > > whether " > > > + "support GPB, use regular P frames.\n"); > > > > "support GPB" is a strange thing to say. It's a constraint - any > > driver which > > supports B-frames will let you have the same thing in both > > RefPicLists, but > > some require it because they don't support P-frames. > > > > So maybe something like "Driver does not report any additional > > prediction > > constraints, using P-frames."? > > > > > + } else { > > > + if (attr.value & VA_PREDICTION_DIRECTION_BI_NOT_EMPTY) { > > > + ctx->p_to_gpb = 1; > > > + av_log(avctx, AV_LOG_VERBOSE, "Use GPB B frames to > > > replace " > > > + "regular P frames.\n"); > > > > Maybe "Driver does not support P-frames, replacing them with B- > > frames."? > > > > > + } else > > > + av_log(avctx, AV_LOG_VERBOSE, "Use regular P > > > frames.\n"); > > > + } > > > +#endif > > > + > > > if (ctx->codec->flags & FLAG_INTRA_ONLY || > > > avctx->gop_size <= 1) { > > > av_log(avctx, AV_LOG_VERBOSE, "Using intra frames > > > only.\n"); > > > @@ -1861,8 +1885,13 @@ static av_cold int > > > vaapi_encode_init_gop_structure(AVCodecContext *avctx) > > > ctx->p_per_i = INT_MAX; > > > ctx->b_per_p = 0; > > > } else { > > > - av_log(avctx, AV_LOG_VERBOSE, "Using intra, P- and B- > > > frames " > > > - "(supported references: %d / %d).\n", ref_l0, > > > ref_l1); > > > + if (ctx->p_to_gpb) > > > + av_log(avctx, AV_LOG_VERBOSE, "Using intra, GPB-B- > > > frames and " > > > + "B-frames (supported references: %d / %d).\n", > > > + ref_l0, ref_l1); > > > > Seems easier to just say intra and B-frames (though this isn't > > really adding > > anything to the message above - it's still effectively a P-frame > > referring to > > one previous frame, just using B-slices to do it in a strange way). > > > > > + else > > > + av_log(avctx, AV_LOG_VERBOSE, "Using intra, P- and B- > > > frames " > > > + "(supported references: %d / %d).\n", ref_l0, > > > ref_l1); > > > ctx->gop_size = avctx->gop_size; > > > ctx->p_per_i = INT_MAX; > > > ctx->b_per_p = avctx->max_b_frames; > > > diff --git a/libavcodec/vaapi_encode.h > > > b/libavcodec/vaapi_encode.h > > > index b41604a883..61c5615eb8 100644 > > > --- a/libavcodec/vaapi_encode.h > > > +++ b/libavcodec/vaapi_encode.h > > > @@ -328,6 +328,7 @@ typedef struct VAAPIEncodeContext { > > > int idr_counter; > > > int gop_counter; > > > int end_of_stream; > > > + int p_to_gpb; > > > > > > // Whether the driver supports ROI at all. > > > int roi_allowed; > > > diff --git a/libavcodec/vaapi_encode_h265.c > > > b/libavcodec/vaapi_encode_h265.c > > > index e1dc53dfa9..ea45893508 100644 > > > --- a/libavcodec/vaapi_encode_h265.c > > > +++ b/libavcodec/vaapi_encode_h265.c > > > @@ -886,6 +886,7 @@ static int > > > vaapi_encode_h265_init_slice_params(AVCodecContext *avctx, > > > VAAPIEncodePictu > > > re *pic, > > > VAAPIEncodeSlice > > > *slice) > > > { > > > + VAAPIEncodeContext *ctx = avctx->priv_data; > > > VAAPIEncodeH265Context *priv = avctx->priv_data; > > > VAAPIEncodeH265Picture *hpic = pic->priv_data; > > > const H265RawSPS *sps = &priv->raw_sps; > > > @@ -908,6 +909,9 @@ static int > > > vaapi_encode_h265_init_slice_params(AVCodecContext *avctx, > > > > > > sh->slice_type = hpic->slice_type; > > > > > > + if (sh->slice_type == HEVC_SLICE_P && ctx->p_to_gpb) > > > + sh->slice_type = HEVC_SLICE_B; > > > + > > > sh->slice_pic_order_cnt_lsb = hpic->pic_order_cnt & > > > (1 << (sps->log2_max_pic_order_cnt_lsb_minus4 + 4)) - > > > 1; > > > > > > @@ -1066,6 +1070,9 @@ static int > > > vaapi_encode_h265_init_slice_params(AVCodecContext *avctx, > > > av_assert0(pic->type == PICTURE_TYPE_P || > > > pic->type == PICTURE_TYPE_B); > > > vslice->ref_pic_list0[0] = vpic->reference_frames[0]; > > > + if (ctx->p_to_gpb && pic->type == PICTURE_TYPE_P) > > > + // Reference for GPB B-frame, L0 == L1 > > > + vslice->ref_pic_list1[0] = vpic- > > > >reference_frames[0]; > > > } > > > if (pic->nb_refs >= 2) { > > > // Forward reference for B-frame. > > > @@ -1073,6 +1080,14 @@ static int > > > vaapi_encode_h265_init_slice_params(AVCodecContext *avctx, > > > vslice->ref_pic_list1[0] = vpic->reference_frames[1]; > > > } > > > > > > + if (pic->type == PICTURE_TYPE_P && ctx->p_to_gpb) { > > > + vslice->slice_type = HEVC_SLICE_B; > > > + for (i = 0; i < FF_ARRAY_ELEMS(vslice->ref_pic_list0); > > > i++) { > > > + vslice->ref_pic_list1[i].picture_id = vslice- > > > > ref_pic_list0[i].picture_id; > > > + vslice->ref_pic_list1[i].flags = vslice- > > > > ref_pic_list0[i].flags; > > > + } > > > + } > > > > Is it sensible to implement this properly in the generic code > > rather than > > having special ad-hoc code here? > > > > (Is there any chance this will also be a thing for e.g. H.264 or > > H.266 in > > future?) > > Considering that VAConfigAttribPredictionDirection is not a specific > attribute > for hevc in VA-API, I think it is acceptable to implement this in the > generic > code. > > Thanks > Haihao > > > > + > > > return 0; > > > } > > > > > > > - Mark > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".