From: Marton Balint <cus@passwd.hu>
To: "Kristoffer Brånemyr via ffmpeg-devel" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: Skip more parts of header to let parsing continue
Date: Tue, 12 Mar 2024 22:46:57 +0100 (CET)
Message-ID: <756a4062-4eee-5e65-f682-7067bbb7f950@passwd.hu> (raw)
In-Reply-To: <2086036019.4798443.1710184590892@mail.yahoo.com>
On Mon, 11 Mar 2024, Kristoffer Brånemyr via ffmpeg-devel wrote:
>
> Den måndag 26 februari 2024 kl. 19:36:58 CET, Kristoffer Brånemyr via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> skrev:
>
>
>> Hi,
>> Here is a short patch to skip more parts of the header for the WebVTT subtitle format. Without this the parser seems to stop and no subtitles are produced for the user.You can find the WebVTT specification here: WebVTT: The Web Video Text Tracks Format
>>> WebVTT: The Web Video Text Tracks Format>
>>
> >|
>>
> >|
>>
> >|
>>
>>
>> I attach an example file using the STYLE header part.
>> I verified that with this change, I can see the subtitles using mpv.
>>
>> I tried to run fate, but even without my changes it seems to fail?
>>
>
> Hi again,
>
> Did anyone get a chance to look at this patch? It's a small patch, only adding two lines.
>
> Looks like the URL to the WebVTT specification got broken last time by the webmail I use, I hope this time it will work better:
> https://www.w3.org/TR/webvtt1/#file-structure
Will apply.
Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-03-12 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <411082922.1517806.1708972592599.ref@mail.yahoo.com>
2024-02-26 18:36 ` Kristoffer Brånemyr via ffmpeg-devel
2024-03-11 19:16 ` Kristoffer Brånemyr via ffmpeg-devel
2024-03-12 21:46 ` Marton Balint [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=756a4062-4eee-5e65-f682-7067bbb7f950@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git