From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C224846D9B for ; Sat, 9 Dec 2023 19:25:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1BFF368D03D; Sat, 9 Dec 2023 21:24:59 +0200 (EET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6FCDF68C7E6 for ; Sat, 9 Dec 2023 21:24:52 +0200 (EET) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2866951b6e0so3116198a91.2 for ; Sat, 09 Dec 2023 11:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702149890; x=1702754690; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=8QPBPR6nTWEoOFmCY6FGZFljqAgtXK+TxaK0FL5tYUk=; b=hSsbdqI0c8U1i1AL7xG4a2ua/HTegsfueqTljKSIm/okyBn8GkBaiibrdExqjhGyWH oCmQqnwMRhSFJ3t/NoxJD9e4Jov7kIXu0MtIchEz3eKyjppSxlik7R0AcCxsdvPo6P+Q G1rIyVCEJBkG7qxIzLgdVIRExjnDz3+i6ffPbNpWdNvCIx3tlCp1MyrTX2callPxgfJv enXMQLlY/WmQ1H+EtULfoY5iIkOytXkNnsBvCUy54AN6vtNEdtEHct/ChEYIMdx1PH3t UxgVgxFyG+kIYWhKTVsJIPZSsa2YbUuhaXQqIyrVSqHFGOJvVIIpuAWmUJCBkjCZtRT9 6m0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702149890; x=1702754690; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8QPBPR6nTWEoOFmCY6FGZFljqAgtXK+TxaK0FL5tYUk=; b=tzdHmfVtcvcYhVI9EgsnBzE+icxtEIRqaxzquM5hEskvNBU/Z4p6Cl1Pms/G/R/a0w DQX18Fb14s7wJrvHIo/ngcWOGxs+GPK6RZ8d/bnrT8UW+l+5ZMh6z7kFx5UsDJVZkrHn oYKMgQavmOQpat+9vFiKOTTfgq0L1letdnSdEgxoNUOIfqFEKS8fE2R74WC1glHydl8s 64XQk0h9PCYABQt5eVuGlg5aMmrfoCkJ1oc2GnesAscqaJvkEMCG/L6L3Xl7d1ODQRRs 1P8C5skFB9f4cWcllr5d7+xo1GQPC8Bfh1CYWBkaBU/bViSCCOJX89isRjoDXcrCgNAt xPVA== X-Gm-Message-State: AOJu0YysoRuC3Ou9cdI2RXsWwQUbNVpkDEGG01XY1Y3nKbyTWQX+8KQJ QSNBbuXCelgG9RFjmANEkozAP01g2Wc= X-Google-Smtp-Source: AGHT+IFJBfNA18D2bcvx1ctz1bAWeI6DC+wy1vhv2qto1i2Tv15HsPTAiac3uiVvrsCfqcBH6eBnrQ== X-Received: by 2002:a17:90a:fe0d:b0:286:6cc0:cacc with SMTP id ck13-20020a17090afe0d00b002866cc0caccmr1648880pjb.67.1702149889197; Sat, 09 Dec 2023 11:24:49 -0800 (PST) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id k9-20020a170902c40900b001b9e9edbf43sm3730318plk.171.2023.12.09.11.24.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Dec 2023 11:24:47 -0800 (PST) Message-ID: <75460395-5a4b-4ac1-99df-23f2c01f2f09@gmail.com> Date: Sat, 9 Dec 2023 16:24:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231209191002.680650-1-marth64@proxyid.net> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20231209191002.680650-1-marth64@proxyid.net> Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: inform user about -b:a and -b:v instead of legacy form X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/9/2023 4:10 PM, Marth64 wrote: > --- > fftools/ffmpeg_opt.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index 304471dd03..5e50e5efa2 100644 > --- a/fftools/ffmpeg_opt.c > +++ b/fftools/ffmpeg_opt.c > @@ -1721,8 +1721,8 @@ const OptionDef options[] = { > { "force_key_frames", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT | > OPT_SPEC | OPT_OUTPUT, { .off = OFFSET(forced_key_frames) }, > "force key frames at specified timestamps", "timestamps" }, > - { "b", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate }, > - "video bitrate (please use -b:v)", "bitrate" }, > + { "b:v", OPT_VIDEO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate }, > + "video bitrate", "bitrate" }, "b" is for bitrate regardless of media type. The specifier that comes after it decides the type. You're probably breaking that by making "b" no longer be a valid option. IMO, change the description to "Stream bitrate". > { "hwaccel", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT | > OPT_SPEC | OPT_INPUT, { .off = OFFSET(hwaccels) }, > "use HW accelerated decoding", "hwaccel name" }, > @@ -1762,8 +1762,8 @@ const OptionDef options[] = { > { "acodec", OPT_AUDIO | HAS_ARG | OPT_PERFILE | > OPT_INPUT | OPT_OUTPUT, { .func_arg = opt_audio_codec }, > "force audio codec ('copy' to copy stream)", "codec" }, > - { "ab", OPT_AUDIO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate }, > - "audio bitrate (please use -b:a)", "bitrate" }, > + { "b:a", OPT_AUDIO | HAS_ARG | OPT_PERFILE | OPT_OUTPUT, { .func_arg = opt_bitrate }, > + "audio bitrate", "bitrate" }, And this just removes "ab" altogether, which is a break with no previous warning. b:a already works thanks to "b" above. Just flag this option as deprecated. > { "atag", OPT_AUDIO | HAS_ARG | OPT_EXPERT | OPT_PERFILE | > OPT_OUTPUT, { .func_arg = opt_old2new }, > "force audio tag/fourcc", "fourcc/tag" }, _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".