Re: [FFmpeg-devel] [PATCH v9 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl

From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v9 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl
Date: Mon, 28 Mar 2022 17:16:09 -0400
Message-ID: <74e44665-37ed-bf5e-0ba4-7494706d2742@gmail.com> (raw)
In-Reply-To: <AS1PR01MB95649E92B62F9374024316988F189@AS1PR01MB9564.eurprd01.prod.exchangelabs.com>

On 3/23/22 11:08, Andreas Rheinhardt wrote:
>> +            temp = av_realloc(ctx->buffer, ctx->buffer_size);
>> +            if (!temp) {
>> +                av_freep(&ctx->buffer);
> If you free this, you will be in a scenario where ctx->buffer is NULL,
> yet ctx->buffer_size is > 0. This is inconsistent and might lead to
> crashs in JxlEncoderProcessOutput. So don't free this and only set
> buffer_size after the reallocation succeeded.
Does it matter what ctx->buffer_size is if ctx->buffer is NULL?
On 3/23/22 11:08, Andreas Rheinhardt wrote:
> Unnecessary: av_freep() resets ctx->buffer and resetting buffer_size is
> unnecessary.

Here, you claim that resetting buffer_size is unnecessary but above you 
insist it is necessary. I'm confused here.

Leo Izen (thebombzen)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".