From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/flvenc: allow to write qualifying metadata as number
Date: Sun, 19 Feb 2023 13:43:55 +0530
Message-ID: <74c58297-8429-dffe-91aa-3396ad78cebb@gyani.pro> (raw)
In-Reply-To: <0a6a12ae-c903-cbe9-5503-1299bbb66201@gyani.pro>
Any further comments?
On 2023-02-14 06:21 pm, Gyan Doshi wrote:
>
>
> On 2023-02-14 03:35 pm, Anton Khirnov wrote:
>> Quoting Gyan Doshi (2023-02-11 12:02:51)
>>> The FLV format can store metadata as numbers which are used and handled
>>> by many streaming platforms.
>>>
>>> Now, metadata values can be sent as AMF Number type if
>>> 1) tag key starts with "num_"
>>> 2) value is scanned and can be represented as a double.
>>>
>>> Written tag will have "num_" prefix removed if written as AMF Number.
>> Using the normal metadata dict for structured data seems hacky to me.
>> Wouldn't it be better to add a private dict-type muxer option for this?
>
> The numerical metadata, like other string meta in FLV can change
> during streaming, so it will be
> reloaded and refreshed. Once you suggested to shift the loading
> metadata from file + reload options
> to fftools, this was the way to identify such metadata, since format
> contexts and AVStream only support
> one AVDictionary and entries will have to be commingled
>
> And this isn't really structured data. We are re-encoding how some of
> it is stored. It is still inputted
> by the user as strings. The prefix is a cheap hack to clearly identify
> such keys.
>
> (The other option would be add AVDictionary value 'types' and all
> associated signalling and tooling,
> which seems useful in the long run but overkill for this.)
>
> Regards,
> Gyan
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-19 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 11:02 Gyan Doshi
2023-02-14 8:46 ` Gyan Doshi
2023-02-14 10:05 ` Anton Khirnov
2023-02-14 12:51 ` Gyan Doshi
2023-02-19 8:13 ` Gyan Doshi [this message]
2023-02-20 16:40 ` Anton Khirnov
2023-02-21 4:47 ` Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c58297-8429-dffe-91aa-3396ad78cebb@gyani.pro \
--to=ffmpeg@gyani.pro \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git