From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 91DFC4729B for ; Tue, 3 Oct 2023 19:11:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B4E4E68CB40; Tue, 3 Oct 2023 22:11:44 +0300 (EEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6C1CA68C9E3 for ; Tue, 3 Oct 2023 22:11:38 +0300 (EEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1c60f1a2652so1370605ad.0 for ; Tue, 03 Oct 2023 12:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696360296; x=1696965096; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rIrnpp7XsPgOMSe9o6/9vIOSJeaNwKK6ynWV9QZIsGw=; b=XcexvXNCllljQxN3YItsdRA+JU2V9bSUWtyi1Ke6Z6SdFz1OIuk3QvdSXysAFL/4q3 J1Go+Zv8DhExA9OE1Km9RtuVH4CcK5+O66LC5a4WRLL+lkJUDDYYTjxhwM41HI8lufcq DM3qTWl2rJjn/ICaOIj4+BXODTL/4q89e3s8oca2/yMdjEqKbvdZBz0hnEjRt4uSXFFF 54tzTm/AGaMBMCRS5bm03Eq+ofnmm+LwqKwMBcd+Ei6SAqEgsHtk44Zdcd86MUfH/JWA mMAWacd15K1L5fHTk/64+aKO0X9N/HAaLGvfB0V8OmiDHF3JSRikvCFyiwAdEWoZ0iM7 LpJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696360296; x=1696965096; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rIrnpp7XsPgOMSe9o6/9vIOSJeaNwKK6ynWV9QZIsGw=; b=pmTLCFH0mqoJeRRsrqrI9aIKZHNIf8zfctWC8a5RVfB0cTYur/LcD2XmGPU/O1xEhV hHq4cDEV3bwoXn8j1087Tm4QobcXAzLYnK/k8gV8KHIb/mpndMMc7WizXHKZJ54r7hz2 V0eQQ439vKVAy4RNwlWk+p2ax6yyPn8phv5Na1VEb+JYPEDqrJwcXRWN58cvxEBO4VdQ NTkDHQ0CcF9x1XVeS9Wb9gfh9nb0y/eDCdC8oKnzKhJzIZzxvJ84OiJb5ZEoyVgF7QR+ KLDe6MzJg4LhJupPv+t3YlwMlTADq0bWdkDiY1lKrKaIDSnuU6+AhUqRYFMx9K8z8Wjn Biyw== X-Gm-Message-State: AOJu0Yy/ZXtXSIOPJl1p9xgLBK+we9ds1SUvro6ENOjlbooBgYGraOLK W7bSbg9Wk4EL5P5tTvy7qborcvtoqIg= X-Google-Smtp-Source: AGHT+IFzTy3DREO++7lahtB7GoHgdnl3Jy99nruS1/hLTo26Lv8pheXn+Ac84soiSuSC3PvNKvQhKQ== X-Received: by 2002:a17:903:32cd:b0:1c2:193e:1126 with SMTP id i13-20020a17090332cd00b001c2193e1126mr184873plr.28.1696360295667; Tue, 03 Oct 2023 12:11:35 -0700 (PDT) Received: from [192.168.0.10] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id bg5-20020a1709028e8500b001c0a4146961sm1970093plb.19.2023.10.03.12.11.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Oct 2023 12:11:35 -0700 (PDT) Message-ID: <74a78586-f263-41f7-b5cb-83fae8ffc46f@gmail.com> Date: Tue, 3 Oct 2023 16:11:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230927131242.1950-1-jamrial@gmail.com> <20230927131242.1950-9-jamrial@gmail.com> <169632831055.6638.12430831308758419966@lain.khirnov.net> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <169632831055.6638.12430831308758419966@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 08/11] avcodec/hevcdec: check for DOVI configuration record in AVCodecContext side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10/3/2023 7:18 AM, Anton Khirnov wrote: > Quoting James Almer (2023-09-27 15:12:39) >> Signed-off-by: James Almer >> --- >> libavcodec/avcodec.h | 2 +- >> libavcodec/decode.c | 10 ++++++++++ >> libavcodec/decode.h | 3 +++ >> libavcodec/hevcdec.c | 15 ++++++++++++++- >> 4 files changed, 28 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >> index da3c5234a0..48a4b73fd3 100644 >> --- a/libavcodec/avcodec.h >> +++ b/libavcodec/avcodec.h >> @@ -1903,7 +1903,7 @@ typedef struct AVCodecContext { >> /** >> * Additional data associated with the entire coded stream. >> * >> - * - decoding: unused >> + * - decoding: set by user before calling avcodec_open2(). > > Should be "may be set...", because it's optional. > > Also, I think this deserves to be mentione in APIchanges. Ok. > >> @@ -3644,12 +3651,18 @@ static av_cold int hevc_decode_init(AVCodecContext *avctx) >> atomic_init(&s->wpp_err, 0); >> >> if (!avctx->internal->is_copy) { >> + const AVPacketSideData *sd; >> + >> if (avctx->extradata_size > 0 && avctx->extradata) { >> ret = hevc_decode_extradata(s, avctx->extradata, avctx->extradata_size, 1); >> if (ret < 0) { >> return ret; >> } >> } >> + >> + sd = ff_get_coded_side_data(avctx, AV_PKT_DATA_DOVI_CONF); >> + if (sd && sd->size > 0) >> + ff_dovi_update_cfg(&s->dovi_ctx, (AVDOVIDecoderConfigurationRecord *) sd->data); > > Do you have a sample for this? Would be very nice to have a test for > this functionality. There's a sample in fate, but apparently it does stream copy (testing demux and mux code), so the hevc decoder never handles it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".