From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avdevice/alsa: simplify passing ff_alsa_open a channel layout
Date: Mon, 10 Feb 2025 09:49:56 -0300
Message-ID: <749e1aaf-df73-460c-8aa7-a68a3c1ce0bb@gmail.com> (raw)
In-Reply-To: <Z6nE3DeTp0-4nDw4@phare.normalesup.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 458 bytes --]
On 2/10/2025 6:20 AM, Nicolas George wrote:
> James Almer (12025-02-07):
>> This also ensures the layout set during the indev init is used instead of the
>> blank one in st->codecpar.
>
> No objection to the patch, but you were the one who added the access to
> st->codecpar, so that needs an explanation in the commit message.
No, i did not. ff_alsa_open() was already accessing it for
channel_layout before ffc4fd3cc2, which was also blank.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-02-10 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 2:53 James Almer
2025-02-10 9:20 ` Nicolas George
2025-02-10 12:49 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=749e1aaf-df73-460c-8aa7-a68a3c1ce0bb@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git