From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EDBAD457F3 for ; Fri, 24 Mar 2023 14:06:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9C88068C802; Fri, 24 Mar 2023 16:06:41 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 872B168C7A6 for ; Fri, 24 Mar 2023 16:06:35 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 32OE6Y69013347-32OE6Y6A013347 for ; Fri, 24 Mar 2023 16:06:34 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id A2B41A1542 for ; Fri, 24 Mar 2023 16:06:34 +0200 (EET) Date: Fri, 24 Mar 2023 16:06:34 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20230324133505.23229-1-jdek@itanimul.li> Message-ID: <74832ca4-b1a0-6c9e-5369-7c725fc5e386@martin.st> References: <20230324133505.23229-1-jdek@itanimul.li> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v2] configure: add LTO optarg X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 24 Mar 2023, J. Dekker wrote: > This allows users to specify an argument such as './configure > --enable-lto=thin' to use ThinLTO with Clang. The old functionality with > './configure --enable-lto' is preserved. > > Signed-off-by: J. Dekker > --- > configure | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/configure b/configure > index 8980cec7ee..bf5ad540cf 100755 > --- a/configure > +++ b/configure > @@ -412,7 +412,7 @@ Toolchain options: > --build-suffix=SUFFIX library name suffix [] > --enable-pic build position-independent code > --enable-thumb compile for Thumb instruction set > - --enable-lto use link-time optimization > + --enable-lto[=arg] use link-time optimization > --env="ENV=override" override the environment variables > > Advanced options (experts only): > @@ -2524,7 +2524,6 @@ CMDLINE_SELECT=" > debug > extra_warnings > logging > - lto > optimizations > rpath > stripping > @@ -4170,6 +4169,9 @@ for opt do > --enable-sdl) > enable sdl2 > ;; > + --enable-lto|--enable-lto=*) > + lto=-f${opt#--enable-} > + ;; > --enable-*=*|--disable-*=*) > eval $(echo "${opt%%=*}" | sed 's/--/action=/;s/-/ thing=/') > is_in "${thing}s" $COMPONENT_LIST || die_unknown "$opt" > @@ -4639,7 +4641,7 @@ icl_flags(){ > # on Windows, does enable remarks so disable them here. > -Wall) echo $flag -Qdiag-disable:remark ;; > -std=c99) echo -Qstd=c99 ;; > - -flto) echo -ipo ;; > + -flto*) echo -ipo ;; > esac > done > } > @@ -4647,7 +4649,7 @@ icl_flags(){ > icc_flags(){ > for flag; do > case $flag in > - -flto) echo -ipo ;; > + -flto*) echo -ipo ;; > *) echo $flag ;; > esac > done > @@ -7182,17 +7184,17 @@ fi > > check_optflags(){ > check_cflags "$@" > - enabled lto && check_ldflags "$@" > + [ -n "$lto" ] && check_ldflags "$@" > } > > check_optflags $optflags > check_optflags -fno-math-errno > check_optflags -fno-signed-zeros > > -if enabled lto; then > +if [ -n "$lto" ]; then > test "$cc_type" != "$ld_type" && die "LTO requires same compiler and linker" > - check_cflags -flto > - check_ldflags -flto $cpuflags > + check_cflags $lto > + check_ldflags $lto $cpuflags > disable inline_asm_direct_symbol_refs > fi > > @@ -7223,7 +7225,7 @@ if enabled icc; then > # icc 11.0 and 11.1 work with ebp_available, but don't pass the test > enable ebp_available > # The test above does not test linking > - enabled lto && disable symver_asm_label > + [ -n "$lto" ] && disable symver_asm_label > if enabled x86_32; then > icc_version=$($cc -dumpversion) > test ${icc_version%%.*} -ge 11 && > -- > 2.37.1 (Apple Git-137.1) LGTM, thanks. I didn't test this patch myself but it looks to me like it would work, and I presume you've tested it with GCC (in the default mode) and Clang (in both the old default mode and with specific arguments like =thin). // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".