From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] correct expression of ternary operation.
Date: Fri, 12 May 2023 12:30:12 -0400
Message-ID: <747d3f22-d46d-5158-6036-65330b984030@gmail.com> (raw)
In-Reply-To: <0eabd803-a3d7-3577-52f6-dfa5822c16b3@gmx.de>
On 5/12/23 06:56, Helge Klein wrote:
> Signed-off-by: Helge Klein <helge_klein@gmx.de>
> ---
> fftools/ffmpeg_opt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 7f22b22604..11639e7468 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -228,7 +228,7 @@ static void correct_input_start_times(void)
> if (copy_ts && start_at_zero)
> ifile->ts_offset = -new_start_time;
> else if (!copy_ts) {
> - abs_start_seek = is->start_time + (ifile->start_time !=
> AV_NOPTS_VALUE) ? ifile->start_time : 0;
> + abs_start_seek = is->start_time + ((ifile->start_time
> != AV_NOPTS_VALUE) ? ifile->start_time : 0);
> ifile->ts_offset = abs_start_seek > new_start_time ?
> -abs_start_seek : -new_start_time;
> } else if (copy_ts)
> ifile->ts_offset = 0;
> --
> 2.31.1
>
LGTM. Although the parentheses around (ifile->start_tile !=
AV_NOPTS_VALUE) can be removed as well.
- Leo Izen (Traneptora / thebombzen)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-05-12 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 10:56 Helge Klein
2023-05-12 16:30 ` Leo Izen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=747d3f22-d46d-5158-6036-65330b984030@gmail.com \
--to=leo.izen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git