Re: [FFmpeg-devel] [PATCH 1/3] avcodec/packet: add a define for the max buffer size a packet can hold

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/packet: add a define for the max buffer size a packet can hold
Date: Tue, 27 Jun 2023 11:39:59 -0300
Message-ID: <74254cdc-8dbe-32b8-233b-2fedee42e015@gmail.com> (raw)
In-Reply-To: <168785063341.21886.2360613165477893417@lain.khirnov.net>

On 6/27/2023 4:23 AM, Anton Khirnov wrote:
> Quoting James Almer (2023-06-21 22:46:56)
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> TODO: Version bump and APIchanges entry.
>>
>>   libavcodec/packet.h | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/libavcodec/packet.h b/libavcodec/packet.h
>> index f28e7e7011..f7dd687c23 100644
>> --- a/libavcodec/packet.h
>> +++ b/libavcodec/packet.h
>> @@ -418,6 +418,11 @@ typedef struct AVPacket {
>>       AVRational time_base;
>>   } AVPacket;
>>   
>> +/**
>> + * Max size for an AVPacket data buffer.
>> + */
>> +#define AV_PKT_MAX_PAYLOAD_SIZE ((size_t)(INT_MAX - AV_INPUT_BUFFER_PADDING_SIZE))
> 
> Maybe just AV_PKT_SIZE_MAX to be consistent with other FOO_MAX in C?
> 
> Otherwise the set seems like a good idea.

Will apply with that change then. Thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".