From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D8DA9492EF for ; Fri, 8 Mar 2024 13:13:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B38D968CF40; Fri, 8 Mar 2024 15:13:37 +0200 (EET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 179F468C5A4 for ; Fri, 8 Mar 2024 15:13:31 +0200 (EET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1dc3b4b9b62so14107555ad.1 for ; Fri, 08 Mar 2024 05:13:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709903608; x=1710508408; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FuRfcsundJv3b6iQoGEU3XkCR6T7vcgpggcxAz7kQac=; b=gKwJdhxF7PlemWh+7B1sxqOMx5iFp0uiN7PdtELonc65+tzvSL3BMYUqOGG8rXuOEj FakfkUYChLvRYqv9fhPjdO8t+1wd5FhhFFrQeAxrwVA8L8N9UPQT9QLsUvWIPjYv9xNT sKllimL7M/e2SLLdHzsfpHDOqXQWpatyMqO7I2x85SESOXuA7LnmlPOMYW/6fElivr+8 A5Hd4RxwFf4qhzgKa30zCN0Q26S/wUsX1AxlJlXD6HCoiUpxwk8+MRhBZxgNoODfP9LU NQ5vgMN7vzuDkBGTPkuxgcXxFyUlCe/UF18Z5T79hUoaa3/f5wRWisJwB6/J4dJOSrWk +Y2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709903608; x=1710508408; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FuRfcsundJv3b6iQoGEU3XkCR6T7vcgpggcxAz7kQac=; b=Tq16hReyoZ5xqTLDhfSzTMHamOpFjzMOQODOQgBXCWcSZ2lMhYFAIhsMeFufosoPwP nl/s+k6FBanYqPrPQq8qHcpPC75f3wT0XDhWlR6FhSI5Ph2TfM3AErMCDkmUkZIC1HgK kVA1G7h3GROYIlx/FytAcVcT1iE4LBNKy5zgd7CTPU1tZ9PuGfRpp+Z+lJv5VKZ7qMtS FpLZADwLB3xYoiCBfsyntqOW+Q3FDYM5+0fP4ckWUZEc68uuPpZ+PEDwnaQsumWYWj76 09DyM/GuVqgqCJX6g1wy5u/LdnvM6p+wqlu9fMWdqf3pAW9RYGoVeMKP1gZwc4XXdfUu kwdQ== X-Gm-Message-State: AOJu0Yykx00AhJznNGz1CDlhVuNc4n292gdxOLPeByW+Kk/9A08Zu1oi bstXBqLVGBq/9CgcM3VTjk+ihaSZJFkwB0Xi7Wf4GTSVKmgNiylR13Yt088H X-Google-Smtp-Source: AGHT+IF1ed9Q7ZYPJFLnc/N+0UHTb08RwNzI9XUgw7gXwRgOuYqAIoPVICxqbFkxqMq1nqSfwI/mgg== X-Received: by 2002:a17:902:e951:b0:1db:ccd7:5249 with SMTP id b17-20020a170902e95100b001dbccd75249mr236280pll.34.1709903608238; Fri, 08 Mar 2024 05:13:28 -0800 (PST) Received: from [192.168.0.14] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id k17-20020a170902c41100b001dd5cdaaa0fsm2423733plk.250.2024.03.08.05.13.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Mar 2024 05:13:27 -0800 (PST) Message-ID: <73a7e221-3aa4-4157-b6ba-65239d9cd99b@gmail.com> Date: Fri, 8 Mar 2024 10:13:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240308094928.62556-1-lq@chinaffmpeg.org> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: decode extradata in aom_init X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/8/2024 10:07 AM, Andreas Rheinhardt wrote: > Steven Liu: >> before patch: >> test failed when using libaomdec. >> TEST enhanced-flv-av1 >> --- src/tests/ref/fate/enhanced-flv-av1 2024-03-08 11:27:13.577935587 +0800 >> +++ tests/data/fate/enhanced-flv-av1 2024-03-08 17:38:25.810152322 +0800 >> @@ -3,7 +3,7 @@ >> #media_type 0: video >> #codec_id 0: av1 >> #dimensions 0: 320x176 >> -#sar 0: 0/1 >> +#sar 0: 1/1 >> 0, 0, 0, 41, 4718, 0xc4d912ec >> 0, 42, 42, 41, 5109, 0xc065dd7d, F=0x0 >> 0, 83, 83, 41, 192, 0x160c5335, F=0x0 >> >> after patch: >> test passed >> >> Signed-off-by: Steven Liu >> --- >> libavcodec/libaomdec.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c >> index 69eec8b089..2df2fa6fd7 100644 >> --- a/libavcodec/libaomdec.c >> +++ b/libavcodec/libaomdec.c >> @@ -58,6 +58,18 @@ static av_cold int aom_init(AVCodecContext *avctx, >> return AVERROR(EINVAL); >> } >> >> + if (aom_codec_decode(&ctx->decoder, avctx->extradata, avctx->extradata_size, >> + NULL) != AOM_CODEC_OK) { >> + const char *error = aom_codec_error(&ctx->decoder); >> + const char *detail = aom_codec_error_detail(&ctx->decoder); >> + >> + av_log(avctx, AV_LOG_ERROR, "Failed to decode extradata: %s\n", error); >> + if (detail) >> + av_log(avctx, AV_LOG_ERROR, " Additional information: %s\n", detail); >> + >> + return AVERROR(EINVAL); >> + } >> + >> return 0; >> } >> > > This patch is very problematic: If you change the ref file to match > libaomdec, it will be broken for those that use other decoders than > libaomdec. Actually, there should be no reason to use libaomdec for > probing since 194414f62d987ad831654c45fff6ee27898b832e. Maybe we should > add the AVOID_PROBING cap to the other AV1 decoders in case the native > one is available? Or add -c:v av1 as input argument for the final decode in stream_remux() from fate-run.sh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".