From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A5ABA5026D for ; Thu, 10 Jul 2025 10:05:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1F09268FA97; Thu, 10 Jul 2025 13:05:11 +0300 (EEST) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2541268FB1F for ; Thu, 10 Jul 2025 13:05:04 +0300 (EEST) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ae0c571f137so150888766b.0 for ; Thu, 10 Jul 2025 03:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752141903; x=1752746703; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=JWuBcLj8c9TYzZqrahlW4o8YWO/mpSv1VaTSViKf55A=; b=dzcLCb/eFIUfm/TVFMHHf6ms0g/Ie6HHPBiLUygk83TYn8OciJGeC13HqMEpKoEINx LydQG7lO1jSeLguPcRpqVEgLiSUTvkCORSbDfMtH0hkxAzW3IW0rWudxXVJ87a5vSroG leTv1wa8Adl2pDzn+lYLPngIhLAt7Or+Ass7juHlFaRJXei/dTNAHbViK5mbn57OL36O AVuR3kptXEDobAMg/VPre7jSBd/n+H3BLQ106lJC/FI7YH+/J51F54SThQ17UTOB0/wB 8/NRHPf2CV5R68TROHUy3GSyFpOL3EQMNYYxoN7cs6xPabnHLuuXhubrKVs/ZV7gSjpH 1h8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752141903; x=1752746703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JWuBcLj8c9TYzZqrahlW4o8YWO/mpSv1VaTSViKf55A=; b=iT0Oz6nDhI9sCz5xuKm9x08SMtlhB/P6zWDHKe+S+hN5BoDqTKbss0ZgVwdfUm2HH+ diIOTDQp7RxlBsDEShDaS3BhJrJ94B+3XyyRUPS4/Afg9t8RZmxS0TKFXsuVLQYfOXY+ zdYhhFQp0ddcGQ9Zk0AEAK1A0rBmpSR3ADLlY1N0zJfvmaLuSBkDJVILfgbwYolFchby PwuHV+G6UKQi/liItQaVWzGveLXI9lunTW8OcYhYlU55LizsK0QLzu5NZYPjsy0sATme NP3qjmqHHBeBaxxJEmrNXtap3YGG2ziSI5486zc40Qxps2J4NLSVvWYd0d1myrYy5iPC /quQ== X-Gm-Message-State: AOJu0YzwWa7LM69G6waaVHDuIW7YUD7q7eaZxOEB4zrGQhHZU3NvdQvV pNujsYjLa31nhYR226HcXAVRUEH/FgYYomr8LVeVFSToc+w/EuG7KHftyOQUZA== X-Gm-Gg: ASbGnctAdmYNYuqmm+VA9ZchkbRQYIAeVC7G9u6rbHgIWmFzpuxSUUaKwkIjAUnKF6o 9X1DtZrIdZH5sgxn3NQtFsKtzTjU2IB3qemUrFAtXrr0Bg2diADXyZ1G3CPQxdswcMw2TxGTQ5J BBer/WPdhhKW9eucR/dimcc0YOEFT4rAw0t53lhaddWjnLikBTVxSiP51liGEWZ/km5rdgfm5IZ gJZJPtS/Ma4dzkwUWZqFMs6gVAqQV5BWbhWk1nTmIwJ0bqbGWiz+Glictrvei0605W7bs9dHQvE Hj70xfcnzA7lTAVLo7ygyKcZDxz3icIc4wR2SUcDjBILbh1m+tmacxwiokIHbFa3soaj3k802Fa 03sZbERMUXXbY5FuutmIynYu23IqA2D/EZ7L4wGgtbzBlgqCFhBHbzpkJ4OcB9rk1GQxWvcIeCC DMSl+hDe2jjRA= X-Google-Smtp-Source: AGHT+IFDzLHIL1gd9tjTOhELLnzGggte5WEIj0F4PuHkWtYdm08C/YqiHnD5eSUWZiYG/ES4eGR5Kw== X-Received: by 2002:a17:907:7f89:b0:ae3:d021:9b05 with SMTP id a640c23a62f3a-ae6cf5bc281mr657815966b.15.1752141902842; Thu, 10 Jul 2025 03:05:02 -0700 (PDT) Received: from [192.168.178.143] (p200301023701fa00fcc0f1dec54647e5.dip0.t-ipconnect.de. [2003:102:3701:fa00:fcc0:f1de:c546:47e5]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e826469asm101748466b.85.2025.07.10.03.05.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Jul 2025 03:05:02 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Thu, 10 Jul 2025 12:05:01 +0200 X-Mailer: MailMate Free Mode (2.0r6222) Message-ID: <73D548FE-67B7-4A31-9BD8-E1CD713987D6@gmail.com> In-Reply-To: References: <20250709072350.578693-1-vpalmisano@gmail.com> <20250709233746.GM29660@pb2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] Whisper audio filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10 Jul 2025, at 10:34, Vittorio Palmisano wrote: > Thanks Michael, I will try to answer your comments. > >>> +ffmpeg -i input.mp4 -vn -af "aformat=sample_rates=16000:channel_layouts=mono,whisper= >> >> Is there a reason why we convert to 16khz mono here ? > > It is the only format supported by the whisper.cpp library. > >>> +model=../whisper.cpp/models/ggml-base.en.bin\ >> >> It would be nice if the models would be in a standard location, so teh user >> just has to specify the model name and not the path > > I think that this functionality should be implemented inside the > whisper.cpp library, so they can manage the exact model location and > the download process. I will propose a change. > >> I tried this: >> >> ./ffmpeg -i matrixbench_mpeg2.mpg -vn -af "aformat=sample_rates=16000:channel_layouts=mono,whisper=model=/home/michael/whisper.cpp/models/ggml-base.en.bin:language=en:queue=3000:destination=output.srt:format=srt" -f null - >> >> but the output.srt is empty (0 bytes) > > Can you enable verbose logging? > >> libavfilter/af_whisper.c:75:49: error: parameter name omitted >> 75 | static void cb_log_disable(enum ggml_log_level, const char *, void *) {} >> | ^~~~~~~~~~~~ >> libavfilter/af_whisper.c:75:63: > > I don't see this error using the gcc13 compiler. Do you use a > different compiler or some other flags? > Leaving out parameter names is a C++ thing, its not allowed in C. >>> + wctx->audio_buffer_fill_size = 0; >>> + >>> + wctx->next_pts = AV_NOPTS_VALUE; >>> + >>> + wctx->avio_context = NULL; >> >> arent things already initialized to 0 ? > > Yes, maybe we can keep the AV_NOPTS_VALUE assignment (it is not zero). > > -- > /Vittorio Palmisano/ > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".