From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0967C40817 for ; Sat, 2 Apr 2022 08:52:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7AB2168B1FA; Sat, 2 Apr 2022 11:52:27 +0300 (EEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 727A468B093 for ; Sat, 2 Apr 2022 11:52:20 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648889545; x=1680425545; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=Oh+V1zKVseEpqrwZqm5hUKWHDfgtWyucIY9seMBMOK4=; b=P1TJcs00B8bXrFz53O8EqFnKmu0bM2CclNSbMmhKH6HlN6dORlN83w7B 8lVPkxAzIF7btEmGa21D+RYpPHh0I4ClhFag9srQ7OOuDI6jMYSIqf2w2 abWX6BAnr3gOK8KuWbYZPIV2FSyZAfXUrioI4sd1KuZHwkM1Ako2pB293 qgSalrxBM3ZS86eRUsoHcNKuT5ShoCgWFNONxCTYWkuL3Bo+pbS547/qA 8zv2Ro6CkifJbaSRc5GLjHu+4mKhlAfwqjaMPneT/szAnyPpJ8mfkY1zn 2qfB9oGo/AMzAR5/YrkWrFtQdOjsElinmOwiVls0PHSdM8IfccBh70Ywp w==; X-IronPort-AV: E=McAfee;i="6200,9189,10304"; a="260276078" X-IronPort-AV: E=Sophos;i="5.90,229,1643702400"; d="scan'208";a="260276078" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2022 01:52:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,229,1643702400"; d="scan'208";a="845628016" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 02 Apr 2022 01:52:16 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 2 Apr 2022 01:52:16 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 2 Apr 2022 01:52:15 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sat, 2 Apr 2022 01:52:15 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sat, 2 Apr 2022 01:52:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KVb0+GxptvHAvcDpP9xY8sULxl1ojyuPwE38SiF2urkWufXrQJWY6m20VOVu2ySlVkdKgqsAXuOvXSQBMqxV4gxSanKM60VIIA5eco2QL5cavH+BH365Ipm03ILQREjpvhbf0aS8H7/I3v0NhMwyuRfWc17rLlUdh20n0mrKg+VQpBLSEVIjge21gzkx4Y8kqK7N6mIngfkFSBE9XDjK2p9UOQcHxyB/L0aJ7DHL/9dBgM1MWXxb3MZg0JXkXMdbHvdTGPntHR2WNoNtuOYkxsmMtZn7wib5+kMn3grQQyPal4F7ofIn9ufrKXC2i4Mx/486YRginKX/TDaMmLOZtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oh+V1zKVseEpqrwZqm5hUKWHDfgtWyucIY9seMBMOK4=; b=HYBkAsKm71+FBIAKRxMS5AV7VOQG1mebYqBlGm37+kJ4ZahCMS6grsJKiGjmhurhFPzSDijObGTHoGEhfvgfVIJtwXVlf7WVPSnooMpNyOxSCaVIHknJjnCh/scnO3xv2TyRoDmfoaGSuMLf9dj2aHp1UTLiKAOySk53L8JcMdfHTmDM82fBtAYSsvr0lmn1gm5MuOvoU5Xv2upWY536v3wdsTeUJccYWtliiK/5B3rlKhv8KrHOsKqeB7bHQcwhmQ4+2m0Amx/bfirV975eDBfMPDnDv6pncVnRJwjO8McxQKtsqBGP4H9IH8qoq6daOF5CTEx/4LmFX91W2Y2mUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MN2PR11MB4093.namprd11.prod.outlook.com (2603:10b6:208:13f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.23; Sat, 2 Apr 2022 08:52:13 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::c0b8:e06a:3d29:da25]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::c0b8:e06a:3d29:da25%5]) with mapi id 15.20.5123.030; Sat, 2 Apr 2022 08:52:13 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2 3/3] libavcodec/qsvdec: using suggested num to set init_pool_size Thread-Index: AQHYOpEcm1jg5zkYQEeAelY1P1CQRqzEwbgAgA9fhICACEeEAA== Date: Sat, 2 Apr 2022 08:52:13 +0000 Message-ID: <72913a067c2ee51247e2086020402f0676ab72b3.camel@intel.com> References: <20220318062511.382951-1-wenbin.chen@intel.com> <20220318062511.382951-3-wenbin.chen@intel.com> <57a8a823dd8f53dec096f5747a552d88b20b5b77.camel@intel.com> In-Reply-To: <57a8a823dd8f53dec096f5747a552d88b20b5b77.camel@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 01b4bc80-da63-4931-3c96-08da14861518 x-ms-traffictypediagnostic: MN2PR11MB4093:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W+2FPx51zGdldz/cGoPPGtqnQ6xZk72IG4KaZAPXmp0E46/u5eRQnyQVcYZHcxnMgfknvje7dT/grInPYaTAZOfIcYhQK/Y3Gwdmi18J3dkfaeS5F8v/EXlwulIWMKEDaDny79XPFOJOFYpTPQCJKfcaTN88BhBYpE10rsqxtdz8Kctw8CGQ+UKXwfk48LTrG4ITzyGTNWsbQKwi976k3GI44owx5G2X9ZXiPqrAnj5CpcqGONDmf1OaszTrO7tm3R4u2XudHlA+NdpDsqzRwRob2mrakaFYrWGazJEfWeJ6tFY47ajv7tXooIiZAiW4ErLBgqYxvsQIPhTtfN9LsnUy2+GqdOu6p7EcQcQB8XzYQW61AFWt5YKSAK2R02Xmly1jh0f7i9goUt86xItf3jzD1nyERv9SOS2RKbFQS17GTWyxzwsZON2MrmMlcQY8fzYk6FhmBkbknbSgakBKZSoJyol+xcvFYQs6KsALZRv6CXc7gMjrM44/8CTrqxuQ6U0LGAK4oPGpaJCU2TOBeEzCsngo0kgu6L6SGRQWcjFM3eLC5wL00u0O15IjS36nolkYjNCaT7uLPtdZkmdzKTtDoYt/yh//tfHOISmhIIyO5103zawo+f+tJ47Oh3twfcle/SMMzDXlGESytb8o5D9jNk5XEPDs0JSgD9GDy281q243iehkssLBEH4jB56IT2DNlVxhqS9hjO9knTAVvTsa0Fv2Z1SPjddckE01ztY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(36756003)(316002)(186003)(26005)(6486002)(86362001)(83380400001)(6916009)(38070700005)(2906002)(71200400001)(76116006)(6506007)(8676002)(64756008)(66556008)(66446008)(5660300002)(508600001)(53546011)(66946007)(66476007)(8936002)(6512007)(91956017)(122000001)(38100700002)(82960400001)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dWYxTTVKS2ZNTVl0TlNjRENDaGdyZFRWWG4wRSswOFBWcjUyNUZoWDc4WWtC?= =?utf-8?B?YVFOWFJmdVh0SFhzZkZvL2JQbWRrSjJpL2hUTkQ0S1M0YmtoUFZlM0xxZzRY?= =?utf-8?B?ZlZqc2hLajdLdGhFVkUvelFpSU82ZXNKMksvK296RnJSQTVraWsyTUxYUkdD?= =?utf-8?B?U2lqanZ6K3NQQ0RZNEkyTmg2dzRENGNPK0FlR01LRkU5ZDZpdXh2dUIrQTlJ?= =?utf-8?B?TlBPY29BUkJGa2lpdkJVZEluRmVrVGhxQXc2NytCdU5FNGROWXROSGhrQ3h2?= =?utf-8?B?blEvQ0orakY2dmRsT1dlNFVXK2hSTlB3SEM5OUplQTJBc0d2dFkrRmZUTjhT?= =?utf-8?B?L05ReFNDRElFVGRxQ2FHNWhDS3RwS3FZMVpMOHdrREM5LzhZNkt3VzY0R0Jq?= =?utf-8?B?c2RBYkxOTThkN3VzR01oTVZSQWYrTG9qTHc0cWttOFhOUWpkRGtmZTZ0U3NU?= =?utf-8?B?Q1BqSzkvMmUzMitBNW5FbmdSTmlQLzZPQnlqNzZBcE1jcmhVbEZmZzJad2pW?= =?utf-8?B?dkJBcy9RcTZkcXNEK3hKSnY4NHVSRTZvYnFLY0hMNUZURmNVRWtxRXVBcm02?= =?utf-8?B?QVZ5STBYVHJITTRXYzl0RkdKdGZ2c2dwZ1dxZktDeXQ5alhaUEdBNXN3cG5E?= =?utf-8?B?d1FrWks3R1F4UTc4Tm1obURFczFQVVFGQm5sbDEwa3BSOWE4WTY3QW9acGFE?= =?utf-8?B?MlFVallUc2xBaHdHamNNbklFS1dDcUIybWcwNEYzN3Jsc3ZldXA0WnphcDRR?= =?utf-8?B?eHVucjFXbWxiU1ptVU1Na1MvWW15UjdyNG00UGtoUHp5bDJNazZLS2oveVRE?= =?utf-8?B?R0lCWkZGL1gzNTN0WVhqeWIwaGlNVnMrNEJEdytMbzBmMUdRY0s4dERob2Zj?= =?utf-8?B?b1BDdExpa3VoT0x6YThaQVdUNnBNNjBZNXVleXlFaVFHZ2dmYUg4dmhXMWZv?= =?utf-8?B?b3FBdG5rR1FCdkFhVVFXdDFCYTlnZDV0R2tLNFZBK1dxQVFCSlVqbTNmYk0x?= =?utf-8?B?ZjNQRDdycVBrZTBLQWc4N09TVVh1dkRXUkU4N1Jsb2NCa2F6UUxuT1NiWGJJ?= =?utf-8?B?MU1GcjNMaDY3NTVLaUtIQk5CdCtySm5SY0ZYNFByYk9Lc1h6T3Q5MlFoalRr?= =?utf-8?B?dzBHWUNsZ3RzdDlsVFJObG9PQVI0eFlWMU9adW8zVEcrZkRtOS9HS2hGc2Z4?= =?utf-8?B?L3cwcHRCM0VaN3NmTmo4Y2hBaFEzYjRRcWlZd214V2NjYU1xUFNSUmFMVmkv?= =?utf-8?B?aXRwUzgrMU9mVWNkckJVeXU4Szd4YTFIVytrM3Z4Y01JY3E0YUVHWVB1WGVv?= =?utf-8?B?Z05ScFVOSFJzZVRxQ0N6ak5FQzFrQVRKNjNaclRsWjh2Z21XaTIwcU5FcUtP?= =?utf-8?B?Y1lBY09SRnA1Z2lER044bUlPb2tWa29yN1hzOGRoUjRFREdXZEZPQjYwOTlP?= =?utf-8?B?c3gyd3N5bUxCNFUzZkRBVEFEcGZIdWhjV09SVVpDUVg1cG8wU3ROZSt6OTh5?= =?utf-8?B?WUFxRjFzUDI4WjlmTm9jRlZFVFNXcDZQRjE2R0Yyb2M3WVFpZFp4ZXQ0Z25Q?= =?utf-8?B?QVM2cWdDaWEvMFE5eXpicTBETXpvdmpER1FrWDBGK3NKNmRKZitDcWRGZDEz?= =?utf-8?B?TUEzYS9DWEIvSDI1YjY1azdBRW8yMEp3dDF1WFBRd2ZiU2VDYTZHMnFtVW5i?= =?utf-8?B?bXprbk9HdnlvdWRLNG1DKzg2b2lOQktLMFBDMHl5NDR6dElkVFd4VkUwamw1?= =?utf-8?B?NXpORVFOUGx3M3pMV2ExQ3c0ZXhEcjlCeGx0RUVVa1dBeXY1b0taK0ErTHgy?= =?utf-8?B?d3pJU0VXUkdSL01GM01EVWNjQ0p0QlNoMnpwbjBhbjZ0Wk9nNDg3VXZCVG82?= =?utf-8?B?U2R6OTJIbkpTb09hT00vc0ZEdnVOakFoeGtLdDFsbGZ1WFYwSVJ5VmR5U2hH?= =?utf-8?B?Kzdrd1Vac2lJK0tnbnFrbW5DSS9McDlmTlVISFVOUzdGNFVXdFdsclNId1hj?= =?utf-8?B?VnpGaFBJNUIwWkMrNTF0NVFzY0ZWd1RVSHpxeUVmb3RRc1liOEZCZFBhWHZF?= =?utf-8?B?YzU1VGtMY1dwbUJrd0ZxeGcwWkxrVTNNSmpjZldocENKeXBBeXVqdllKc3E4?= =?utf-8?B?R1lLRGtOM0ZhNHYvSzZ2MVZtbzdmd0NiaDBKNUN3eGtUUzVPUTFweFV3MlhG?= =?utf-8?B?S3BhR3JSb2F4Vmx1ejZhclM4NWdVaTVUSVJnbUUzV1FvWVE1OWt1eUxnY1Ny?= =?utf-8?B?VHJ5ZUVzdlVUOGlhOUo4eFBONGl0R0FoQ1I1ZzRPU1VlbXdLU0xhUWpMNXJq?= =?utf-8?B?MXptZ0s4eUJFTEE0Vlk3YkdRZUZCY0hpWGdqdmdDU3A2dHBjcVBCNTlqVUI4?= =?utf-8?Q?H4Xi8cEkGhL0QL6E=3D?= Content-ID: <16F0B3034812B94196D32F1AB4220309@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01b4bc80-da63-4931-3c96-08da14861518 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2022 08:52:13.6230 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v6ip/0Fda9MDqs2eHEDV468Dc1aZYV6yQEpA99G9dKFZF4YE6mlRr/DL9KztAdZd/ntroBNCyyPKfAdZXDjFCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4093 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 3/3] libavcodec/qsvdec: using suggested num to set init_pool_size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-03-28 at 02:26 +0000, Xiang, Haihao wrote: > On Fri, 2022-03-18 at 07:40 +0000, Soft Works wrote: > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of > > > Wenbin Chen > > > Sent: Friday, March 18, 2022 7:25 AM > > > To: ffmpeg-devel@ffmpeg.org > > > Subject: [FFmpeg-devel] [PATCH v2 3/3] libavcodec/qsvdec: using > > > suggested num to set init_pool_size > > > > > > The init_pool_size is set to be 64 and it is too many. > > > Use IOSurfQuery to get NumFrameSuggest which is the suggested > > > number of frame that needed to be allocated when initializing the > > > decoder. > > > Considering that the hevc_qsv encoder uses the most frame buffer, > > > async is 4 (default) and max_b_frames is 8 (default) and decoder > > > may followed by VPP, use NumFrameSuggest + 16 to set init_pool_size. > > > > > > Signed-off-by: Wenbin Chen > > > Signed-off-by: Guangxin Xu > > > --- > > > libavcodec/qsvdec.c | 14 ++++++++++++-- > > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > > > diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c > > > index 210bd0c1d5..9875d3d632 100644 > > > --- a/libavcodec/qsvdec.c > > > +++ b/libavcodec/qsvdec.c > > > @@ -88,7 +88,7 @@ typedef struct QSVContext { > > > uint32_t fourcc; > > > mfxFrameInfo frame_info; > > > AVBufferPool *pool; > > > - > > > + int suggest_pool_size; > > > int initialized; > > > > > > // options set by the caller > > > @@ -275,7 +275,7 @@ static int qsv_decode_preinit(AVCodecContext > > > *avctx, QSVContext *q, enum AVPixel > > > hwframes_ctx->height = FFALIGN(avctx- > > > > coded_height, 32); > > > > > > hwframes_ctx->format = AV_PIX_FMT_QSV; > > > hwframes_ctx->sw_format = avctx->sw_pix_fmt; > > > - hwframes_ctx->initial_pool_size = 64 + avctx- > > > > extra_hw_frames; > > > > > > + hwframes_ctx->initial_pool_size = q->suggest_pool_size + 16 + > > > avctx->extra_hw_frames; > > > frames_hwctx->frame_type = > > > MFX_MEMTYPE_VIDEO_MEMORY_DECODER_TARGET; > > > > > > ret = av_hwframe_ctx_init(avctx->hw_frames_ctx); > > > @@ -793,6 +793,9 @@ static int qsv_process_data(AVCodecContext *avctx, > > > QSVContext *q, > > > } > > > > > > if (q->reinit_flag || !q->session || !q->initialized) { > > > + mfxFrameAllocRequest request; > > > + memset(&request, 0, sizeof(request)); > > > + > > > q->reinit_flag = 0; > > > ret = qsv_decode_header(avctx, q, pkt, pix_fmt, ¶m); > > > if (ret < 0) { > > > @@ -802,12 +805,19 @@ static int qsv_process_data(AVCodecContext > > > *avctx, QSVContext *q, > > > av_log(avctx, AV_LOG_ERROR, "Error decoding > > > header\n"); > > > goto reinit_fail; > > > } > > > + param.IOPattern = q->iopattern; > > > > > > q->orig_pix_fmt = avctx->pix_fmt = pix_fmt = > > > ff_qsv_map_fourcc(param.mfx.FrameInfo.FourCC); > > > > > > avctx->coded_width = param.mfx.FrameInfo.Width; > > > avctx->coded_height = param.mfx.FrameInfo.Height; > > > > > > + ret = MFXVideoDECODE_QueryIOSurf(q->session, ¶m, > > > &request); > > > + if (ret < 0) > > > + return ff_qsv_print_error(avctx, ret, "Error querying IO > > > surface"); > > > + > > > + q->suggest_pool_size = request.NumFrameSuggested; > > > + > > > ret = qsv_decode_preinit(avctx, q, pix_fmt, ¶m); > > > if (ret < 0) > > > goto reinit_fail; > > > -- > > > > Thanks for the patch! I have that on my list for quite a while. > > Will look at it shortly. > > Hi Softworz, > > This patchset LGTM and works well, do you have any comment ? Ping, I'll apply this patchset in a few days if no more comment. Regards Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".