Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH v3 2/2] doc/examples/transcode_aac: Set decoder packet timebase
@ 2022-04-27 13:35 Andreas Unterweger
  2022-04-27 13:40 ` Andreas Unterweger
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Unterweger @ 2022-04-27 13:35 UTC (permalink / raw)
  To: ffmpeg-devel

Previously, the default timebase caused two warnings during decoding 
about not being able to update timestamps for skipped and discarded 
samples, respectively.

Signed-off-by: Andreas Unterweger <dustsigns@gmail.com>
---
  doc/examples/transcode_aac.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c
index c9b93f6439..6197369756 100644
--- a/doc/examples/transcode_aac.c
+++ b/doc/examples/transcode_aac.c
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2013-2018 Andreas Unterweger
+ * Copyright (c) 2013-2022 Andreas Unterweger
   *
   * This file is part of FFmpeg.
   *
@@ -120,6 +120,10 @@ static int open_input_file(const char *filename,
          avformat_close_input(input_format_context);
          return error;
      }
+    +    /* Set the packet timebase for the decoder. The input file's 
sample
+     * rate is used as the denominator for simplicity. */
+    avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate };
       /* Save the decoder context for easier access later. */
      *input_codec_context = avctx;
-- 
2.30.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 2/2] doc/examples/transcode_aac: Set decoder packet timebase
  2022-04-27 13:35 [FFmpeg-devel] [PATCH v3 2/2] doc/examples/transcode_aac: Set decoder packet timebase Andreas Unterweger
@ 2022-04-27 13:40 ` Andreas Unterweger
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Unterweger @ 2022-04-27 13:40 UTC (permalink / raw)
  To: ffmpeg-devel

Am 27.04.2022 um 15:35 schrieb Andreas Unterweger:
> Previously, the default timebase caused two warnings during decoding 
> about not being able to update timestamps for skipped and discarded 
> samples, respectively.
> 
> Signed-off-by: Andreas Unterweger <dustsigns@gmail.com>
> ---
>   doc/examples/transcode_aac.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c
> index c9b93f6439..6197369756 100644
> --- a/doc/examples/transcode_aac.c
> +++ b/doc/examples/transcode_aac.c
> @@ -1,5 +1,5 @@
>   /*
> - * Copyright (c) 2013-2018 Andreas Unterweger
> + * Copyright (c) 2013-2022 Andreas Unterweger
>    *
>    * This file is part of FFmpeg.
>    *
> @@ -120,6 +120,10 @@ static int open_input_file(const char *filename,
>           avformat_close_input(input_format_context);
>           return error;
>       }
> +    +    /* Set the packet timebase for the decoder. The input file's 
> sample
> +     * rate is used as the denominator for simplicity. */
> +    avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate };
>        /* Save the decoder context for easier access later. */
>       *input_codec_context = avctx;

I rebased the patch another one time onto the current master. Please apply.

Best,
Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-27 13:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 13:35 [FFmpeg-devel] [PATCH v3 2/2] doc/examples/transcode_aac: Set decoder packet timebase Andreas Unterweger
2022-04-27 13:40 ` Andreas Unterweger

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git