Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: replace deprecated AVCaptureDevice - Thilo Borgmann via ffmpeg-devel

From: Thilo Borgmann via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Thilo Borgmann <thilo.borgmann@mail.de>
Subject: Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: replace deprecated AVCaptureDevice
Date: Wed, 6 Dec 2023 18:39:19 +0100
Message-ID: <7242fb6d-4414-425e-aee9-9ca7a0475749@mail.de> (raw)
In-Reply-To: <tencent_8C5970CC6C8D3CF6E55E2183ECBE186CC607@qq.com>

Am 06.12.23 um 13:03 schrieb xufuji456 via ffmpeg-devel:
> Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead"
> 
> Signed-off-by: xufuji456 <839789740@qq.com>
> ---
>   libavdevice/avfoundation.m | 23 ++++++++++++++++++-----
>   1 file changed, 18 insertions(+), 5 deletions(-)
> 
> diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
> index 36ad834753..5ebfe89dca 100644
> --- a/libavdevice/avfoundation.m
> +++ b/libavdevice/avfoundation.m
> @@ -761,6 +761,19 @@ static int get_audio_config(AVFormatContext *s)
>       return 0;
>   }
>   
> +static NSArray* getDevicesWithMediaType(AVMediaType mediaType) {
> +#if ((TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MAX_ALLOWED >= 100000) || (TARGET_OS_OSX && __MAC_OS_X_VERSION_MAX_ALLOWED >= 101500))
> +    AVCaptureDeviceDiscoverySession *captureDeviceDiscoverySession =
> +        [AVCaptureDeviceDiscoverySession

> +        discoverySessionWithDeviceTypes:@[AVCaptureDeviceTypeBuiltInWideAngleCamera]

deviceTypes should be an array of all possible types or we risk loosing currently detected hardware.

Otherwise, LGTM.

-Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".