From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5A95F4923D for ; Thu, 7 Mar 2024 17:53:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A772868CBCB; Thu, 7 Mar 2024 19:53:06 +0200 (EET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E6ACE68B22E for ; Thu, 7 Mar 2024 19:53:00 +0200 (EET) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so1039155a12.1 for ; Thu, 07 Mar 2024 09:53:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709833978; x=1710438778; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IIDBfOUmOMu5uDc0+iHKQKu5Udur61w2Ky696eHxcLw=; b=ir3hQ33D9b1uC+vm3BZNpO0F9C0G2Z37x9IFnf298ZcgMUMi62MSaseYSw+Zm4qLC+ O1auILOVQl/KTQ7onIm0/Aa8Dvu3WF45eafapsXZa5KyRmG3w99L+oNHimmlGPEI94GS vWGuqC4U1GJg8rGqY0NoSRBRsSdnqj7DxaOeoThkmgap36h1IHaS9ymGhciUcTNxomo4 yzvqg8nJpo4MoQkXUAJjIQzkid7SkzFdEFduopIIO1PB8j2ldgrWnmEo9/Rvn/e71OtE 5lxKwuRdIvz+pwu0lvR7CvLb0TYb6BR0nXl2LQuYDAS3hz0lluDdmVIKzuhD2pQfTFaX Sxjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709833978; x=1710438778; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IIDBfOUmOMu5uDc0+iHKQKu5Udur61w2Ky696eHxcLw=; b=EREcnDG3TUg7zF8vipa3pRS93XdSEgMFJuwRsQgmm37MX55SDwtBuyVxjOcxIfc6Ci DMXSyRznCbItPI12h671vGnsMU4SerFlnycZnVozpzdRpxB6PLAgaw4JKnQouP5LpvRn 3cJQjdMBWqGORRR6P7Uu4Z882HujPnMp1+qxsyvMzJDzlBewMjw8azn3zroWy7xKN9Ia omsubn+qOMh34+kZ/3pNKkUGIyRdywc4mCLQDplA0wLIHJZGa6Oe1hULOXpa+fe3PvzQ pUGUNVoTzzNKe0EyYXSgFuEGdRELsRNUeWHumy446s3d7vNsT5nofUA9SPEPT5Kagl1y bPJw== X-Gm-Message-State: AOJu0YzbsNvAHKiFANGTeatSD6Fl3+tPtLKGiAaECdeCfWqaPlhS9IoL CLuo1xe5xpqxeXJjcb7VQFvFPq3E58+89+tjJapG5AF/hjQRV56K6AW0qv6Y X-Google-Smtp-Source: AGHT+IE+q7XngK8EpGxMmJ5Uh2MAtbyQtfrnOHYVv7v30jCFpTDyfoNXZ5NmR6DSFzMzPQlwRF8qPw== X-Received: by 2002:a17:90b:3142:b0:29b:5062:50a0 with SMTP id ip2-20020a17090b314200b0029b506250a0mr11555969pjb.43.1709833978356; Thu, 07 Mar 2024 09:52:58 -0800 (PST) Received: from [192.168.0.14] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id d15-20020a170902654f00b001dd63f05c20sm218882pln.230.2024.03.07.09.52.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Mar 2024 09:52:57 -0800 (PST) Message-ID: <723e2571-acdb-4365-a883-415d2b97e8d7@gmail.com> Date: Thu, 7 Mar 2024 14:53:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240307004952.9417-1-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffprobe: export Tile Grid Stream Group parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/7/2024 1:46 PM, Stefano Sabatini wrote: > On date Thursday 2024-03-07 17:17:06 +0100, Stefano Sabatini wrote: >> On date Wednesday 2024-03-06 21:49:51 -0300, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> fftools/ffprobe.c | 53 ++++++++++++++++--- >>> tests/fate/mov.mak | 6 +-- >>> .../ref/fate/mov-heic-demux-still-image-grid | 29 ++++++++++ >>> .../ref/fate/mov-heic-demux-still-image-iovl | 19 +++++++ >>> .../fate/mov-heic-demux-still-image-iovl-2 | 19 +++++++ >>> 5 files changed, 115 insertions(+), 11 deletions(-) >>> >>> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c >>> index 4d4a85b5b0..c2ed8336f9 100644 >>> --- a/fftools/ffprobe.c >>> +++ b/fftools/ffprobe.c >>> @@ -113,6 +113,7 @@ static int do_show_frames = 0; >>> static int do_show_packets = 0; >>> static int do_show_programs = 0; >>> static int do_show_stream_groups = 0; >>> +static int do_show_stream_group_components = 0; >>> static int do_show_streams = 0; >>> static int do_show_stream_disposition = 0; >>> static int do_show_stream_group_disposition = 0; >>> @@ -209,6 +210,10 @@ typedef enum { >>> SECTION_ID_STREAM_GROUP_STREAM_DISPOSITION, >>> SECTION_ID_STREAM_GROUP_STREAM_TAGS, >>> SECTION_ID_STREAM_GROUP, >>> + SECTION_ID_STREAM_GROUP_COMPONENTS, >>> + SECTION_ID_STREAM_GROUP_COMPONENT, >>> + SECTION_ID_STREAM_GROUP_SUB_COMPONENTS, >>> + SECTION_ID_STREAM_GROUP_SUB_COMPONENT, >>> SECTION_ID_STREAM_GROUP_STREAMS, >>> SECTION_ID_STREAM_GROUP_STREAM, >>> SECTION_ID_STREAM_GROUP_DISPOSITION, >>> @@ -309,7 +314,11 @@ static struct section sections[] = { >>> [SECTION_ID_PROGRAMS] = { SECTION_ID_PROGRAMS, "programs", SECTION_FLAG_IS_ARRAY, { SECTION_ID_PROGRAM, -1 } }, >>> [SECTION_ID_STREAM_GROUP_STREAM_DISPOSITION] = { SECTION_ID_STREAM_GROUP_STREAM_DISPOSITION, "disposition", 0, { -1 }, .unique_name = "stream_group_stream_disposition" }, >>> [SECTION_ID_STREAM_GROUP_STREAM_TAGS] = { SECTION_ID_STREAM_GROUP_STREAM_TAGS, "tags", SECTION_FLAG_HAS_VARIABLE_FIELDS, { -1 }, .element_name = "tag", .unique_name = "stream_group_stream_tags" }, >>> - [SECTION_ID_STREAM_GROUP] = { SECTION_ID_STREAM_GROUP, "stream_group", SECTION_FLAG_HAS_TYPE, { SECTION_ID_STREAM_GROUP_TAGS, SECTION_ID_STREAM_GROUP_DISPOSITION, SECTION_ID_STREAM_GROUP_STREAMS, -1 }, .get_type = get_stream_group_type }, >>> + [SECTION_ID_STREAM_GROUP] = { SECTION_ID_STREAM_GROUP, "stream_group", 0, { SECTION_ID_STREAM_GROUP_TAGS, SECTION_ID_STREAM_GROUP_DISPOSITION, SECTION_ID_STREAM_GROUP_COMPONENTS, SECTION_ID_STREAM_GROUP_STREAMS, -1 } }, >>> + [SECTION_ID_STREAM_GROUP_COMPONENTS] = { SECTION_ID_STREAM_GROUP_COMPONENTS, "components", SECTION_FLAG_IS_ARRAY, { SECTION_ID_STREAM_GROUP_COMPONENT, -1 }, .element_name = "component", .unique_name = "stream_group_components" }, >>> + [SECTION_ID_STREAM_GROUP_COMPONENT] = { SECTION_ID_STREAM_GROUP_COMPONENT, "component", SECTION_FLAG_HAS_VARIABLE_FIELDS|SECTION_FLAG_HAS_TYPE, { SECTION_ID_STREAM_GROUP_SUB_COMPONENTS, -1 }, .unique_name = "stream_group_component", .element_name = "component_entry", .get_type = get_stream_group_type }, >> >>> + [SECTION_ID_STREAM_GROUP_SUB_COMPONENTS] = { SECTION_ID_STREAM_GROUP_SUB_COMPONENTS, "subcomponents", SECTION_FLAG_IS_ARRAY, { SECTION_ID_STREAM_GROUP_SUB_COMPONENT, -1 }, .element_name = "component" }, >>> + [SECTION_ID_STREAM_GROUP_SUB_COMPONENT] = { SECTION_ID_STREAM_GROUP_SUB_COMPONENT, "subcomponent", SECTION_FLAG_HAS_VARIABLE_FIELDS|SECTION_FLAG_HAS_TYPE, { -1 }, .element_name = "sub_component_entry", .get_type = get_raw_string_type }, >> >> consistency: subcomponent or sub_component (probably I'd go with >> SUBCOMPONENT/subcomponent everywhere). > > also, missing ffprobe.xsd update? Ok. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".