From: Thilo Borgmann <thilo.borgmann@mail.de>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avdevice/avfoundation: fix memleak
Date: Tue, 8 Feb 2022 13:47:47 +0100
Message-ID: <722ff81b-e695-4dfb-019b-1d9c3a58ce69@mail.de> (raw)
In-Reply-To: <tencent_97F4E1DC5AB2355F811C34993E2F56DD9D09@qq.com>
Am 04.02.22 um 17:19 schrieb Zhao Zhili:
> ---
> libavdevice/avfoundation.m | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
> index 0cd6e646d5..2078c4879c 100644
> --- a/libavdevice/avfoundation.m
> +++ b/libavdevice/avfoundation.m
> @@ -106,6 +106,7 @@ typedef struct
> int audio_device_index;
> int audio_stream_index;
>
> + char *url;
> char *video_filename;
> char *audio_filename;
>
> @@ -299,6 +300,7 @@ static void destroy_context(AVFContext* ctx)
> ctx->avf_delegate = NULL;
> ctx->avf_audio_delegate = NULL;
>
> + av_freep(&ctx->url);
> av_freep(&ctx->audio_buffer);
Why carry it in the context instead of adding the missing av_freep() in parse_device_name() ?
-Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-08 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 16:19 Zhao Zhili
2022-02-08 12:47 ` Thilo Borgmann [this message]
2022-02-08 12:50 ` Andreas Rheinhardt
2022-02-08 13:03 ` Thilo Borgmann
2022-02-08 13:05 ` Andreas Rheinhardt
2022-02-19 8:45 ` "zhilizhao(赵志立)"
2022-02-22 12:12 ` Thilo Borgmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=722ff81b-e695-4dfb-019b-1d9c3a58ce69@mail.de \
--to=thilo.borgmann@mail.de \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git