From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EC7C045F7D for ; Sat, 20 May 2023 16:44:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 359A868C14C; Sat, 20 May 2023 19:44:22 +0300 (EEST) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1FA3C68C03F for ; Sat, 20 May 2023 19:44:16 +0300 (EEST) Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-394c7ba4cb5so1557006b6e.1 for ; Sat, 20 May 2023 09:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684601054; x=1687193054; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ev5YE+UWRS1ePZo7Shj4CE29PQy9n+jBLCSKImHFKx8=; b=EbW3T0eHZAhMcRKaPpYUQX8BotPXLCNJWzkARdYwTiq1KKjw4CIBI6M3igwRrY2BVP UHRKZA3WQmut8YmI7BHMjS/adFnfjbuvnrWSRofm2zxdi6kO6MXGcxmuXbYDGgYXostK T5mjQkA7qNw+inkA551Cvfsfvu2eI4gHa76lWcfuXNMv7LO3f24o9p621y9OCBeCiDEl Mgl3mGrfolWZOEtSFtRKwsaB1CF+p2l6ZkwzhtqvMrvh2aTKQcIb7o9XkWsmGwvCFRwE e7uQTewGGalMx6+0HMCB8M/r5aYc7H4suWXKbZFrPFpSvfApk9Kio+3+INg7YFi6U2dx 4cJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684601054; x=1687193054; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ev5YE+UWRS1ePZo7Shj4CE29PQy9n+jBLCSKImHFKx8=; b=G+zp/oHOZXyTFb/524hM/c0IMhfykGZxVFVjce6I4bpt1kjfaHjsViybVRuaGHCjH5 Ezn5rosViuA80GYcWbhdNWBW/suCNLTq2H4zPa8aWIs28LXzx1ZAnanrQr28OJbp5BdR jHMMhjv/dnYFX1Qoi534gniBcpjjzmK+krPOLbiggoLbtM5jBxfRDXH+m6eOn+vTTWj4 zqHNdjXMlXP8H2sU3GBcLEuyoaw/lS5+rM2Mia3B+PyEZ/aZuO4TK7h2JwIRQnWSI2eZ euBajbCMaorZFHyuigL2EWo3VwQk/CFF1bySPgEzk+I5oODH4M7Hxk4xySQkU7LzKCTM G+1g== X-Gm-Message-State: AC+VfDwMaIt3QPU4ghAuJ42Enh3oKte5MVyCliEnj5ahqZMLa7lOIt8v LSwlZTHnsb0Ggsh1AcACSsOYAppVfzo= X-Google-Smtp-Source: ACHHUZ5NkEELkTYCiXuhpC94FwGrzeiDD/aP4pfcd8Gt4zMyJTQLXsPBS7utc5SiaMOUMJO9SL0Uqg== X-Received: by 2002:a05:6808:657:b0:396:3d52:4f65 with SMTP id z23-20020a056808065700b003963d524f65mr2727411oih.33.1684601054141; Sat, 20 May 2023 09:44:14 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id 3-20020aca0b03000000b00396050dca14sm728051oil.28.2023.05.20.09.44.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 May 2023 09:44:13 -0700 (PDT) Message-ID: <72052ad8-5c29-21f7-78eb-714d4725ca67@gmail.com> Date: Sat, 20 May 2023 13:44:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230520015057.4589-1-jamrial@gmail.com> <168459912978.3843.8984266215126151858@lain.khirnov.net> From: James Almer In-Reply-To: <168459912978.3843.8984266215126151858@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/20/2023 1:12 PM, Anton Khirnov wrote: > Quoting James Almer (2023-05-20 03:50:57) >> Signed-off-by: James Almer >> --- >> libavcodec/av1dec.c | 75 +++++++++++++++++++++++++++++++++------------ >> libavcodec/av1dec.h | 4 +++ >> 2 files changed, 60 insertions(+), 19 deletions(-) > > The patch makes the code longer and introduces an evil backward goto. > So some comment on why is this an improvement would be appropriate. It's an improvement because it removes the auto-inserted av1_frame_split from the process, making the decoder handle temporal units with more than one frame in them on its own. I can add that to the commit message. The extra code is inevitable because it's the decoder who now needs to fetch the packet instead of the generic code in decode.c _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".