Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/av1dec: convert to receive_frame()
Date: Sat, 20 May 2023 13:44:30 -0300
Message-ID: <72052ad8-5c29-21f7-78eb-714d4725ca67@gmail.com> (raw)
In-Reply-To: <168459912978.3843.8984266215126151858@lain.khirnov.net>

On 5/20/2023 1:12 PM, Anton Khirnov wrote:
> Quoting James Almer (2023-05-20 03:50:57)
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>   libavcodec/av1dec.c | 75 +++++++++++++++++++++++++++++++++------------
>>   libavcodec/av1dec.h |  4 +++
>>   2 files changed, 60 insertions(+), 19 deletions(-)
> 
> The patch makes the code longer and introduces an evil backward goto.
> So some comment on why is this an improvement would be appropriate.

It's an improvement because it removes the auto-inserted av1_frame_split 
from the process, making the decoder handle temporal units with more 
than one frame in them on its own. I can add that to the commit message.

The extra code is inevitable because it's the decoder who now needs to 
fetch the packet instead of the generic code in decode.c
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".