From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 49FE74EB0D for ; Tue, 13 May 2025 19:31:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 064CA68B44A; Tue, 13 May 2025 22:31:13 +0300 (EEST) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1249068A43A for ; Tue, 13 May 2025 22:31:07 +0300 (EEST) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5fcac09313cso7397663a12.2 for ; Tue, 13 May 2025 12:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1747164666; x=1747769466; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=deTToCZ72Ay6tFAOEmoWwN/Vhvyam3SPWvdekEIMTO0=; b=IuntXIrpL0bWGJZARBwfK6K6KAglUFto5+zPQRJbKtQQ0fZgSRH2auTgrL44il7ulR wSTBoYPHz4b+taY63BM7Ck4/fwIIMj/8yPjSQ4nmYZubS2r5EC9WjdrdMv7kowIGCZIt Vc8sKrt/14HZXmthqZCWkUJq6VaI/b0ZwBL1XYDmfzbAI0fjBOozK3PD4+cnVd2jHnuv OUP6462ZKRmoNzbDSXHH0wciQ6+LRCbNX7dsKaNd1gY0LyrNbGVDWnlpPTLKieBaI5tH 027EgXwf9Po7BlSitWQhSra1IOFcz/cXh1qftXi3gIm4U4uwz77izpK9+es8VSVpbkns J0mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747164666; x=1747769466; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=deTToCZ72Ay6tFAOEmoWwN/Vhvyam3SPWvdekEIMTO0=; b=hF8xNa3JwI1pbqMDN1F9s4OKTuGfBj1T6qlSKjmwSfuKbfRX9Yc/r21KYhguJX5DZZ DwFreUIyx9yDm8Zg9QlG/+IU8tC+m6NVNZxgVKglvWFx1ihW9ebmpPCO4uLBJjVKw86h uvbU7LbXJxZr8CTtAkdSMNT2NcmujlAqy+BkTzrR463rocyDq69ry2rVon22vhUtUcMd UXTxyUNmugBQKcMmPQ2iVJ5wrIj/y8qQJhfapON9Wd2KZsl5VQJadL8CsXdYYMHq5c0E rcFjXRcgJLnTjXypA0svHtu/yrK4v6Gruj6PlUnVZzAzobXmP1a4doKznNo+1ncQs5O8 HiCg== X-Gm-Message-State: AOJu0YyuKjRmp5dEwfGPG9x+NJvidJSlGDM0cu4fE/XTHCevQwI8HiqG +YPw7s5xivyqd5Ksbix8DdfULXRTo6MHUsCef5FMbHswkUNDJExyQa4bhlbJT62auVOVXTiVmxz HsA== X-Gm-Gg: ASbGncswNFN3KNXEzNYVLNtHZh4SFFQ4RFPF8fPkKVZ9NDMmNTdTcwL6BBQVIz3hUrM VogvUfSW07OWijL0CmiSA/p/TAdV2NURean90HZqNIm/rsqkMBygjlehrUdj0PWGgYU6zPMdF+S CmL9UtiAqVmH2X2OhwVIFEgJffBnoOMjGYnXGEwraIS32WWved6SaT4Xao9uUIePQ72m9RRduBo ceGpGQ6WUymrVR65+VC94hYMA9xafMDiITJt1GyBO/p4JGCHkWCqQ/Ob5GVeolIJHNEnX23b5K+ n87vGxtVWJspzvM2CIoDldInh0NdnffNFXYSGm/ecyzS/bGVTyTqSo+aT6VWYBFg/QazUuNOykF 5V83gqzaxUzc87GUlCx2GXsZDfPeGaHbyde4IrwvT2wZKVX0= X-Google-Smtp-Source: AGHT+IEHdaAdz1xlVFch714ZqhxhhohW3j0z+Z1+BbBIhBN+YWrgKUy/8Yj4+HBA86AD2DHB8ek1NQ== X-Received: by 2002:a05:6402:2110:b0:5fc:f22c:b921 with SMTP id 4fb4d7f45d1cf-5ff988de552mr332078a12.28.1747164666067; Tue, 13 May 2025 12:31:06 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5fc9cc2691esm7701450a12.26.2025.05.13.12.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 12:31:02 -0700 (PDT) Date: Tue, 13 May 2025 22:30:57 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20250512060242.1686-1-coiaprant@gmail.com> Message-ID: <71fbf8e5-51dd-7c96-bda-894a7f3719f@martin.st> References: <20250512060242.1686-1-coiaprant@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] fix(configure): fix detection on windows arm64 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Coia Prant Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 12 May 2025, Coia Prant wrote: > On Windows Arm64 > `uname -m` returned `x86_64` instead of `aarch64` > Link: https://github.com/msys2/msys2-runtime/issues/171 > > But `uname -s` contains `ARM64` suffix > So check suffix on windows arm64 (for clangarm64) > > This problem also in VideoLAN/x264 > Link: https://code.videolan.org/videolan/x264/-/merge_requests/177 > > Signed-off-by: Coia Prant > --- > configure | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configure b/configure > index 2e69b3c..d8c1e09 100755 > --- a/configure > +++ b/configure > @@ -4157,6 +4157,8 @@ if test "$target_os_default" = aix; then > arch_default=$(uname -p) > strip_default="strip -X32_64" > nm_default="nm -g -X32_64" > +elif [[ "$target_os_default" == "mingw"*"arm64" ]] || [[ "$target_os_default" == "msys"*"arm64" ]]; then > + arch_default="aarch64" > else I don't think we should be detecting this for the msys*arm64 cases here. If we're in the msys environment, as opposed to the mingw ones, then the x86_64 that "uname -m" returns really is correct (even if running emulated on aarch64, the msys environment itself is x86_64, so that's the target architecture of the compilation). For the mingw*arm64 case, I haven't thought about all the potential consequences of the patch; it may be acceptable. But the script is a strict POSIX sh script, it can't use bash constructs (which is what Michael observed in testing the patch). // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".