* [FFmpeg-devel] [PATCH] avformat/whip: mark as experimental
@ 2025-06-10 9:26 Jack Lau via ffmpeg-devel
2025-06-21 2:14 ` Jack Lau
0 siblings, 1 reply; 3+ messages in thread
From: Jack Lau via ffmpeg-devel @ 2025-06-10 9:26 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Jack Lau
[-- Attachment #1: Type: message/rfc822, Size: 4212 bytes --]
From: Jack Lau <jacklau1222@qq.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Jack Lau <jacklau1222@qq.com>
Subject: [PATCH] avformat/whip: mark as experimental
Date: Tue, 10 Jun 2025 17:26:13 +0800
Message-ID: <tencent_F08F17D293B511AC5960BED0310AA823AD07@qq.com>
This muxer has been marked AVFMT_EXPERIMENTAL.
Add a note in muxers.texi that WHIP is an experimental feature
This patch doesn't effect WHIP usage command, as WHIP always
needs to be explicitly specified
The details as follows:
https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344705.html
Signed-off-by: Jack Lau <jacklau1222@qq.com>
---
doc/muxers.texi | 2 ++
libavformat/whip.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index 30c95c3d34..d2ee90bf33 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -3885,6 +3885,8 @@ ffmpeg -f webm_dash_manifest -i video1.webm \
WebRTC (Real-Time Communication) muxer that supports sub-second latency streaming according to
the WHIP (WebRTC-HTTP ingestion protocol) specification.
+This is an experimental feature.
+
It uses HTTP as a signaling protocol to exchange SDP capabilities and ICE lite candidates. Then,
it uses STUN binding requests and responses to establish a session over UDP. Subsequently, it
initiates a DTLS handshake to exchange the SRTP encryption keys. Lastly, it splits video and
diff --git a/libavformat/whip.c b/libavformat/whip.c
index 710f24fc5a..bb7b8657dc 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
@@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = {
.p.long_name = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"),
.p.audio_codec = AV_CODEC_ID_OPUS,
.p.video_codec = AV_CODEC_ID_H264,
- .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE,
+ .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL,
.p.priv_class = &whip_muxer_class,
.priv_data_size = sizeof(WHIPContext),
.init = whip_init,
--
2.49.0
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] avformat/whip: mark as experimental
2025-06-10 9:26 [FFmpeg-devel] [PATCH] avformat/whip: mark as experimental Jack Lau via ffmpeg-devel
@ 2025-06-21 2:14 ` Jack Lau
2025-06-21 4:59 ` Zhao Zhili
0 siblings, 1 reply; 3+ messages in thread
From: Jack Lau @ 2025-06-21 2:14 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jun 10, 2025, at 17:26, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>
>
> From: Jack Lau <jacklau1222@qq.com>
> Subject: [PATCH] avformat/whip: mark as experimental
> Date: June 10, 2025 at 17:26:13 GMT+8
> To: ffmpeg-devel@ffmpeg.org
> Cc: Jack Lau <jacklau1222@qq.com>
>
>
> This muxer has been marked AVFMT_EXPERIMENTAL.
>
> Add a note in muxers.texi that WHIP is an experimental feature
>
> This patch doesn't effect WHIP usage command, as WHIP always
> needs to be explicitly specified
>
> The details as follows:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344705.html
>
> Signed-off-by: Jack Lau <jacklau1222@qq.com>
> ---
> doc/muxers.texi | 2 ++
> libavformat/whip.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index 30c95c3d34..d2ee90bf33 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -3885,6 +3885,8 @@ ffmpeg -f webm_dash_manifest -i video1.webm \
> WebRTC (Real-Time Communication) muxer that supports sub-second latency streaming according to
> the WHIP (WebRTC-HTTP ingestion protocol) specification.
>
> +This is an experimental feature.
> +
> It uses HTTP as a signaling protocol to exchange SDP capabilities and ICE lite candidates. Then,
> it uses STUN binding requests and responses to establish a session over UDP. Subsequently, it
> initiates a DTLS handshake to exchange the SRTP encryption keys. Lastly, it splits video and
> diff --git a/libavformat/whip.c b/libavformat/whip.c
> index 710f24fc5a..bb7b8657dc 100644
> --- a/libavformat/whip.c
> +++ b/libavformat/whip.c
> @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = {
> .p.long_name = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"),
> .p.audio_codec = AV_CODEC_ID_OPUS,
> .p.video_codec = AV_CODEC_ID_H264,
> - .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE,
> + .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL,
> .p.priv_class = &whip_muxer_class,
> .priv_data_size = sizeof(WHIPContext),
> .init = whip_init,
> --
> 2.49.0
Forgot to tag v4
PING.
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] avformat/whip: mark as experimental
2025-06-21 2:14 ` Jack Lau
@ 2025-06-21 4:59 ` Zhao Zhili
0 siblings, 0 replies; 3+ messages in thread
From: Zhao Zhili @ 2025-06-21 4:59 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jun 21, 2025, at 10:14, Jack Lau <jacklau1222gm-at-gmail.com@ffmpeg.org> wrote:
>
>> On Jun 10, 2025, at 17:26, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>>
>>
>> From: Jack Lau <jacklau1222@qq.com>
>> Subject: [PATCH] avformat/whip: mark as experimental
>> Date: June 10, 2025 at 17:26:13 GMT+8
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Jack Lau <jacklau1222@qq.com>
>>
>>
>> This muxer has been marked AVFMT_EXPERIMENTAL.
>>
>> Add a note in muxers.texi that WHIP is an experimental feature
>>
>> This patch doesn't effect WHIP usage command, as WHIP always
>> needs to be explicitly specified
>>
>> The details as follows:
>> https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344705.html
>>
>> Signed-off-by: Jack Lau <jacklau1222@qq.com>
>> ---
>> doc/muxers.texi | 2 ++
>> libavformat/whip.c | 2 +-
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/doc/muxers.texi b/doc/muxers.texi
>> index 30c95c3d34..d2ee90bf33 100644
>> --- a/doc/muxers.texi
>> +++ b/doc/muxers.texi
>> @@ -3885,6 +3885,8 @@ ffmpeg -f webm_dash_manifest -i video1.webm \
>> WebRTC (Real-Time Communication) muxer that supports sub-second latency streaming according to
>> the WHIP (WebRTC-HTTP ingestion protocol) specification.
>>
>> +This is an experimental feature.
>> +
>> It uses HTTP as a signaling protocol to exchange SDP capabilities and ICE lite candidates. Then,
>> it uses STUN binding requests and responses to establish a session over UDP. Subsequently, it
>> initiates a DTLS handshake to exchange the SRTP encryption keys. Lastly, it splits video and
>> diff --git a/libavformat/whip.c b/libavformat/whip.c
>> index 710f24fc5a..bb7b8657dc 100644
>> --- a/libavformat/whip.c
>> +++ b/libavformat/whip.c
>> @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = {
>> .p.long_name = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"),
>> .p.audio_codec = AV_CODEC_ID_OPUS,
>> .p.video_codec = AV_CODEC_ID_H264,
>> - .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE,
>> + .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL,
>> .p.priv_class = &whip_muxer_class,
>> .priv_data_size = sizeof(WHIPContext),
>> .init = whip_init,
>> --
>> 2.49.0
> Forgot to tag v4
> PING.
Applied with some modification to commit message, thanks.
>>
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-21 5:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-10 9:26 [FFmpeg-devel] [PATCH] avformat/whip: mark as experimental Jack Lau via ffmpeg-devel
2025-06-21 2:14 ` Jack Lau
2025-06-21 4:59 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git