[FFmpeg-devel] [PATCH] avformat/whip: mark as experimental

[FFmpeg-devel] [PATCH] avformat/whip: mark as experimental

[Jack Lau via ffmpeg-devel]

[-- Attachment #1: Type: message/rfc822, Size: 4212 bytes --]

From: Jack Lau <jacklau1222@qq.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Jack Lau <jacklau1222@qq.com>
Subject: [PATCH] avformat/whip: mark as experimental
Date: Tue, 10 Jun 2025 17:26:13 +0800
Message-ID: <tencent_F08F17D293B511AC5960BED0310AA823AD07@qq.com>

This muxer has been marked AVFMT_EXPERIMENTAL.

Add a note in muxers.texi that WHIP is an experimental feature

This patch doesn't effect WHIP usage command, as WHIP always
needs to be explicitly specified

The details as follows:
https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344705.html

Signed-off-by: Jack Lau <jacklau1222@qq.com>
---
 doc/muxers.texi    | 2 ++
 libavformat/whip.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/doc/muxers.texi b/doc/muxers.texi
index 30c95c3d34..d2ee90bf33 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -3885,6 +3885,8 @@ ffmpeg -f webm_dash_manifest -i video1.webm \
 WebRTC (Real-Time Communication) muxer that supports sub-second latency streaming according to
 the WHIP (WebRTC-HTTP ingestion protocol) specification.
 
+This is an experimental feature.
+
 It uses HTTP as a signaling protocol to exchange SDP capabilities and ICE lite candidates. Then,
 it uses STUN binding requests and responses to establish a session over UDP. Subsequently, it
 initiates a DTLS handshake to exchange the SRTP encryption keys. Lastly, it splits video and
diff --git a/libavformat/whip.c b/libavformat/whip.c
index 710f24fc5a..bb7b8657dc 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
@@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = {
     .p.long_name        = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"),
     .p.audio_codec      = AV_CODEC_ID_OPUS,
     .p.video_codec      = AV_CODEC_ID_H264,
-    .p.flags            = AVFMT_GLOBALHEADER | AVFMT_NOFILE,
+    .p.flags            = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL,
     .p.priv_class       = &whip_muxer_class,
     .priv_data_size     = sizeof(WHIPContext),
     .init               = whip_init,
-- 
2.49.0


[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/whip: mark as experimental

[Jack Lau]

> On Jun 10, 2025, at 17:26, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> 
> 
> From: Jack Lau <jacklau1222@qq.com>
> Subject: [PATCH] avformat/whip: mark as experimental
> Date: June 10, 2025 at 17:26:13 GMT+8
> To: ffmpeg-devel@ffmpeg.org
> Cc: Jack Lau <jacklau1222@qq.com>
> 
> 
> This muxer has been marked AVFMT_EXPERIMENTAL.
> 
> Add a note in muxers.texi that WHIP is an experimental feature
> 
> This patch doesn't effect WHIP usage command, as WHIP always
> needs to be explicitly specified
> 
> The details as follows:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344705.html
> 
> Signed-off-by: Jack Lau <jacklau1222@qq.com>
> ---
> doc/muxers.texi    | 2 ++
> libavformat/whip.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index 30c95c3d34..d2ee90bf33 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -3885,6 +3885,8 @@ ffmpeg -f webm_dash_manifest -i video1.webm \
> WebRTC (Real-Time Communication) muxer that supports sub-second latency streaming according to
> the WHIP (WebRTC-HTTP ingestion protocol) specification.
> 
> +This is an experimental feature.
> +
> It uses HTTP as a signaling protocol to exchange SDP capabilities and ICE lite candidates. Then,
> it uses STUN binding requests and responses to establish a session over UDP. Subsequently, it
> initiates a DTLS handshake to exchange the SRTP encryption keys. Lastly, it splits video and
> diff --git a/libavformat/whip.c b/libavformat/whip.c
> index 710f24fc5a..bb7b8657dc 100644
> --- a/libavformat/whip.c
> +++ b/libavformat/whip.c
> @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = {
>     .p.long_name        = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"),
>     .p.audio_codec      = AV_CODEC_ID_OPUS,
>     .p.video_codec      = AV_CODEC_ID_H264,
> -    .p.flags            = AVFMT_GLOBALHEADER | AVFMT_NOFILE,
> +    .p.flags            = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL,
>     .p.priv_class       = &whip_muxer_class,
>     .priv_data_size     = sizeof(WHIPContext),
>     .init               = whip_init,
> -- 
> 2.49.0
Forgot to tag v4
PING.
> 
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".