From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: h264 cenc entryption file decryption_key failed
Date: Tue, 12 Jul 2022 19:30:37 +0200 (CEST)
Message-ID: <716c4a95-10de-d07e-6e1-c9038ba2f1@passwd.hu> (raw)
In-Reply-To: <f0b7c523-2ba6-8568-dcf7-aa95ff574bc@passwd.hu>
On Sat, 9 Jul 2022, Marton Balint wrote:
>
>
> On Sat, 9 Jul 2022, lishuangxi wrote:
>
>> Please help review it, thanks.
>
> You should describe why the old logic of encrypting in 16 byte chunks is
> uneeded in the commit message.
Applied with fixed commit message.
Thanks,
Marton
>
>> Code process
>> -- Fixes ticket #9807.
>> -- Fixes ticket #9777.
>
> The file in linked in ticket #9807 is still unplayable for me after your
> patch. As for the other ticket, the reported did not include a sample, so
> there is no way to know for sure if your patch fixes it.
>
> Regards,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-12 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 6:55 lishuangxi
2022-07-09 18:22 ` Marton Balint
2022-07-12 17:30 ` Marton Balint [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-02 8:14 lishuangxi
2022-07-02 7:46 [FFmpeg-devel] [PATCH] avformat/mov " lishuangxi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=716c4a95-10de-d07e-6e1-c9038ba2f1@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git