From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5713346927 for ; Thu, 24 Aug 2023 19:22:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6F14E68C658; Thu, 24 Aug 2023 22:22:31 +0300 (EEST) Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5440D68C514 for ; Thu, 24 Aug 2023 22:22:25 +0300 (EEST) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-58dfdb0dfd6so479127b3.0 for ; Thu, 24 Aug 2023 12:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692904943; x=1693509743; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=0SWwcXckoPspD3b6s/l85VscmL9ADmVCAfRyfxGjNmI=; b=MsdNpERKkd3sjO2B6CaWdG1OtTjKhEJ3V8c62iD3bKWn/x7pzqRIQ93Z7YXBlaWwXb hxocLuEo/hTmzlXL4ey+FukhDQ9tq76JPbIPWvGbCr2jJMvUTX/UqiEN582LEgSNiUv/ S6160uLFxNlyu6ziqPVek2Z9N10JhX08fvc27o4ns59yCCITIZmaD0Uur+WxZXp8KlJ3 j5CYziIdtIQNHVX3vXg1rOeKJA0NxkxVuaadWSi1Hsa/6Rm9GPHLWwRUpyLqPhXIC/eg KV+vntB0TBKmvOJIxJfyTpIpIeiCbE9alSqDtemvZiKEB4hl1eJPJvV8UaQk91ISJ18V 5p8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692904943; x=1693509743; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0SWwcXckoPspD3b6s/l85VscmL9ADmVCAfRyfxGjNmI=; b=IlCC1wTmJ+QsKpauyfcLH1+mkCQ97mQge21ChH++8NU3HYwXzqYVqwBp6z3P6Z8YST ZT1QciNKHhR8OIVc03blp8VeuvqNA1uqPKnSvmeE22HtXeko5btAIlf/XxABmMhEvNd1 8SoUF2ocWiteuV3OyVzRD98ytS51e9x0TmJjbooXnPaHplazIOvKfLnPCz6chd1gaXoq pGLUw0G3M3ojYN1FyJbOhvG4xOzPjVBdZtbW0sAeLf+5DPnVi2j9Axj2NHvlvlACC4E9 EOXOqKCuKY5YoOpqhnUtaC/FbgBiMHKotvP4SLfOktxuJhL7fEqYyi7W9kf36LaCGed/ X35w== X-Gm-Message-State: AOJu0YwWNcaI5LhNVc8uZzUkiQEdinlnBY86KFpdhPLXz4Q+V2lVp2oO CFNlA/71vWpbGcQkxtrU7z03a9rMxvc= X-Google-Smtp-Source: AGHT+IHRsjZ0udpHABpl9Mov5fw0kKRMPYmWUASYTt3ygKOnaKQrWWZTaqe8fFjV6J6m+LlAVujUNQ== X-Received: by 2002:a81:8395:0:b0:586:ab46:2c54 with SMTP id t143-20020a818395000000b00586ab462c54mr9788235ywf.5.1692904943495; Thu, 24 Aug 2023 12:22:23 -0700 (PDT) Received: from [192.168.1.35] (c-68-56-149-176.hsd1.mi.comcast.net. [68.56.149.176]) by smtp.gmail.com with ESMTPSA id b139-20020a0dd991000000b00577044eb00esm61742ywe.21.2023.08.24.12.22.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 12:22:22 -0700 (PDT) Message-ID: <71236b61-bfbc-4fed-b9f0-a41f6d029916@gmail.com> Date: Thu, 24 Aug 2023 15:22:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: FFmpeg Development References: <20230802203334.23640-1-leo.izen@gmail.com> Content-Language: en-US-large From: Leo Izen In-Reply-To: <20230802203334.23640-1-leo.izen@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v7 0/5] JPEG XL Parser (and bug fixes) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/2/23 16:33, Leo Izen wrote: > Changes from v6: > - Added dummy stub libavformat/jpegxl_parse.c to fix shared builds > > Changes from v5: > - Attached an extra commit to fix existing bug with libjxldec > - Made various changes based on comments by Andreas Reinhardt > -- removed jpegxl_parse.c from avformat, and jpegxl_parse.o from avformat/Makefile/OBJS > -- checked for failure in init_vlc_lengths > -- used a macro to initialize VLCElem structs > -- used heap allocations for a buffer of size 250k, instead of stack > -- renamed "code" to "len" > - Fix demuxer to avoid using avio_size, breaking piped input > - Fix some parser bugs discovered during more extensive testing > > Changes from v4: > - Added an entropy decoder and full parser, which finds the > boundaries between files correctly > - Removed unnecessary logging in libjxldec > > Changes from v3: > > - Don't remove AV_CODEC_CAP_DR1 from libjxldec > - jpegxl_parse.o added to STLIBOBJS in avcodec/Makefile > - add pipe demuxer to avformat/Makefile's SHLIBOBJS > > Changes from v2: > > - Fix libjxldec to work with packets that are smaller than one frame > - Change how code is shared between libavcodec and libavformat to be more sensible. > - Fix the parser to work with large headers that proceed the codestream in a container format > (for example, if several-KB Exif boxes preceed the codestream.) > - Modify the parser to set width/height instead of avctx > Note: avctx->pix_fmt and s->format are both set, because otherwise the CLI tools won't print > the pixel format without libjxl enabled. > - Update the fate test based on the new parser's packetization > > This test relies on FATE samples that haven't been uploaded yet. To test, unzip > the following zipfile[1] in the FATE_SAMPLES directory, placing the test images in jxl/. > > [1]: https://buzo.us/y.zip > > sha256sum: 43a2eeb0dfdf471b47a9fdfb1653974fa156ceceb776891cc137569a8ebf0e75 > signature: https://buzo.us/R.asc > > Leo Izen (5): > avcodec/libjxldec: fix errors when decoding grayscale after rgb > avcodec/libjxldec: use internal AVFrame as buffered space > avcodec/jpegxl_parser: add JPEG XL parser > avformat/jpegxl: remove jpegxl_probe, instead call > avcodec/jpegxl_parse > fate/jpegxl_anim: add demuxer fate test for jpegxl_anim > > libavcodec/Makefile | 3 + > libavcodec/jpegxl.h | 94 ++ > libavcodec/jpegxl_parse.c | 520 ++++++ > libavcodec/jpegxl_parse.h | 72 + > libavcodec/jpegxl_parser.c | 1477 +++++++++++++++++ > libavcodec/libjxldec.c | 41 +- > libavcodec/parsers.c | 1 + > libavcodec/version.h | 2 +- > libavformat/Makefile | 6 +- > libavformat/img2dec.c | 4 +- > libavformat/jpegxl_anim_dec.c | 132 +- > .../{jpegxl_probe.h => jpegxl_parse.c} | 21 +- > libavformat/jpegxl_probe.c | 412 ----- > libavformat/version.h | 2 +- > tests/Makefile | 1 + > tests/fate/jxl.mak | 16 + > tests/ref/fate/jxl-anim-demux-belgium | 6 + > tests/ref/fate/jxl-anim-demux-icos4d | 6 + > tests/ref/fate/jxl-anim-demux-lenna256 | 6 + > tests/ref/fate/jxl-anim-demux-newton | 6 + > 20 files changed, 2273 insertions(+), 555 deletions(-) > create mode 100644 libavcodec/jpegxl.h > create mode 100644 libavcodec/jpegxl_parse.c > create mode 100644 libavcodec/jpegxl_parse.h > create mode 100644 libavcodec/jpegxl_parser.c > rename libavformat/{jpegxl_probe.h => jpegxl_parse.c} (55%) > delete mode 100644 libavformat/jpegxl_probe.c > create mode 100644 tests/fate/jxl.mak > create mode 100644 tests/ref/fate/jxl-anim-demux-belgium > create mode 100644 tests/ref/fate/jxl-anim-demux-icos4d > create mode 100644 tests/ref/fate/jxl-anim-demux-lenna256 > create mode 100644 tests/ref/fate/jxl-anim-demux-newton > Merging tomorrow as this has been through several review cycles. - Leo Izen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".