From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 519CE4A3EF for ; Wed, 27 Mar 2024 14:30:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D346968D67C; Wed, 27 Mar 2024 16:30:22 +0200 (EET) Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 247A668D669 for ; Wed, 27 Mar 2024 16:30:16 +0200 (EET) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-221e6bf537dso4030526fac.1 for ; Wed, 27 Mar 2024 07:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711549814; x=1712154614; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=idciyy2VjuKKS948Gu8i2E13CBW+C43NmQd90aOFJZI=; b=jvnqogKy+5iWtJDr8HN/HQNNq8a2J5QkFl4bsv6y8Czl4Apt5gNIZXrpufILP8D5ax t26FO5y/YPsiopnfpRCnnl62LBQ/k5nPV+x5zcWNf1UjYB2hGcW3kBLqt1BwegWg/6y7 jPdHJUbjDfMwDM2YRcvDDlgZKqwmkYHOSmmi92BJZ2b68M/LejHzkkMTy4BYy3MOooLi PvpEzbk8iDQDPg6+h8wAW4MXEVkQ8+syBKp7THycI7+vRvp3lkrESJmOHFP6JOr8M67t zCQjszt1VGhnbTvjhMIObt4JGKUCDfMm1BjF4H7wyEhlYR3Eta664w9Gk4/GL2a6XkqP a8CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711549814; x=1712154614; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=idciyy2VjuKKS948Gu8i2E13CBW+C43NmQd90aOFJZI=; b=azM2kMtAV1vK3dK2YzSLanGoq+bsLlrCFFavw9UQmRrjrtCYzw7FDYc5gmaQFIfQ0k Eh3ZLuL/9sp2stqEVlB+nUCzG1E7fP5UYmZ++e0pcYyr8AE9ZXCGLyKgqLHr+iDJnX1k YJYp4cq4e2XEO1ajPv4FfUkjW9cXNH0SRD/gFIjVYzMnMVupiQ6gph04z1+MoyrMo9EF L0yuOkWyBujZiVsJnVtT3U8UMOfxGM/FSou+G4SP48HMLjQ0vtaXFJCQVDjNnpSSJYf7 TIMWg0j7n7eKq+lQa/gr8oIsCMMqX+9o29lFu5xgkG99yijDNVAZJdY0VNx2zys4CIAv urUw== X-Gm-Message-State: AOJu0YxMLCrRaEEiBKg4g6NWqkxzi22R4gmjhwP1j47Q7UIckvMX+sKT e5qQd9WeYyk+YDO7EVsUR/tfa99m0JVl+Tcx+bjGSD6mCbNntCAHFFGfznVb X-Google-Smtp-Source: AGHT+IEd82Em4kA1N1odZcuAwWo2kDjhnrZ73IrVKb/RYQ3tjcXCy5uing+ejGJmAd+XVAU0Lkfk3Q== X-Received: by 2002:a05:6871:553:b0:229:fd96:1e6f with SMTP id t19-20020a056871055300b00229fd961e6fmr4924934oal.24.1711549814143; Wed, 27 Mar 2024 07:30:14 -0700 (PDT) Received: from [192.168.0.15] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id q18-20020a62e112000000b006e8f75d3b07sm7885574pfh.181.2024.03.27.07.30.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 07:30:13 -0700 (PDT) Message-ID: <71142238-f00b-4c31-a21d-7f70270873ee@gmail.com> Date: Wed, 27 Mar 2024 11:30:15 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240209151959.C7231411B5B@natalya.videolan.org> <20240327140311.GC2460414@pb2> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/27/2024 11:13 AM, Kieran Kunhya wrote: > On Wed, 27 Mar 2024 at 14:03, Michael Niedermayer > wrote: > >> On Fri, Feb 09, 2024 at 03:19:58PM +0000, Anton Khirnov wrote: >>> ffmpeg | branch: master | Anton Khirnov | Thu Feb >> 1 08:57:24 2024 +0100| [ca18bb597223b3df5bbf8a1836d157ba58b62570] | >> committer: Anton Khirnov >>> >>> lavf/demux: stop calling avcodec_close() >>> >>> Replace it with recreating the codec context. >>> >>> This is the last remaining blocker for deprecating avcodec_close(). >>> >>>> >> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ca18bb597223b3df5bbf8a1836d157ba58b62570 >>> --- >>> >>> libavformat/demux.c | 61 >> ++++++++++++++++++++++++++++++++++++++++++++++++----- >>> 1 file changed, 56 insertions(+), 5 deletions(-) >> >> This breaks ffprobe "Closed Caption" output >> before: >> Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive), >> 1920x1080 [SAR 1:1 DAR 16:9], Closed Captions, 29.97 fps, 59.94 tbr, 90k tbn >> > > Closed Captions are sparse side data, we shouldn't be exposing it like this > to begin with. This avcodec_string() output is based on which AVCodecContext->properties flags are set (For CC, it happens when a caption is found). Which yes, it's not exactly ideal. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".