From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 433DC48A94 for ; Mon, 27 May 2024 18:17:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F0CC768D4C1; Mon, 27 May 2024 21:17:27 +0300 (EEST) Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 680A568D178 for ; Mon, 27 May 2024 21:17:21 +0300 (EEST) Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5b680c1fdd4so3745457eaf.1 for ; Mon, 27 May 2024 11:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716833839; x=1717438639; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=huI3tKvK8oudcroFlJsKDyH9mitzALpMOmZylb2kMEQ=; b=Rau2rC0UVE4zQ8pj4Lo584dyx41kUBAgg5LkU2hydqkHcFHrHQeo1gBl2HPodlYLfj MIgaemQyoHSOZ9d/mzTdAVKDRGg1ZQ21lbCnygLB7YmTz05WHPQ5y2LHsnM4nI6fF0cw 7X330SB/QBLALXGkCBwocwmuAdBCV9bM2iXKlmhswKJl0keEpx58E3Jyfsg3+mY+tyAf J1qndEJmDR6FqYGfloGIyA9qAvheUBnITQRWem7Frg7DCPWMVEs0cDhVEnBdTIUWttGA 0wB/Lg0mFy2xM5gu1RkOKUHf+aa2G0SLohbfrHgCiSpPu0/IVSRvIbrLNp6m8xzlZvtN ofNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716833839; x=1717438639; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=huI3tKvK8oudcroFlJsKDyH9mitzALpMOmZylb2kMEQ=; b=EBKgtVnsH3SxVe0NhsuuzHRrBWa3luCl+YK2ZIw0WxVGm3OZyGjr2Ox2cxxVmhQiPI vGw7JQmI4/me5C0H82BpEXW6mMV3fvY9B0lnpK72G/HNV5PjeI0RSb17dcMNx04+04re YMDNX9wIOW1vrZg/ycp62HOgqWi9VBUYxiXfQbKXRWAs934DFRMnsxA2HgcPTqZZlX+a /npIR9j0xfZo5TxTC12+XdDdd5qROw0AjaPE61X9dZU3YAtLFNFBrUNUhI1SY4cdJlAp vo6HGQeFU13p0Qqgfsx0EN+hLn67+D4xbG8G1vsezJN1VyO7vangtTnr/LOW65J4GbCu 7SFQ== X-Gm-Message-State: AOJu0Yyubk3tytHwndHrzfD3VJkKKjliw3d7A7DNCskM+ZazMXzqM096 00qxkSUgEyQ+2Eqx2mFAU861+6iil3I4BLw+Q1KD/PhcLWJhDEIhd+UzzQ== X-Google-Smtp-Source: AGHT+IEiviF5ZqihdXf7QH5QDDXSxmd/WW6n+4SaHgCBAGOg25QIMn03Z/LbbrT9yS6gKlag2MUMWg== X-Received: by 2002:a05:6359:4c29:b0:183:645b:cfa4 with SMTP id e5c5f4694b2df-197e5317651mr1300691455d.16.1716833838737; Mon, 27 May 2024 11:17:18 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-682227f1931sm6263760a12.45.2024.05.27.11.17.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 May 2024 11:17:18 -0700 (PDT) Message-ID: <703eafba-1d9a-458b-a4ee-f2092a73bd83@gmail.com> Date: Mon, 27 May 2024 15:17:15 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240427003623.118199-1-michael@niedermayer.cc> <171679774316.28895.4366606367617414113@lain.khirnov.net> <20240527181105.GN2821752@pb2> Content-Language: en-US From: James Almer In-Reply-To: <20240527181105.GN2821752@pb2> Subject: Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/27/2024 3:11 PM, Michael Niedermayer wrote: > On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote: >> Quoting Michael Niedermayer (2024-04-27 02:36:23) >>> This allows detecting issues in side data related code, same as what >>> framecrc does for before already for packet data itself. >>> >>> Signed-off-by: Michael Niedermayer >>> --- >> >> I am against this patch. Checksumming side data is a fundamentally wrong >> thing to do. > > It, or something equivalent is neccessary for regression testing. > (and it was you who asked also for the tests i run to be part of > fate. But here you object to it) > > You know, not checking side data is not checking it so differences would then not be > detected allowing for unintended changes to be introduced (aka bugs) You have seen how much code is needed to get hashing to work for all targets with some types, so it does feel like it's not the right thing to do. ffprobe (and f_sidedata) are what should be used for actual integrity checks. And i insist that disabling printing the size (or any information about side data) from framecrc is needed for FATE tests, as we can't even use it to hash actual packet data otherwise. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".