Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffplay: use correct buffersink channel layout parameters

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffplay: use correct buffersink channel layout parameters

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 967 bytes --]

On Tue, Mar 19, 2024 at 07:54:20PM +0000, Marton Balint wrote:
> ffmpeg | branch: master | Marton Balint <cus@passwd.hu> | Mon Mar 18 21:07:20 2024 +0100| [7251f909721a570726775acf61b2b9c28a950c76] | committer: Marton Balint
> 
> fftools/ffplay: use correct buffersink channel layout parameters
> 
> Regression since 0995e1f1b31f6e937a1b527407ed3e850f138098.
> 
> Signed-off-by: Marton Balint <cus@passwd.hu>
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7251f909721a570726775acf61b2b9c28a950c76
> ---
> 
>  fftools/ffplay.c | 2 ++
>  1 file changed, 2 insertions(+)

This breaks_
./ffplay fate-suite/wav/200828-005.wav

[ffplay_abuffersink @ 0x7feef8008700] Channel layout change is not supported

should i open a ticket ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffplay: use correct buffersink channel layout parameters

[Marton Balint]

On Wed, 27 Mar 2024, Michael Niedermayer wrote:

> On Tue, Mar 19, 2024 at 07:54:20PM +0000, Marton Balint wrote:
>> ffmpeg | branch: master | Marton Balint <cus@passwd.hu> | Mon Mar 18 21:07:20 2024 +0100| [7251f909721a570726775acf61b2b9c28a950c76] | committer: Marton Balint
>>
>> fftools/ffplay: use correct buffersink channel layout parameters
>>
>> Regression since 0995e1f1b31f6e937a1b527407ed3e850f138098.
>>
>> Signed-off-by: Marton Balint <cus@passwd.hu>
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7251f909721a570726775acf61b2b9c28a950c76
>> ---
>>
>>  fftools/ffplay.c | 2 ++
>>  1 file changed, 2 insertions(+)
>
> This breaks_
> ./ffplay fate-suite/wav/200828-005.wav
>
> [ffplay_abuffersink @ 0x7feef8008700] Channel layout change is not supported
>
> should i open a ticket ?

No, there is already a patch for this under review:

https://lists.ffmpeg.org//pipermail/ffmpeg-devel/2024-March/324092.html

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffplay: use correct buffersink channel layout parameters

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1389 bytes --]

On Wed, Mar 27, 2024 at 09:52:54PM +0100, Marton Balint wrote:
> 
> 
> On Wed, 27 Mar 2024, Michael Niedermayer wrote:
> 
> > On Tue, Mar 19, 2024 at 07:54:20PM +0000, Marton Balint wrote:
> > > ffmpeg | branch: master | Marton Balint <cus@passwd.hu> | Mon Mar 18 21:07:20 2024 +0100| [7251f909721a570726775acf61b2b9c28a950c76] | committer: Marton Balint
> > > 
> > > fftools/ffplay: use correct buffersink channel layout parameters
> > > 
> > > Regression since 0995e1f1b31f6e937a1b527407ed3e850f138098.
> > > 
> > > Signed-off-by: Marton Balint <cus@passwd.hu>
> > > 
> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7251f909721a570726775acf61b2b9c28a950c76
> > > ---
> > > 
> > >  fftools/ffplay.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > 
> > This breaks_
> > ./ffplay fate-suite/wav/200828-005.wav
> > 
> > [ffplay_abuffersink @ 0x7feef8008700] Channel layout change is not supported
> > 
> > should i open a ticket ?
> 
> No, there is already a patch for this under review:
> 
> https://lists.ffmpeg.org//pipermail/ffmpeg-devel/2024-March/324092.html

ok, please make sure this makes it into release/7.0 too

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".