From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6A6AB501A7 for ; Tue, 8 Jul 2025 19:16:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6887568EB4E; Tue, 8 Jul 2025 22:16:50 +0300 (EEST) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id A2D5F68E871 for ; Tue, 8 Jul 2025 22:16:43 +0300 (EEST) Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-60bfcada295so7735107a12.1 for ; Tue, 08 Jul 2025 12:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752002203; x=1752607003; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ZZPRSLzcS8YFqVazE7CmcRFqSE2ZsIC1GIACUNPixNM=; b=BRbKWKQmKSCb1SD3yfMpM3wXPHyG+OlQFegaIdXL2bHcZWUzfm3jLiz9QNhEugxWGk aPlJhfeoLIC1++7i58v6B87TS+S2+nnFIc8JksNAWW7MWFD7A2F895hnReXuqX/FkhZe YfwRJioi89Drp+72eRhiC7wvtmVBwgifF12yG6+zgo/6eUxgdtG8kOVNF2NTbAKjo4OV gZq2T6Wx1CsqZwXmR88t63ZDH7wXYeyQP8D6V9WUs5GzKVExgdGjz/ymcoFPFWFpr9tr rR9nuSdSZ31k18MGRDHyFR4s6EFVBpI83SCP69UW0jzYaRVhigyu21H/8EQUu2zUh6pE Gi2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752002203; x=1752607003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZZPRSLzcS8YFqVazE7CmcRFqSE2ZsIC1GIACUNPixNM=; b=YP9SSlrDGkfD7JtNJccQNy5hF2sjyNZJIRjjURQidvGbItIAmo50v2EARMaGKikRA/ w52Rv5uK4Y1+eYIw0RtBVwWK5SEpmF/m3zxdP8m2tProFRJ7EFPtNoCk7ZneBNEBNBH5 TUR3GbnlrFhHCRPPGfHXlqKjzHrn6pXTBQ4ylPatYPKrCAjW7QzmdaQyd9oV580j2rNi ulN8XiJ0FOk6QbngwWI726CpKdfh9J/TbwQLib2sJKGcGV+0PaUdCngXmC+t8GMKhVfC Lf/Dur+O/2qUC9U5Xn0X3VTvet0un3guTObi9HKJUD0naqjXhHyWCamw/Qk/IRhp74hY X4eg== X-Gm-Message-State: AOJu0YwK4QFJZD/6uqO9C1Z+TKWKuUdRHUQ+7X2YsCVT9VXLYkvIMW1S j0qMV1er/wPexxSwP5dJUNgbjjRtoHH88chSwjs+nhh/HkZ91+m72SFyuW0IhqW/ X-Gm-Gg: ASbGnct2oektlWJns82tTQQKAx5kaT+lOGOD80hiBDiQkxFCEdF85IwRT93YtI8KHTz mwUMRf1gQMlL/xzMIJYqF3T4gkj8WH2Osf3inA18ZKMDkXkwwQB34wCfSHwb9SvJpePCiYUlZrU oRRgR7hsoCtNNKgUMYtMScXN85eOa2/vYlfC7SfBAc2ozghpEXOoE3Llk9SOb9seE8CjAyMjo+k as0x3JmNDvDZcQXaK5tyOk9ETufi8F3xVYiUGW9amXzYw8REzlWOE+fsRIuoJ7G5F3DVFL/KcOn wgXTK5FKb1yKilEBJXaPFVeAP/Zk3Q8I5AOkVimGBSNrXRrmDYJ7U4KsNqhlTqlxpa2fYZ2wjed Qdc9MpeWMSS1v0AFFRYMNd3L0bZwDFDxC4ROMDY1GH4uNsi8ryrJhgMWV+bub1t5veHs8lPn8l5 b+ X-Google-Smtp-Source: AGHT+IFwjKfH1rDIQCiZGtZgOFAhxMSG/+2ZSUEbbsetG826HuhmBHaAqRQNP27IFLfyp4OK7mdRBA== X-Received: by 2002:a05:6402:524e:b0:602:1b8b:2925 with SMTP id 4fb4d7f45d1cf-60fd6e4c225mr14004946a12.29.1752002202831; Tue, 08 Jul 2025 12:16:42 -0700 (PDT) Received: from [192.168.178.143] (p200301023701fa00258573ace0251429.dip0.t-ipconnect.de. [2003:102:3701:fa00:2585:73ac:e025:1429]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60fcb1fb083sm7588792a12.62.2025.07.08.12.16.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Jul 2025 12:16:42 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Tue, 08 Jul 2025 21:16:41 +0200 X-Mailer: MailMate (2.0r6222) Message-ID: <7006F9A9-B3C3-402A-972A-14C5EBA7F601@gmail.com> In-Reply-To: <3b06ac6e75c04d1cd160c91902aab8901f5c7dda.1751964469.git.pross@xvid.org> References: <3b06ac6e75c04d1cd160c91902aab8901f5c7dda.1751964469.git.pross@xvid.org> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8 Jul 2025, at 10:49, Peter Ross wrote: > Fixes CID1655273 and CID1655274. > --- > v2: Use the new av_unreachable() macro > > libavcodec/adpcm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > index 92ab248f3d..83ef7c780a 100644 > --- a/libavcodec/adpcm.c > +++ b/libavcodec/adpcm.c > @@ -877,6 +877,8 @@ static int adpcm_sanyo_expand3(ADPCMChannelStatus *c, int bits) > add = (11 * c->step) >> 1; > c->step = 3 * c->step; > break; > + default: > + av_unreachable("There are cases for all control paths when bits is 3-bit"); > } > > if (sign) > @@ -934,6 +936,8 @@ static int adpcm_sanyo_expand4(ADPCMChannelStatus *c, int bits) > add = (25 * c->step) >> 1; > c->step = 5 * c->step; > break; > + default: > + av_unreachable("There are cases for all control paths when bits is 4-bit"); > } > > if (sign) > -- > 2.47.2 > > -- Peter > (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) LGTM, thanks! > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".