[FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings

[FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings

[Peter Ross]

[-- Attachment #1.1: Type: text/plain, Size: 968 bytes --]

Fixes CID1655273 and CID1655274.
---
v2: Use the new av_unreachable() macro

 libavcodec/adpcm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
index 92ab248f3d..83ef7c780a 100644
--- a/libavcodec/adpcm.c
+++ b/libavcodec/adpcm.c
@@ -877,6 +877,8 @@ static int adpcm_sanyo_expand3(ADPCMChannelStatus *c, int bits)
         add = (11 * c->step) >> 1;
         c->step = 3 * c->step;
         break;
+    default:
+        av_unreachable("There are cases for all control paths when bits is 3-bit");
     }
 
     if (sign)
@@ -934,6 +936,8 @@ static int adpcm_sanyo_expand4(ADPCMChannelStatus *c, int bits)
         add = (25 * c->step) >> 1;
         c->step = 5 * c->step;
         break;
+    default:
+        av_unreachable("There are cases for all control paths when bits is 4-bit");
     }
 
     if (sign)
-- 
2.47.2

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings

[Marvin Scholz]

On 8 Jul 2025, at 10:49, Peter Ross wrote:

> Fixes CID1655273 and CID1655274.
> ---
> v2: Use the new av_unreachable() macro
>
>  libavcodec/adpcm.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
> index 92ab248f3d..83ef7c780a 100644
> --- a/libavcodec/adpcm.c
> +++ b/libavcodec/adpcm.c
> @@ -877,6 +877,8 @@ static int adpcm_sanyo_expand3(ADPCMChannelStatus *c, int bits)
>          add = (11 * c->step) >> 1;
>          c->step = 3 * c->step;
>          break;
> +    default:
> +        av_unreachable("There are cases for all control paths when bits is 3-bit");
>      }
>
>      if (sign)
> @@ -934,6 +936,8 @@ static int adpcm_sanyo_expand4(ADPCMChannelStatus *c, int bits)
>          add = (25 * c->step) >> 1;
>          c->step = 5 * c->step;
>          break;
> +    default:
> +        av_unreachable("There are cases for all control paths when bits is 4-bit");
>      }
>
>      if (sign)
> -- 
> 2.47.2
>
> -- Peter
> (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

LGTM, thanks!

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".