From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 727E8434A2 for ; Thu, 14 Jul 2022 06:17:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ABFF868B9B7; Thu, 14 Jul 2022 09:17:54 +0300 (EEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A491668B866 for ; Thu, 14 Jul 2022 09:17:47 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657779472; x=1689315472; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=nXNoJGfpHSaFKF2xaO0eGf+8UmusK+Y2cqrUm7Tc+88=; b=RE5noorLzsiFi3oPg1iVEQVOoAn/zh4Y41lLKPvlKNipQEs306H7fma9 qvFBWDoEi0kx/ohSfmx3gqCH8Q3sbz8N/6tpxL2JfaKXMo7CkInQZL8mD SwkEwtBmCRwvXTYF3bervfASOj/eGdlq/EYFtU6MFYD9KaFPCOc8mWFtk hNgShVb+pqUDtmDNvmJaNwGCEER1Owllbjj7+NSaP8YFDGaOTEWMNSeu5 sX57QWkVpTCAocyAWMJ2Fqav55rVcdi3K706SLi6Aepl5tJClNWwxwfWL AMTwZkegqNGriHtQlgQdnAieCuP/MX8m9y7fjKRswvGx3RtKnSBvMIIbS A==; X-IronPort-AV: E=McAfee;i="6400,9594,10407"; a="284183941" X-IronPort-AV: E=Sophos;i="5.92,269,1650956400"; d="scan'208";a="284183941" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 23:17:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,269,1650956400"; d="scan'208";a="663662444" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 13 Jul 2022 23:17:44 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Jul 2022 23:17:00 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 13 Jul 2022 23:17:00 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 13 Jul 2022 23:16:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fWvH3O5pXoY9ee8XRNCgEim+72YKNBo8vKuFuGZCnMISSm3EVZ8+j+iG2OayEkz57qLgbeTgm+5+qExdd9KkfyudoCp0qkvxXxivsMYnoa+T7mwi/Sh2P0OE4DvlLa9egWTuDKBu0cQ5QByq2Fs24vdeTrmJiplLsOJtt+Vsmwc+hn/N5w7q4l2Q5ypdE4u8iB+OxzqlhCbD9LP7Y3AFHHMdHavVq2avEsYFQ2YRPOger/b/YxO8I48GmLZeA25r8nL8g0RRnTVodkOUkO+LREIkarfZT6MPQp89oI5U1yNZxHKoG9V7dlXjb2OuWVKLaURDITPfV90bes3uPdc4AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nXNoJGfpHSaFKF2xaO0eGf+8UmusK+Y2cqrUm7Tc+88=; b=VY7Sntbtsn/biGSK2LvyHjlCe0E7XaCftJ7kuDhZMOEv6EHM9RD5JinBLE6Hd0QMaiBiJsVwp98qaNT6FA3FhmSjS3Qb6s6WOGAlGSI2dkj4NSDi/Ol/t1jdXfdBv1Zk0pnamYoOEEqfOGok82T0YzjHjsQczqltsayw3Y43CVnRRJYMXPC8WZAJo0MA5pLJnseJ3zxLhAZ8UyN5jU3WA80C+7deA70uAKaCdXlBYnvJACeIrE6KVtzID3Kaz1OvnqWGA+pFHb0gTjcr56SG55WC9wm5IA0BBpdUOchRrCZcX7/gyuemDnv5D07G9A7DMaoEse7NhHRgQK5ZIgDZZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BL0PR11MB3137.namprd11.prod.outlook.com (2603:10b6:208:73::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Thu, 14 Jul 2022 06:16:48 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::f977:9a9f:bad7:d3ce]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::f977:9a9f:bad7:d3ce%5]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 06:16:48 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2 4/4] lavc/hevcdec: respect the value of no_output_of_prior_pics_flag Thread-Index: AQHYf45jdXFEyBS9YECxQQ31wynltq19k3cA Date: Thu, 14 Jul 2022 06:16:48 +0000 Message-ID: <6fae2937fa82af8910909c470bc112f3750e05c7.camel@intel.com> References: <20220614012302.2808428-1-fei.w.wang@intel.com> <20220614012302.2808428-4-fei.w.wang@intel.com> In-Reply-To: <20220614012302.2808428-4-fei.w.wang@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: da3ae534-9098-4045-bc84-08da65606f25 x-ms-traffictypediagnostic: BL0PR11MB3137:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UbZ9im9/TWCOPYE8ijSthBhyU82UzI8/Np6PBGo+FgiqbHcLeAHxRE/hzeniLnIay+D9h7RuF2O03yaoWr7RDq3PeghZ8nQJGCd7ZjZkkQeCKUMWSN0uDKYfTQ/v5EDL9qtqnXAgK17czC1gdv3dLxzgbV7wHde7cUOMDNW3LG3RdyE71Hqn/URKeHIemJw5yPhG2REyHugogBTAiJPAy2aZa1VlTI3wv0IQ6KZ8cGiFQhoCAo2BpAlSnfjgQu4cv7Esozw3iMrcePttXC8nBdzj1ReAlDXQR0Atkzi5OaWl72uIdeO6YYMpY952qlaQKAlae0q37ZJdjDvUe+c8K+NdhnU0NOvc733xSd6HsqOshAK6xCk22r38/Prc97BFSkLq6NvMGUzqbJkTozBI2TGjyc4mETmLAfLTuoyUgxHFGg335gNZhkF5l1GCqTNDA2iLkI7iqrEjj0eHOB4Y2hkLh65gWzHtUSWu/aSi7PNYVWnyewEQQ//gcrEE2bYcmR61SlM3slTerVPrlhENW7a+yY6q5WHGwOm0iHwkyt/j7+4B0SAxfV+tTml/npYyTbd0x0/RTaw4jd1Rigmw3ChL47f/6DPdoND1HmuxdHVaqduHow+PaVHx1HZb8aCh0y3t8RP0rw1ghOoWCGdfZgDQ5H5KVDnVFOQfFWnSblKv5X4yrlKt9qFuB4xTFG2pgKRcqM0qgwaNevIID/2gRCDGwACnL3mHjz59QwDxQZoQxRYX6wnVRJTgYa7T4yeoD2d5kPuiSwHlU+SsV76TWucC7TFWWieJYBqQAxYWNOX6DtqVdF0sIigs0p+qF1zuDhP4iV1eiJL2Dc9f0sK0iA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(136003)(39860400002)(396003)(366004)(376002)(5660300002)(2906002)(316002)(54906003)(6486002)(6916009)(38070700005)(6506007)(71200400001)(26005)(36756003)(6512007)(41300700001)(478600001)(66476007)(38100700002)(107886003)(66946007)(4326008)(91956017)(8676002)(2616005)(64756008)(83380400001)(66446008)(122000001)(86362001)(8936002)(82960400001)(66556008)(186003)(76116006)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bEdsQUErQmlEWGhsVTZSUWQxbENjQlgzMFY5UjZNZko0TlY1c3N4QVExK3hp?= =?utf-8?B?cDhJRk0raTRIZGhXRGlYcHZzM1pDMTE2dGlJTkZUcFArVWJkNmhLT0RBZ0hK?= =?utf-8?B?K0piODJXV1cwVEVkajFESWhBamdSN25XR2pyNkxQNGJaOThycldZK3BGaUgr?= =?utf-8?B?SWRWYUhrRU5Rb2ZBUUZkdUNxSWZGV3VtSFllbVRYNS9TMi94TWRDdTg0c1Iy?= =?utf-8?B?aGlNeUZhNXBLZ2VvS3NiYUdrQnAzbERySE9vazVPVXdXbkQ2SHoraXNhaWhn?= =?utf-8?B?RnBGNFFJS3U1c3U0NW5VSStOQ01jWnVtN0lzZkR4WUphL0xwWTdBb1BrU1NM?= =?utf-8?B?MDVDaTJRSkZaanVVVkp0eXFDaXBaWVFRTWVQZ2Y4amFpN3h6SjVjdlU2SHlJ?= =?utf-8?B?UTBuTkpyYVJqMEdOQmVCZXZyTlFOZGsxdjlIallES2QrWU15aW9mdTNCMnFU?= =?utf-8?B?Z3NGV0JhM1hYa0IrS1JyamthTU1Rb0ZHQTFzTTJvNUp2ejF5UktscmlUbE1u?= =?utf-8?B?ZWR6c2o2UnBCTTdONlZZTDNNTFRTRno2bGJlUlpaaG9LcENCQnZCZ3hqaFR2?= =?utf-8?B?WmlQUGw0cnpaeTltYTlxSTZhUWF0YUVONCtHNng3RDI0WGhIQW9YbG9GbXdT?= =?utf-8?B?VGVGd3dpdTdOTlpDdk1UbGp1NzQwbC92ZnNZUkk4MmVwK3FESzhUWW8wdzRt?= =?utf-8?B?dGwzUUZNTVJoZFFBWllidG5tenJ2MTY3YUdPM25UUUZBM1FNZlhlUHNGN0M5?= =?utf-8?B?TERqRDdjc0xQaElBTVJLM3FtRjMvd0c0QytsS1NwOGg0UjJ0R3JiV1k1VVg2?= =?utf-8?B?S3IwdFRzNXl2S0tsMVVjREN3bU5BQVhycnE0RXhsOGY5dkVuTGNPeGVRS1BL?= =?utf-8?B?aVdRMWJLT2xVenNkWXZidlRKdE1GMXpDU3FlVlNBb1YvMU9RME04ZGtRUHRk?= =?utf-8?B?MWoxQ2trd1ZqZnUwZ1A3NnBWdm5ZeVUxZVRvWW9wZTZNanBmWXdPbDgwUWIx?= =?utf-8?B?UWh0U21keUlMVU84RXVBaVRRMTYyUVBldTdjMmhZVnJCN0JvK1JuRURaazdN?= =?utf-8?B?Q2wzdXRZdEJGemFMUG1CWXJlMVBBdDdpTUtjdGJZS3BUUkliWUV0M3h5RGl4?= =?utf-8?B?UGQvck9YNXE4OWJYS0ZhTlFoRjZlYml6YXRkZkM2T05qekFFbENqRSt4b3Ex?= =?utf-8?B?Wllaa1ZCSjM4NFRYd2pmbW9aMHRGRWdRdUZnUzIrdkR1ZUp4RXVoS25jYW1j?= =?utf-8?B?WmZodDNsZms5OWNMQjZkU1ZZWWJ5ZlFxN25wbHBvcmZEQlo1TFdXN08rM2w0?= =?utf-8?B?WVZCQ3h4TGpxMkJ3Q3ZWL2E0MnlKRGtzeXltRGVrSjNJRTNSQzRSUWdEVEt0?= =?utf-8?B?VUdiQU5FRlJzNlNBQVJrRDVmNU41Y1VpV1JnMFloRE0ybFZzck9WaUpuQm1B?= =?utf-8?B?RHFMRjlqUVIzVTJGWkNKWGJZWGhpQWFiRmtGbnlHU21kTnhjMlNXaUZ3R1BJ?= =?utf-8?B?ck83WGpsajgycmZFUU81KzJLRThSNUI2SUlSUy9SeDVQRkQxQXRSZXVSSXRK?= =?utf-8?B?RldIUkhvYm9lanp0bEU5SXVFY2FPbXNnSUlEY0k5UEwyaFZNMm13ZnNoVllR?= =?utf-8?B?RlhlN1pMQUNOd1BFcVk0ekpiUmxYelp5cmRmYVVtNnJ6dnFoeVVlcDZZSkdG?= =?utf-8?B?L1FJd2pJQldDd1BrT3J0U0E0TlVpUzg4eWNuQkhQZkVYU0dMV2lFR2x6ZVln?= =?utf-8?B?aVZqN2RkUWZKc09DRnpLWkNDSzBlTTdObzBtSk5KeW5hUy9QUXZTNVF3aDV6?= =?utf-8?B?dnZ2czI2d3RndGFhY09uZDl5UmJaSDZnL3BjZjFaa01LVzB1RXRCTW1tMHdC?= =?utf-8?B?NHI0NDVQT1J3bGJGbWNBdUhsMWdHNzRGUHJhbjdkYXYxdHdLNE9QN0wvdGJT?= =?utf-8?B?ZkpyL2NpVDRIaHdGOHpRRW5RcnhhckF5c1dHQ04zNFlTZzYrZmlMbThHK3Fy?= =?utf-8?B?SEhFb0JKMmNveFV5RDkzNzlkZVJhYnJmajlxU0w2bHJqWGZhZHl4TVFIOTg3?= =?utf-8?B?emxVaTNibFUzMHNuS1IwR0JybldwS0hqdjNPdzF3aUFRRnVyZWdVT3UxNURG?= =?utf-8?B?d0k0eEFxb1NFK0NIRnZxeGVsb1Q4THZmT1BtSG5oMkZqV1dPTTlvSFJsT1pt?= =?utf-8?B?cmc9PQ==?= Content-ID: <5ABD39652192C940BBE0322CFA09A996@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: da3ae534-9098-4045-bc84-08da65606f25 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 06:16:48.2043 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bbd2UadEes/unlVOq3EawmTNJPnk9TQmytWPwDEtEkksXfn0JQl0bEL/SSE+8F01r4GDAGWMVOuetGhoOtemhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3137 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 4/4] lavc/hevcdec: respect the value of no_output_of_prior_pics_flag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Xu, Guangxin" , "Wang, Fei W" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-06-14 at 09:23 +0800, Fei Wang wrote: > From: Xu Guangxin > > Even resolution or number of picture stores changes, we still need > follow no_output_of_prior_pics_flag in next IDR. > > Tested-by: Fei Wang > Signed-off-by: Xu Guangxin > --- > libavcodec/hevcdec.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c > index 99785aa5d1..b0317339a2 100644 > --- a/libavcodec/hevcdec.c > +++ b/libavcodec/hevcdec.c > @@ -594,15 +594,8 @@ static int hls_slice_header(HEVCContext *s) > > if (s->ps.sps != (HEVCSPS*)s->ps.sps_list[s->ps.pps->sps_id]->data) { > const HEVCSPS *sps = (HEVCSPS*)s->ps.sps_list[s->ps.pps->sps_id]- > >data; > - const HEVCSPS *last_sps = s->ps.sps; > enum AVPixelFormat pix_fmt; > > - if (last_sps && IS_IRAP(s) && s->nal_unit_type != HEVC_NAL_CRA_NUT) { > - if (sps->width != last_sps->width || sps->height != last_sps- > >height || > - sps->temporal_layer[sps->max_sub_layers - > 1].max_dec_pic_buffering != > - last_sps->temporal_layer[last_sps->max_sub_layers - > 1].max_dec_pic_buffering) > - sh->no_output_of_prior_pics_flag = 0; > - } > ff_hevc_clear_refs(s); > > ret = set_sps(s, sps, sps->pix_fmt); >From the context, sh->no_output_of_prior_pics_flag is NoOutputOfPriorPicsFlag in the spec. According to C.5.2.2, the decoder may set NoOutputOfPriorPicsFlag to no_output_of_prior_pics_flag or 1, but it is not allowed to set 0 in this case. This patch LGTM. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".