From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C5B5D46491 for ; Sun, 18 Jun 2023 11:24:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AA4EF68C1AA; Sun, 18 Jun 2023 14:24:20 +0300 (EEST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A7CAC68C186 for ; Sun, 18 Jun 2023 14:24:14 +0300 (EEST) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3f8f3786f20so26265925e9.2 for ; Sun, 18 Jun 2023 04:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687087454; x=1689679454; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ZgfDQAS3SPTAoDEIpYUixRLE2Iyd/zg8fw4dtiBRx8Q=; b=pLkdWfGJzAS33wMJnh0JV8AyOCzI7NhOA25Ex1S66NgoqfwxDJGi2FxTHM2sKw0apQ w/sSSYKUQd3xT0jxwAUJjyl5dqxpnW3Xc1LfFaLU5R4hJBCVML5sE4Sonb6di1Gr93m7 P39RxO/qyLkMI/2GkAkxLLJ+ViYRQookSjGHsfVd/mjO9GZFiNkZ/fJQ1H7xKBb5uj9I SrYOrf5VthJBiY3pGPnRJA47XJvKeTmo2Fqc5GQ1NrIsoG+VB6cLT/ALOqP1PINIXy89 YHtNX26jSdV46VOh5nTy/DZztYcMYH52g5UCDBn4F72Dsve/9uYakzWsa2oThistwLqH hiPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687087454; x=1689679454; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZgfDQAS3SPTAoDEIpYUixRLE2Iyd/zg8fw4dtiBRx8Q=; b=YPP56+yFltzLJMdaZcBKnjfXXnF+EDnhRhkjN+2yFvUoeHfyS9xAqj6aJNGEMMIIEX zV5iHpKHMe9I/UQzTS99NWNS9YctEqikuUmH0c6zshsnlrzelpVwmPOF8V7NNC64OuEN f2SVno9npNlOm64vTxLy6AkxU40hvjDppUknSzIDr4o1b3x+1fGuGaqSEJc/HTbIaitl 4j8FS34L2f9bRGmuXhuw8eRDG9ub7E2CvaZf8xWDv10CWpmez+Wk0qZaIhEZmvho8H9t ZOkfx+iF7ymqK5AI6xU7JIGS8ShQZmvKfumvaxORotzled+muVQqQwGu7TxPMUmzpqBR IsCw== X-Gm-Message-State: AC+VfDyLBNKK5fUaQNUreESzHExdmETZln6RTtHZtPxIzV4XduRhLF4E +1UyJUqyeOjQtrwFsEqHzSpvaPRKeVQ= X-Google-Smtp-Source: ACHHUZ7uUBjAXOnNICK6JitQ1o7k1N1rUg1PTd2n+QeiU9qCoxdRyVxB6jlNl5PL5XergGULn8pcZQ== X-Received: by 2002:a05:600c:3c9:b0:3f7:3401:17ac with SMTP id z9-20020a05600c03c900b003f7340117acmr6365237wmd.5.1687087453589; Sun, 18 Jun 2023 04:24:13 -0700 (PDT) Received: from [192.168.1.106] (33bf156e.skybroadband.com. [51.191.21.110]) by smtp.googlemail.com with ESMTPSA id k24-20020a7bc318000000b003f733c1129fsm7456739wmj.33.2023.06.18.04.24.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jun 2023 04:24:13 -0700 (PDT) Message-ID: <6f84a678-8a0e-f1e0-f3bc-ad69c4761409@gmail.com> Date: Sun, 18 Jun 2023 12:24:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 To: ffmpeg-devel@ffmpeg.org References: <20230617180754.216755-1-leo.izen@gmail.com> From: Derek Buitenhuis In-Reply-To: <20230617180754.216755-1-leo.izen@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec: use sRGB to stringify gbr/bt709/iec61966-2-1 instead X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/17/2023 7:07 PM, Leo Izen wrote: > - if (strcmp(col, pri) || strcmp(col, trc)) { > + if (enc->colorspace == AVCOL_SPC_RGB && > + enc->color_primaries == AVCOL_PRI_BT709 && > + enc->color_trc == AVCOL_TRC_IEC61966_2_1) { > + av_bprintf(&bprint, "sRGB, "); > + } else if (strcmp(col, pri) || strcmp(col, trc)) { I real dont think special casing a single colorspace like this is a good idea, nor do I think hiding the explicit values is. Same reason we do not special case e.g. HLG. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".