From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec: use sRGB to stringify gbr/bt709/iec61966-2-1 instead
Date: Sun, 18 Jun 2023 12:24:12 +0100
Message-ID: <6f84a678-8a0e-f1e0-f3bc-ad69c4761409@gmail.com> (raw)
In-Reply-To: <20230617180754.216755-1-leo.izen@gmail.com>
On 6/17/2023 7:07 PM, Leo Izen wrote:
> - if (strcmp(col, pri) || strcmp(col, trc)) {
> + if (enc->colorspace == AVCOL_SPC_RGB &&
> + enc->color_primaries == AVCOL_PRI_BT709 &&
> + enc->color_trc == AVCOL_TRC_IEC61966_2_1) {
> + av_bprintf(&bprint, "sRGB, ");
> + } else if (strcmp(col, pri) || strcmp(col, trc)) {
I real dont think special casing a single colorspace like this is a good idea,
nor do I think hiding the explicit values is.
Same reason we do not special case e.g. HLG.
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-06-18 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-17 18:07 Leo Izen
2023-06-18 11:24 ` Derek Buitenhuis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f84a678-8a0e-f1e0-f3bc-ad69c4761409@gmail.com \
--to=derek.buitenhuis@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git