From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6CC8140CAE for ; Wed, 7 Sep 2022 08:56:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B40ED68B7C7; Wed, 7 Sep 2022 11:55:58 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C695C68BB3E for ; Wed, 7 Sep 2022 11:55:52 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 2878tc4r023372-2878tc4s023372; Wed, 7 Sep 2022 11:55:38 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 142E1A1407; Wed, 7 Sep 2022 11:55:37 +0300 (EEST) Date: Wed, 7 Sep 2022 11:55:37 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Hubert Mazur In-Reply-To: <20220906102722.53266-1-hum@semihalf.com> Message-ID: <6f6a8194-1f38-20e3-3385-ff12b9f3bf4c@martin.st> References: <20220906102722.53266-1-hum@semihalf.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 0/5] Provide optimized neon implementation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, ffmpeg-devel@ffmpeg.org, mw@semihalf.com, spop@amazon.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 6 Sep 2022, Hubert Mazur wrote: > Provide optimized implementations for me_cmp functions. > This set of patches fixes all issues addressed in previous review. > Major changes: > - Remove redundant loads since the data can be reused. > - Improve style. > - Fix issues with unrecognized symbols. Thanks! This looks quite good to me now. I have a minor comment on vsse16 and a slightly bigger one on nsse16, but other than that, this is almost good to go. I noticed that you haven't updated the checkasm benchmark numbers in the commit messages since the previous round, while the code has seen some quite major changes. Please do rerun the numbers since I think they have changed notably. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".