From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id EDC7947D29
	for <ffmpegdev@gitmailbox.com>; Tue, 19 Dec 2023 13:36:22 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 104B868D111;
	Tue, 19 Dec 2023 15:36:19 +0200 (EET)
Received: from glom.nmugroup.com (unknown [193.183.80.6])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0803E68CF7F
 for <ffmpeg-devel@ffmpeg.org>; Tue, 19 Dec 2023 15:36:12 +0200 (EET)
Received: from localhost (localhost [127.0.0.1])
 by glom.nmugroup.com (Postfix) with ESMTP id 4C08F54285CE
 for <ffmpeg-devel@ffmpeg.org>; Tue, 19 Dec 2023 14:36:12 +0100 (CET)
Received: from [192.168.1.117] (81-233-159-219-no2430.tbcn.telia.com
 [81.233.159.219]) (Authenticated sender: git01)
 by glom.nmugroup.com (Postfix) with ESMTPSA id 1E5EF54285A9
 for <ffmpeg-devel@ffmpeg.org>; Tue, 19 Dec 2023 14:36:11 +0100 (CET)
Message-ID: <6f69f808de8c7d6080e6a61b72575717252c3a45.camel@haerdin.se>
From: Tomas =?ISO-8859-1?Q?H=E4rdin?= <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Date: Tue, 19 Dec 2023 14:36:11 +0100
In-Reply-To: <7c1649cd-8b35-47fa-89d6-f7dfc11350e4@ektacom.com>
References: <7c1649cd-8b35-47fa-89d6-f7dfc11350e4@ektacom.com>
User-Agent: Evolution 3.46.4-2 
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] [MXF] - Add jpeg2000 subdescriptor in
 MXF file.
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/6f69f808de8c7d6080e6a61b72575717252c3a45.camel@haerdin.se/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

> +    for ( comp = 0; comp < component_count; comp++ ) {
> +        avio_write(pb, &sc->j2k_info.j2k_comp_desc[3*comp] , 3);
> +    }

Looks like this could be simplified to just

  avio_write(pb, sc->j2k_info.j2k_comp_desc, 3*component_count);

> +    if (j2k_ncomponents != component_count) {
> +        av_log(s, AV_LOG_ERROR, "Incoherence about components image
> number.\n");
> +    }

I again feel this should be a hard error

> +    for (comp = 0; comp < j2k_ncomponents; comp++) {
> +        sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents] =
> bytestream2_get_byteu(&g);   // Bitdepth for each component
> +        sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents+1] =
> bytestream2_get_byteu(&g); // Horizontal sampling for each component
> +        sc->j2k_info.j2k_comp_desc[comp*j2k_ncomponents+2] =
> bytestream2_get_byteu(&g); // Vertical sampling for each component
> +    }

Could be simplified to a single avio_read()

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".